From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F10DB43EE9; Tue, 23 Apr 2024 12:58:40 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D066940E54; Tue, 23 Apr 2024 12:58:40 +0200 (CEST) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mails.dpdk.org (Postfix) with ESMTP id CEE49402AB for ; Tue, 23 Apr 2024 12:58:39 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 3E9C3339; Tue, 23 Apr 2024 03:59:07 -0700 (PDT) Received: from [192.168.50.86] (usa-sjc-mx-foss1.foss.arm.com [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 327853F7BD; Tue, 23 Apr 2024 03:58:38 -0700 (PDT) Message-ID: Date: Tue, 23 Apr 2024 11:58:37 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1] dts: rename execution to test run Content-Language: en-GB To: =?UTF-8?Q?Juraj_Linke=C5=A1?= , thomas@monjalon.net, Honnappa.Nagarahalli@arm.com, jspewock@iol.unh.edu, probb@iol.unh.edu, paul.szczepanek@arm.com, npratte@iol.unh.edu Cc: dev@dpdk.org References: <20240419085108.97519-1-juraj.linkes@pantheon.tech> From: Luca Vizzarro In-Reply-To: <20240419085108.97519-1-juraj.linkes@pantheon.tech> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Juraj! I am not fussed about naming but I am certainly in favour of making things less confusing, so I am happy with this change. On 19/04/2024 09:51, Juraj Linkeš wrote: > @staticmethod > def from_dict( > - d: ExecutionConfigDict, > + d: TestRunConfigDict, > node_map: dict[str, Union[SutNodeConfiguration | TGNodeConfiguration]], > - ) -> "ExecutionConfiguration": > + ) -> "TestRunConfiguration": > > - def copy_and_modify(self, **kwargs) -> "ExecutionConfiguration": > + def copy_and_modify(self, **kwargs) -> "TestRunConfiguration": > > @staticmethod > def from_dict(d: ConfigurationDict) -> "Configuration": Unrelated, but spark for an improvement. I have noticed these, not sure if there are more instances in the code. Shouldn't from_dict be a @classmethod instead of @staticmethod. In which case you could also use: from typing_extensions import Self to replace all the class literals, example: @classmethod def from_dict(cls, d, node_map): -> Self: ... return cls(...) # initialise class with cls ... def copy_and_modify(self, **kwargs) -> Self: