Re: [PATCH v6 5/7] bbdev: add new operation for FFT processing

[Maxime Coquelin <maxime.coquelin@redhat.com>]

On 8/25/22 20:24, Nicolas Chautru wrote:
> Extension of bbdev operation to support FFT based operations.
> 
> Signed-off-by: Nicolas Chautru <nicolas.chautru@intel.com>
> Acked-by: Hemant Agrawal <hemant.agrawal@nxp.com>
> ---
>   doc/guides/prog_guide/bbdev.rst | 130 +++++++++++++++++++++++++++++++++++
>   lib/bbdev/rte_bbdev.c           |  10 ++-
>   lib/bbdev/rte_bbdev.h           |  76 ++++++++++++++++++++
>   lib/bbdev/rte_bbdev_op.h        | 149 ++++++++++++++++++++++++++++++++++++++++
>   lib/bbdev/version.map           |   4 ++
>   5 files changed, 368 insertions(+), 1 deletion(-)
> 
> diff --git a/doc/guides/prog_guide/bbdev.rst b/doc/guides/prog_guide/bbdev.rst
> index 70fa01a..150161b 100644
> --- a/doc/guides/prog_guide/bbdev.rst
> +++ b/doc/guides/prog_guide/bbdev.rst
> @@ -1118,6 +1118,136 @@ Figure :numref:`figure_turbo_tb_decode` above
>   showing the Turbo decoding of CBs using BBDEV interface in TB-mode
>   is also valid for LDPC decode.
>   
> +BBDEV FFT Operation
> +~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> +
> +This operation allows to run a combination of DFT and/or IDFT and/or time-domain windowing.
> +These can be used in a modular fashion (using bypass modes) or as a processing pipeline
> +which can be used for FFT-based baseband signal processing.
> +In more details it allows :
> +- to process the data first through an IDFT of adjustable size and padding;
> +- to perform the windowing as a programmable cyclic shift offset of the data followed by a
> +pointwise multiplication by a time domain window;
> +- to process the related data through a DFT of adjustable size and depadding for each such cyclic

depadding?

> +shift output.
> +
> +A flexible number of Rx antennas are being processed in parallel with the same configuration.
> +The API allows more generally for flexibility in what the PMD may support (cabability flags) and

s/cabability/capability/

With above typos fixed:
Acked-by: Maxime Coquelin <maxime.coquelin@redhat.com>

Thanks,
Maxime