DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: "Loftus, Ciara" <ciara.loftus@intel.com>,
	"Zhang, Qi Z" <qi.z.zhang@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] net/af_xdp: do not use fixed size storage for pointer
Date: Wed, 11 Nov 2020 13:25:59 +0000
Message-ID: <c5597119-0295-1b24-8621-a36976e4dad9@intel.com> (raw)
In-Reply-To: <14e704b269f94f3ea8b52cdfbf3f3d4c@intel.com>

On 11/9/2020 6:00 PM, Loftus, Ciara wrote:
>> 'uint64_t' is used to hold the pointer, for 32-bits build this
>> assumption is wrong and giving following build error:
>> rte_eth_af_xdp.c: In function ‘xdp_umem_configure’:
>> rte_eth_af_xdp.c:970:15:
>>      error: cast to pointer from integer of different size
>>             [-Werror=int-to-pointer-cast]
>>    970 |   base_addr = (void *)get_base_addr(mb_pool, &align);
>>        |               ^
>> Replacing the 'uint64_t' return type of the 'get_base_addr()' to the
>> 'uintptr_t'.
>> Although not sure if the overall logic supports the 32-bits, using
>> 'uintptr_t' should be safe both for 64/32 bits.
>> Fixes: d8a210774e1d ("net/af_xdp: support unaligned umem chunks")
>> Cc: stable@dpdk.org
>> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
>> ---
>> Hi Ciara,
>> I am not sure if 32-bit is supported for the af_xdp, but even not does
>> this change make sense for the 64-bits?
> Hi Ferruh,
> LGTM. I've tested it for 64bit and all looks good to me.
> Tested-by: Ciara Loftus <ciara.loftus@intel.com>
> I've been looking into 32-bit compatibility and will submit a patch for at least the docs when I've verified what works.

Applied to dpdk-next-net/main, thanks.

      reply	other threads:[~2020-11-11 13:26 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-09 13:30 Ferruh Yigit
2020-11-09 18:00 ` Loftus, Ciara
2020-11-11 13:25   ` Ferruh Yigit [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c5597119-0295-1b24-8621-a36976e4dad9@intel.com \
    --to=ferruh.yigit@intel.com \
    --cc=ciara.loftus@intel.com \
    --cc=dev@dpdk.org \
    --cc=qi.z.zhang@intel.com \
    --cc=stable@dpdk.org \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:

AGPL code for this site: git clone https://public-inbox.org/public-inbox.git