From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BC8CA42B19; Tue, 16 May 2023 01:36:05 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8D75D41151; Tue, 16 May 2023 01:36:05 +0200 (CEST) Received: from NAM02-BN1-obe.outbound.protection.outlook.com (mail-bn1nam02on2049.outbound.protection.outlook.com [40.107.212.49]) by mails.dpdk.org (Postfix) with ESMTP id 233BE42670; Tue, 16 May 2023 01:36:04 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mI2xKpKEbPpjaRM3GUm9T9qMVE5OCh7182683jpxxqisOsZazQ62oOKRn24JptNFWbTyo8tYXRSnPunpzqEkg2a/sG4rMU0js1Vj/Q0xrU4hTtCLVUax8pt9xM+tXmyuMs6waVIkBRYwpBhtqRw9m6xRb9osh+clCeeP8TCHB81addEZh53pHzkPaVtItJZ5GM2aqjLQg4YojIDff92lLBimjeeMKpxDpA3HLqcFORUT2aQyEb0O52hONkD7n/GXMyhf71K7d1OJIxB6M1JvbuQGcJ57/lEvxby3E+qAdEz2uE7CykyAh8uLU3e+PKSKlItSz9dmfjePR0BJmfS0CA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TieWySTM49p0IMxtT9UGq6qmc7OkvIembwflmRYBdfg=; b=Bk/GseOK3HR+479/h8QnAmb0yDOnFmFJtNB5wngWbRJA4r8VZ0AagxzD/pKXF4ezsqxVtbCoXac6iQPHRr35M7wXXGYHto5gSksgpCT9uVv6kadyv2rZhO7Vz1WfrxKZtwY1D+vGzmYG2+w4mwiMMTUz1s8+Q0BEQtgmJ1u3B83OrPELQykmSm7Z8Tx+6H757EMoAFlDib9SEOmxXR2o6gKWM9ztuz8YaWdoeTDg5+THNzQGvY7q2zfEYcU+XIQzWgMdal5CoHVAJnjaH3SGx2MoL8FOlmOw2gKSZjfdLacmlAzOrco3jUEcR0h3WnhiYCe3jM5YzAAgxqsTdLsOog== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TieWySTM49p0IMxtT9UGq6qmc7OkvIembwflmRYBdfg=; b=Z03c3sNGBejcp8EZ6C7BqZDZROqN7chCnxXAr5xpsQ1X3DjLTUF2zSPfQ9bE8TlJrG6swrCSr9Bd66fPLOZu9Dejpz29dozIHoqug8G1Vnd+mbUpPV3FHVjAULGPT+eKrz2SKWwUquD5zj6/f9UG1mbHKXlh86pxkplvCRhORyw= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by DM6PR12MB4153.namprd12.prod.outlook.com (2603:10b6:5:212::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6387.30; Mon, 15 May 2023 23:36:02 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::7957:641d:6aba:3f9a]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::7957:641d:6aba:3f9a%4]) with mapi id 15.20.6387.030; Mon, 15 May 2023 23:36:01 +0000 Message-ID: <c55980ec-08e7-b830-bb60-3179c3aecf43@amd.com> Date: Tue, 16 May 2023 00:35:56 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Content-Language: en-US To: Stephen Hemminger <stephen@networkplumber.org> Cc: David Christensen <drc@linux.vnet.ibm.com>, dev@dpdk.org, stable@dpdk.org References: <20230322212439.524725-1-drc@linux.vnet.ibm.com> <20230323170145.129901-1-drc@linux.vnet.ibm.com> <165a233b-b41b-3a65-1866-5b7c94993b40@amd.com> <20230515162032.36a4f3ec@hermes.local> From: Ferruh Yigit <ferruh.yigit@amd.com> Subject: Re: [PATCH v2] net/tap: resolve stringop-overflow with gcc 12 on ppc64le In-Reply-To: <20230515162032.36a4f3ec@hermes.local> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0485.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1a8::22) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|DM6PR12MB4153:EE_ X-MS-Office365-Filtering-Correlation-Id: c0deedc7-7147-4700-1890-08db559d24a3 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: GFsbUzORO9HNo4rUPwCt2QwiaEViXTdLd+Y7mkpNnNf+tto9MaNOkPzLomY2GlZoEhmHDXzuTBEFauqQcEeZRaBHmAS3VdkPs0JwUMZ9VkjrN9vnMh6xAA6Eh2x1+Xj/ySGx7U9xB8mTzO0hgkG0DKXjdbZCkjx64ZTsrpnFh3OOTMwTK9tKOHs+Ib+TDb/+k7E9+1y2glOqYgK5cNsrjr2NCR6kBz3ELMZech1bJ0oawNA/ARAZWHGSDK7ZYsihxDudqjv/tN4HvQ6Qk36Eh/wE3toqupIBWAVShyLb2O++3iFP05iJBQUBjfH5b2CDzxjQxMQ6C030N9qAhvJk75LWhyca4TNw4LHSk8CDJj4j3eL7alH7plsIZ8FBEzi3pGRz32EM51ruXfQhXaACxfyLmNWH8htHkRV2K9TRcH750NwpuPvdRxLJt6i9z6m2EbQzFXuV8vjNhlLnUAbU3h1S2R8YUZTg/7qKIqTChyrXSdjogV7wxgZ/EYirZ4meWGmnUreoLEsf2FU49ZWCT3zAWgzkgx8hL/gp7mlKmFt7W5SCM919Y8Mn63/zrsSurVaV0H/myFIcF+n0mt1GFspiWTk37qcLDesyxK09I8YX+8mavYMlNvPyqA84GzhDSZIDueq05oh/8CuIzm1yiQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(136003)(39860400002)(366004)(396003)(346002)(376002)(451199021)(36756003)(86362001)(316002)(478600001)(6916009)(4326008)(66946007)(66556008)(66476007)(6486002)(2616005)(8676002)(8936002)(5660300002)(2906002)(44832011)(6666004)(38100700002)(41300700001)(31696002)(6512007)(83380400001)(26005)(53546011)(186003)(6506007)(31686004)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cnpIUmVQNFVUa0xRWXQ4dWdVU0tteUpyWE5HdFRQR1c3aVl2QVo3b2tYbFA3?= =?utf-8?B?bU5JcGl6aFBZdmJOeDM5c0tTMHcyTFFtVHpmd2c4cE9BdGhxei92Q25paks0?= =?utf-8?B?SDdUVVEzQXFlS1hCRTIzejIwK0JVdHlDZHdyMmppdVRpUVlwZFhaeDVVdjVL?= =?utf-8?B?YmZQMDk3MUV6MmFnNjBSV3hoeHltSmhUTm5tdVlPWkluaW1DRDdud0NTeTQw?= =?utf-8?B?RDhlWVgvaGM0bDVYZmVHNXk4OTkvN3VsR1FINUlwY1E5M3l2TVdyTzlPOXJZ?= =?utf-8?B?UHE5cGtwYWF6Sis2S3c3Vm9KVTVzelVERlhZTGtkdnAzTEJDU3BrNW1ZR2Zy?= =?utf-8?B?b1crY1hPRzVicnRldFlETTgxSUNBcGo4RmQ1ZWNjWUhVVEhxUk5ZTEloLzdB?= =?utf-8?B?cFc2Lzk1YW9ySHNjRUFseE9zUDBUbEFMQmN5Y3Z1RmJpN1VqQWtXVUt5cTVJ?= =?utf-8?B?M1pRbHJJYjZNYytQMkNVZWNkNTNidEVaUUhtckgyc2Jkd2txWGJRVVYvVEQ0?= =?utf-8?B?L0QyMmJBaFdSdEgrNmw4Sm1YSWNmQ2phTFZuWUhncGxCNDZDMlUxVmlETUIv?= =?utf-8?B?dW5HWG5NOHNiSXFJaDU5MDYvdTh0Q3NDSzZkcFVIdjA5SXc4eHlJTHFZdll3?= =?utf-8?B?V25nQjBTN3dsbjZ5VDBmbVFHSmVUdW53bnhha2V0OUxCTkVKQk1zWWd3cnhv?= =?utf-8?B?R1JSQ2xtZENua2dZb05FcU5YWFdvWWlIekJObzZua1RKREttQnllakJyK2dt?= =?utf-8?B?ck9PUDY2cFBWSHAxcVpHMS9nNENDaGJrQXFSMGNkTWd6UDV2VWIzTnVEUkgw?= =?utf-8?B?UXZFN1VjVHp1L1FtWjdhOUxIc3RQR1JoK3N3QnJDeEJadnFJVVIwc3pEdmts?= =?utf-8?B?WXFZTTRtemxETmpMNzRyREFTVjcyK0UxcXZERGVMV0ZXNkswOU5mMGk4U3B6?= =?utf-8?B?ZFprb3l3NFJsRThwYkhnU29VTFVPOUlhS2VWaVZwMVNpV0hrZFNpMlJYY1VC?= =?utf-8?B?RkpDZGIrMndJcStydGV0RmZxR0J5MzFTQTdxUUNnWWxlK2dNd0xFQk9nR2F0?= =?utf-8?B?RWcrUUxWOVZYRnNsN1hia2JaTWgyS1E2eENWRWJ4cWJxanJ3Z2xvZ1YzQUl1?= =?utf-8?B?MU9MMVBucHZaWklhTGQyNHhmdzFqdTFWbGQwNTFnbGdNWWNSb29hUDRoc0pu?= =?utf-8?B?ZXZPcHVwL2dMd2t3czNWYWxZalczeVZRT0g1VnZWb0lLRHc3Q3dhcmxLS1Zq?= =?utf-8?B?N0JveFUycXQ3a1BqQjRZYko2VFRjMlJPYlBmQm1QRnhHRDJHTVVUKzNheWph?= =?utf-8?B?SmxBYXFpVU1lVk5lQkdJSUtUYVluZlB3cVpzVmU1dnFRVkdBMWFqSzlub3Y3?= =?utf-8?B?YVJvQ0JYUFEzem1hU09NV2NxMnQwRUtDMzdZZld1OWtnWlljSjMrWXFXVWZr?= =?utf-8?B?Qmp3NzJRUjdDSmliTExuQ0JVRDNmUVMzejlRbW1UZFJ0LzdwczlZRWJndHRu?= =?utf-8?B?TEtZYW5wZ1AycE9hWlZic04vUXlMTDlZVFhIT0JEKzVLYzcxNzM5RmhDbThU?= =?utf-8?B?a0lnWFdEeHR4YVM1YTladk5hTTlIZ2VqVXR6VjNzRWNuLzd4b1o3WXlHSmZ0?= =?utf-8?B?dVpvWUpDUzhNSTB3b3lNU002ZXlEc2JiUmJQMTlMc0Q1b1MxcFdyZDl5elB0?= =?utf-8?B?allBd05sZHN3dXdIcHJBSm9xS2oyNlpGQWpxZjRkQXNoa2dra2tkR1lmWk5J?= =?utf-8?B?Z2taUmN2L3o3ZUxDQ2JCQmhWbFlqS0ZmY3QrR1Q1TStXdG9GUUNZb293ZWRE?= =?utf-8?B?WHcvODgyODZnTGs3TkZFUE9hblRVVTNVQytBQ3BNZm1mZUtpckk0NjB0Qm5u?= =?utf-8?B?Y3ZsM2U4SFlwbFhBL2FsQllmemRqbDR4OVc0SWZBa1o2OXZyajdSUGN2bnR5?= =?utf-8?B?cGd1N3phakZiblJLWkZrSUdOaVZ1dWk0T0RBVjNweHRBQzVPSFlZL05CNVdE?= =?utf-8?B?SFNvdndVejVrQXVQNStpS2tGMjVBVDNPREpRYStiRGkvbDZlc0JaSnowV3Ev?= =?utf-8?B?L282b0p1aU9SVUlqdnRSQk1DNFNuRUI4NnFJTlR2TTNYOWlCcE1DVWNJVjhh?= =?utf-8?Q?iP1jyRkFh/cloKgrVBxciYIz3?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: c0deedc7-7147-4700-1890-08db559d24a3 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 May 2023 23:36:01.8187 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: YPA2jL6wc6DJ07Muf4B6z+yFVKeuxgysd+BdlpXQkQ6IyZSeqx4DDEolc3pawvBt X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4153 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org On 5/16/2023 12:20 AM, Stephen Hemminger wrote: > On Tue, 16 May 2023 00:14:52 +0100 > Ferruh Yigit <ferruh.yigit@amd.com> wrote: > >> Hi David, >> >> I confirm the build error, btw it helps to future references to put >> build failure to the commit log, >> >> and change is reasonable to convert PMD local parse function to an API, >> BUT my concern is they don't behave exactly same, which changes user >> interface of the driver. >> >> The 'rte_ether_unformat_addr()' API expects exact "XX:XX:XX:XX:XX:XX or >> XXXX:XXXX:XXXX" format. >> Like 'parse_user_mac()' accepts 'a:a:a:a:a:a' as input, but API requires >> '0A:0A:0A:0A:0A:0A'. >> >> This is a small change but still may create a bad experience if an >> existing user/script hit by this, and I believe we don't have a strong >> reason to change the interface. >> >> >> To keep behavior same, we can either update 'rte_ether_unformat_addr()' >> to accept singe chars between ':', >> or fix the existing 'parse_user_mac()' for compiler warning, what do you >> think? > > This is the kind of change where a simple release note will suffice. > > Not sure if anyone beyond some test script would ever use this anyway. Yes only some scripts and possible applications that hotplug tap interface with hardcoded parameters may impacted, don't know how big is this amount but this ends up breaking something that was working before upgrading DPDK for them. And I believe the motivation is weak to break the behavior. Won't it be better to update 'rte_ether_unformat_addr()' to accept more flexible syntax, and use it? Is there any disadvantage of this approach?