From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8096BA0540; Mon, 13 Jul 2020 14:16:04 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B8F641D675; Mon, 13 Jul 2020 14:16:03 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 38D911D66F for ; Mon, 13 Jul 2020 14:16:02 +0200 (CEST) IronPort-SDR: rID7BiuArv1Uycnnx4EeNk8t/8GUzv56zDKhq3qqbcgz0XA/5LkJQCCFVqjaGAQhZnVUElryB2 IqTjBerRBJgA== X-IronPort-AV: E=McAfee;i="6000,8403,9680"; a="136766088" X-IronPort-AV: E=Sophos;i="5.75,347,1589266800"; d="scan'208";a="136766088" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Jul 2020 05:16:01 -0700 IronPort-SDR: LFutGCqS1/1LhxPXwjozgqAgfXC/9flCeh7T7n8iB2hYa/0TVVKKty/cEAB5ta/wXEKlsNRnxO DU66ud/A+m+w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,347,1589266800"; d="scan'208";a="459271792" Received: from silpixa00399498.ir.intel.com (HELO silpixa00399498.ger.corp.intel.com) ([10.237.222.52]) by orsmga005.jf.intel.com with ESMTP; 13 Jul 2020 05:16:00 -0700 From: Anatoly Burakov To: dev@dpdk.org Cc: David Hunt , reshma.pattan@intel.com Date: Mon, 13 Jul 2020 13:15:58 +0100 Message-Id: X-Mailer: git-send-email 2.17.1 Subject: [dpdk-dev] [PATCH 1/2] power: fix power management env detection X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Anything coming from sysfs has a newline at the end. Cut it off before comparing the strings. Fixes: 20ab67608a39 ("power: add environment capability probing") Signed-off-by: Anatoly Burakov --- lib/librte_power/power_common.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/lib/librte_power/power_common.c b/lib/librte_power/power_common.c index 59023d986b..fd527719cd 100644 --- a/lib/librte_power/power_common.c +++ b/lib/librte_power/power_common.c @@ -15,6 +15,7 @@ int cpufreq_check_scaling_driver(const char *driver_name) { unsigned int lcore_id = 0; /* always check core 0 */ + size_t len; char fullpath[PATH_MAX]; char readbuf[PATH_MAX]; char *s; @@ -39,6 +40,10 @@ cpufreq_check_scaling_driver(const char *driver_name) if (s == NULL) return 0; + /* when read from sysfs, driver name has an extra newline at the end */ + len = strnlen(readbuf, sizeof(readbuf)); + readbuf[len - 1] = '\0'; + /* does the driver name match? */ if (strncmp(readbuf, driver_name, sizeof(readbuf)) != 0) return 0; -- 2.17.1