From: Radu Nicolau <radu.nicolau@intel.com>
To: Chas Williams <3chas3@gmail.com>
Cc: dev@dpdk.org, Declan Doherty <declan.doherty@intel.com>,
Chas Williams <chas3@att.com>,
stable@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] net/bonding: set started flag at the end of dev start
Date: Wed, 25 Jul 2018 09:53:00 +0100 [thread overview]
Message-ID: <c587b43c-0762-8ead-f7dc-130bc010cfb6@intel.com> (raw)
In-Reply-To: <CAG2-GkkzLNRdWpKs5cw_+G1ux4vB3Qj-2CkDV-WVeZA2CEvWsw@mail.gmail.com>
On 7/24/2018 3:34 PM, Chas Williams wrote:
> I think this adds another race. In
> bond_ethdev_slave_link_status_change_monitor(), it checks to see if
> bonding is started, if not it exits. So you need to have dev_started
> = 1 set before you enable this callback.
>
Indeed, I will have another look at this. Thanks for reviewing!
Can you also have a look at this one? https://patches.dpdk.org/patch/43187/
I think I addressed all your previous feedback.
next prev parent reply other threads:[~2018-07-25 8:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-20 10:02 Radu Nicolau
2018-07-24 14:34 ` Chas Williams
2018-07-25 8:53 ` Radu Nicolau [this message]
2018-07-25 9:39 ` [dpdk-dev] [PATCH v2] net/bonding: fix race condition Radu Nicolau
2018-07-27 10:55 ` Chas Williams
2018-08-05 0:09 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c587b43c-0762-8ead-f7dc-130bc010cfb6@intel.com \
--to=radu.nicolau@intel.com \
--cc=3chas3@gmail.com \
--cc=chas3@att.com \
--cc=declan.doherty@intel.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).