DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Hunt, David" <david.hunt@intel.com>
To: Omer Yamac <omer.yamac@ceng.metu.edu.tr>
Cc: <dev@dpdk.org>, <stable@dpdk.org>
Subject: Re: [PATCH] examples/distributor: update dynamic configuration
Date: Tue, 28 Jun 2022 09:12:01 +0100
Message-ID: <c5d3c153-3b11-7cc6-4e86-8f0be5559c5b@intel.com> (raw)
In-Reply-To: <253c41b6beadccd1c65bd4bd4eb4442f@ceng.metu.edu.tr>

Hi Ömer,

On 27/06/2022 17:28, Omer Yamac wrote:
> Hi David,
>
> Thank you for your review. I have two questions. The first one is 
> about new release. As I remember new DPDK realize will be published in 
> a short time and my previous fix in that release. Therefore, Should I 
> wait for that release to submit patch?
>

Yes, You can wait, or you can submit to the mailing list now and mark 
the patch as "Deferred" in patchwork. Once 22.07 is released it will get 
marked as "New", and under consideration for 22.11.


> The other question is below,
>
> On 27.06.2022 18:51, Hunt, David wrote:
>> Hi Ömer,
>>
>> I've a few comments:
>>
>> On 21/06/2022 21:15, Abdullah Ömer Yamaç wrote:
>>> In this patch,
>>>     * It is possible to switch the running mode of the distributor
>>> using the command line argument.
>>>     * With "-c" parameter, you can run RX and Distributor
>>> on the same core.
>>>     * Without "-c" parameter, you can run RX and Distributor
>>> on the different core.
>>>     * Syntax error of the single RX and distributor core is fixed.
>>>     * When "-c" parameter is active, the wasted distributor core is
>>> also deactivated in the main function.
>>>
>>> Fixes: 4a7f40c0ff9a ("examples/distributor: add dedicated core")
>>> Cc: stable@dpdk.org
>>>
>>> Signed-off-by: Abdullah Ömer Yamaç <omer.yamac@ceng.metu.edu.tr>
>>>
>>> --- 


--snip--


>>>                   "1 lcore for stats (can be core 0)\n"
>>> @@ -733,6 +808,15 @@ main(int argc, char *argv[])
>>>                   "1 lcore for packet TX\n"
>>>                   "and at least 1 lcore for worker threads\n");
>>>   +    if (rte_lcore_count() < 4 && enable_lcore_rx_distributor)
>>> +        rte_exit(EXIT_FAILURE, "Error, This application needs at "
>>> +                "least 4 logical cores to run:\n"
>>> +                "1 lcore for stats (can be core 0)\n"
>>> +                "1 lcore for packet RX and distribution\n"
>>> +                "1 lcore for packet TX\n"
>>> +                "and at least 1 lcore for worker threads\n");
>>> +
>>
>>
>> the two checks above could be replaced with something like:
>>
>> min_cores = 4 + enable_lcore_rx_distributor;
>> if (rte_lcore_count() < min_cores)
>>                 rte_exit(EXIT_FAILURE, "Error, This application needs 
>> at "
>>                                 "least %d logical cores to run:\n"
>>                                 "1 lcore for stats (can be core 0)\n"
>>                                 "1 lcore for packet RX\n"
>>                                 "1 lcore for distribution\n"
>>                                 "1 lcore for packet TX\n"
>>                                 "and at least 1 lcore for worker 
>> threads\n",
>>                                 min_cores);
>>
> Is it okay, if I change the error string such that:
> "1 or 2 lcore for packet RX and distribution"
>

Sure, that's fine.



--snip--


Thanks,

Dave.




  reply	other threads:[~2022-06-28  8:12 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-21 20:15 Abdullah Ömer Yamaç
2022-06-27 15:51 ` Hunt, David
2022-06-27 16:28   ` Omer Yamac
2022-06-28  8:12     ` Hunt, David [this message]
2022-06-28 11:06   ` Omer Yamac
2022-06-28 11:25     ` Hunt, David
2022-06-28 12:06       ` Omer Yamac
2022-06-28 12:34         ` Hunt, David
2022-06-21 21:13 Abdullah Ömer Yamaç

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c5d3c153-3b11-7cc6-4e86-8f0be5559c5b@intel.com \
    --to=david.hunt@intel.com \
    --cc=dev@dpdk.org \
    --cc=omer.yamac@ceng.metu.edu.tr \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git