From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 75F2FA0547; Tue, 28 Jun 2022 10:12:12 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2146C40691; Tue, 28 Jun 2022 10:12:12 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mails.dpdk.org (Postfix) with ESMTP id 86456400D7; Tue, 28 Jun 2022 10:12:10 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1656403930; x=1687939930; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=OvvEUXIW4QiTudq5ketmxiDuHkJcdi2keKribbeCgw0=; b=XyIRkDc15eHBR4iV+Ic37SYbyCwsN1wNi4ksb/+IyNqHr8nRnNGnL+Pp /7k5DTgOvrTkzm3/P8t4HR4QhrXbKXbP8/lj4m3v1aMGfMwCw63gG0XuF aKu67e2VxKUqcX/ZGdCA9BuVZBwnEkabnoNFobHG6CenFq/IB1M0OKsWh hBALW4khbXJOzp9ASJ4Wb8fTFhrdiYjNa2QVaYvIUxJbMapRGAONMwMxF ywgcCGohF7etzQdRkr28yHJ5lbe/cN3VJKG1f2uqWxxSYt0ftT0Df2LKw LOpNJ3QAADZltj3tX90xsaewRSGZ9+Yicsu9KGsfRN5v6dgyh9DAInkmw g==; X-IronPort-AV: E=McAfee;i="6400,9594,10391"; a="280431905" X-IronPort-AV: E=Sophos;i="5.92,227,1650956400"; d="scan'208";a="280431905" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Jun 2022 01:12:09 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.92,227,1650956400"; d="scan'208";a="732657081" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by fmsmga001.fm.intel.com with ESMTP; 28 Jun 2022 01:12:09 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Tue, 28 Jun 2022 01:12:09 -0700 Received: from orsmsx605.amr.corp.intel.com (10.22.229.18) by ORSMSX612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Tue, 28 Jun 2022 01:12:08 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Tue, 28 Jun 2022 01:12:08 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.168) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Tue, 28 Jun 2022 01:12:08 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZfYihD6PhkrME8HjSs5PwoZ2x21weHTU0cb5RMARE6oaJWMvFCBS9+F0p0gPDCFgAsNMXfi0KcWnStlzdk82wnY/iP2foTL0AFgDTfaaQ7d9n5E8UZgZT0deeMXL8RND3IfPOAvmgE3VdTHrHfEAtmtIpa7Gv5GLiL6smXlaHnSb+0DiOve4NijBC9X4CpPJlpMSa8j44CkRAL4HY45Ee13jvN7HVETKt2x/cXgXSWjFijtJilMbiiZh7gl3Duv8Y/r/IJaFj6lY+yr2nGeZTrHAQ8XSFK9v34geWDS9l/LeyUW/xDg8FRpYdBNuwLamsNsPc+a/xYjJlKSL+YH1Gg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UY5IU8ZZ9C5kNV83FKe9nTx4O5X8XFyMwFRPqBvZzXM=; b=QTlEg5wDLUtLpFBjV58HreZLoJzZl5kLuvlUYsQOD8nuYHKUHcI6cN5gvxshi0EhYAkqb3BFsqbwSCnfM233xL9UXG6Ts67YtHrVr3mCYY5qTJPY1jFt1TqMjdb67Kklx90tcKbTnaPz4vuy0vyDe4+447XsAnBS3ytmWzLnj48nZAYFJrYVUdXi+b+v/vvgMJOzQgfsW59o4T0ve/bxd0eSh20elgHBvpzx5boUUbcWa9mA8m0mSmxpX0r9HVCAdRHMyuDQYd/zTP5PYBeEALJPo+OUhAtmZD4ftE9ETMB/U80XWEn7cTU2vRWwk3tMeM5De3KxNg6ovBUfPSyBcw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from BYAPR11MB3799.namprd11.prod.outlook.com (2603:10b6:a03:fb::19) by MWHPR11MB1631.namprd11.prod.outlook.com (2603:10b6:301:10::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5373.17; Tue, 28 Jun 2022 08:12:06 +0000 Received: from BYAPR11MB3799.namprd11.prod.outlook.com ([fe80::e424:dc7d:97d3:66a9]) by BYAPR11MB3799.namprd11.prod.outlook.com ([fe80::e424:dc7d:97d3:66a9%3]) with mapi id 15.20.5373.015; Tue, 28 Jun 2022 08:12:06 +0000 Message-ID: Date: Tue, 28 Jun 2022 09:12:01 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH] examples/distributor: update dynamic configuration Content-Language: en-US To: Omer Yamac CC: , References: <20220621201517.76991-1-omer.yamac@ceng.metu.edu.tr> <253c41b6beadccd1c65bd4bd4eb4442f@ceng.metu.edu.tr> From: "Hunt, David" In-Reply-To: <253c41b6beadccd1c65bd4bd4eb4442f@ceng.metu.edu.tr> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P265CA0104.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2c3::8) To BYAPR11MB3799.namprd11.prod.outlook.com (2603:10b6:a03:fb::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 033acb04-edf8-4e79-df27-08da58dde424 X-MS-TrafficTypeDiagnostic: MWHPR11MB1631:EE_ X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: RXxkBUIGZA32m3NXEGMefiBQV7Y9JAAF9aZu09J9o6ksTx/XEN7tJDQTD6tWe/Yri6nZK0gmXLhUMLnJjgAGlv5We4OkflPbTkIoMbCWFeC4FO21bvRdPeD4R9l5qrsu71dl4RgwQE2csVZmEh7SaQTCFvCEM4ESvJKE5iqpooX+W7sRPt4Uxi/smBebrXbgdjjNkxnjlxw2Sj+qP/j9CJYwn4TVWQw7079QG+8jJlcQMt0SXM/i2CnSMzVwvwzD5DYu7sDnAFo1Nkvg0i+XLupdnss6z3ryYXc6NmNu+vgmyRnqSfBvzIeKpFjdLIayMuGC5l7CZEbLpxLubQuCuqQkPeBRyFPIgE4QtX29QOct4cWfK1dcn5pp4wSoXo8J8GzoFVTd+6bZLEEYtsWqz2esO3LMQTxIP2QZr+d+vXIvGNOKb6UuBcet7k6T3DEYa7AYNEw5CBmOouhhxkkUi4JcYBD2cnnDj6RVZ8hpdvqbGmjN5XT8r3qYz11NgVjRlwAokcGfHVJgt423ugwzy/OP/TxyIk5KeT9Azqbrl8b2OEwm4d4cOdoJ1gmV+SYHst/rdT0e30p2Rml54A8SeL1zxZ7rcp4OJLugkb7ufAlbLZhduS+yuHqBR9zGJxGFIarUurrJEYZTOgM6FTn7Ja7feiDHpTQeVf4sojigJ3Mm2z0u3854rJRQk6QvNGNNf7GaINCymLfl1WEIy3MuYNlPUWVjL5tEHK3ndAXo5Jg+GqWYRI3RfIQKI5jLBbP/RbevylKXKExW4ZwgVfQXPEmHlVfiPPI0hyXKXmcMeaMX91kA8RRDI9z8JoqWbF15Q0lbgI3T4m2dD03MGR9BpQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR11MB3799.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(346002)(136003)(396003)(366004)(376002)(39860400002)(2616005)(41300700001)(478600001)(66556008)(66946007)(66476007)(8676002)(31696002)(4326008)(26005)(8936002)(2906002)(86362001)(6916009)(5660300002)(6506007)(6666004)(53546011)(66574015)(6512007)(6486002)(316002)(82960400001)(38100700002)(31686004)(83380400001)(186003)(36756003)(45980500001)(43740500002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?R1BqZG9pcnJXeXpPdm9GMVFOL1NjNENIQjQ4cngxU0ZvTWgvNjlkNEFmVE9E?= =?utf-8?B?RndiYkdyemYxeXlDY25qQjRucmR5dE53WkFRaWx0ckhMQWtzTW1pcExXbEZ2?= =?utf-8?B?cW5MVWNWYkFTNi9vRjIycEVuWnJFdUowMEZxM0tHTXhld1JnaVNJdzdFRDhi?= =?utf-8?B?REJDSytGRjJiOXg3QzhZZituQm1TMnlwbXFkS3NnYUNTc2xHY3lvNUxIU1dX?= =?utf-8?B?czVzNDhXUTBlOXFlMzhEbWU5amQybmlqNnJnR3VuZnp2cS84NG9Wd3UrMm5L?= =?utf-8?B?SFl1dEFlL21pTHdlMGxoZmErcGxGMzE3aThPUzhlZ09ZeUk2cU9maHJoTllF?= =?utf-8?B?a3NsNnJGUHp0YW1rWjVScUZBbEZaRmVnZFlCV3JGK3p6eWYwTVg5elBhQXNB?= =?utf-8?B?SVZXbTNCU1hyWHRqUlBCZURINTQ0RlNya25KSk5yWFFkZmxSUG5BN2g0T1No?= =?utf-8?B?ejlHa2FyMmgwS1pRRnFLUEo0ZE1lZ1VPQU81RStORVNQd1F4WGtxZkI5U29C?= =?utf-8?B?Q2dYN2NMUkIxdDRYQVRsUG5ac2EwWUlLZ0pMbXp6WnAvY2g4a3hCVVU5MUds?= =?utf-8?B?b1FKMldSYXFIYlVnRkRnRUhYY2FPZDdJdzUxQnRnc1pXV2k0VjBpYXVpSEk5?= =?utf-8?B?WnVTaVJ5WWs0TVQwWDNTbFNnZG5yTlQ1aFRsazlUWmxteVFFZERLQWV0aU5a?= =?utf-8?B?bmVJbERodUZSdDVXdG9FanYwVG1DUkxqTkZCYncrUGgxRitlQlVlZG45QnJq?= =?utf-8?B?dk8rT0Q4UUlaN2szVlBuYXVLVnFRQTVINGxYN1YveTNyOU5XaXFGNnUxNkIr?= =?utf-8?B?MkNtOTFDazVxcEFZd0ZUREwxMTBJUi8wemFDWlZLQjY0Q1F1TUxLNUF0Vkx6?= =?utf-8?B?UUV1TkZ0Zi9zTHB6bGlmYjVpWXBPR3paTktmWDAwc2NyL3BWVVdYSXA0Vjc1?= =?utf-8?B?ZGxLR2grNTlFSUUwK3ovK1RmcjM2UmhMam5ab1RtUVloYm16elJBT0RNWEov?= =?utf-8?B?ODFPQVpHaVhOWWFaQzg1L3pBWXBUdXJ1a29zYVJKNGpOM25SbDFnRkI0ZWJW?= =?utf-8?B?bVEvdUpsOUlsbEQ2L1VLaHpaWkY3b256aVhoMlVsZHYwSlZYeWZJT1hpNEM5?= =?utf-8?B?eEpGQWtvWG5EanRLdDNkcFAweTJrUnJQQy9XMkpiUzNzQ09jVVpSMHBXTnlC?= =?utf-8?B?L3M3NFcwNVFrYTQxODNmdnIwUmZReHBsQzBKR1k3Zi96M0x1MHdJaUFYWW8r?= =?utf-8?B?ZmVZVEZ5VWh5c2FrSGp3NTllOVJyV0s2ekNPTHF5c042TnJDRGZOOXhzTmlT?= =?utf-8?B?WCs3QVM1Y2Nua1dlWjY3QlNqOEpVOTUxZmI1T1dyc3RlREVOaEdYOEsxaVFx?= =?utf-8?B?ZmJ3alFlb3lTQ0ZtdEZPMEpRbXF4dzlYM3FwdVk5Skl1YzJKck5PY0tqME5S?= =?utf-8?B?aTlhSGJ1ajBkYm9jVDg2UUNUR0tRK1FNNGo0cGpEa092bGdOdHVmSnJwdjZj?= =?utf-8?B?ZE9pOGNNajhHK1pqYWJUZ0JkNER1anJ2Yk1WTlRpK3lnQXoydnZ5RDRBOUxs?= =?utf-8?B?d2E2NWprNUI0cWludkE0cElwTEdQeDhVMk1FSGVvTjBUYTZmUkExK2tUQTJU?= =?utf-8?B?dVkvTFc1OTVMa1lPYjYrNm82M0dtRWpadDViZytqVzN4YnFoaElITUhwK0dI?= =?utf-8?B?dGhNenJlU05jZWlyYStkd0VwVVpuNkFpL3dwNEg3UTJCdDA3MXlTWHF1VUJo?= =?utf-8?B?MnowVUZCdzVFRmlwOUJkdGxnbUNlM2VycThCcDluSFBrNldyc0N3RHh1dnNi?= =?utf-8?B?ZGNZcmVEOUxjV0lBVEt2eEI1TFNkenZEdElGV3RzaFVqM2dJdmZ0ZFNSVTVI?= =?utf-8?B?aGt5Rm5NOXAybnh2dXlFS1ROaUVxT3R5RXA0cFNzOEkxRXhqdWUzR281bkMx?= =?utf-8?B?cU5aby9wdW43TVI5M2NJaXAybGpnOGdMa3plQTJCNEJsQTRqZk1JdHNnSXFk?= =?utf-8?B?TldQbnpTVzlqa1BSUVA0T29sWmxYY1VNQmtnbjU0RXlmMkhHL2w4NXVsT1FU?= =?utf-8?B?TXA4em0xUnY5cEZlVDBYVEZ0VmxtUWQzWDloMktLY1ZKNEpxRVBSeE41UnVT?= =?utf-8?B?OU53aEx6M0NhZ2pmRS81Zm1GK1RwSDV5Z1BNNXhpYWEyc2J1M2xiK2JBQTFP?= =?utf-8?B?SlE9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: 033acb04-edf8-4e79-df27-08da58dde424 X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3799.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Jun 2022 08:12:06.7640 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: pYie1huK6iNpilHqZmytwtjGs22LidG2yhCfvUDMt2DujI6zVSbvIS3N0oon2ZQy+Fq2xpw8b0xmw9qgOECNxw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1631 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Ömer, On 27/06/2022 17:28, Omer Yamac wrote: > Hi David, > > Thank you for your review. I have two questions. The first one is > about new release. As I remember new DPDK realize will be published in > a short time and my previous fix in that release. Therefore, Should I > wait for that release to submit patch? > Yes, You can wait, or you can submit to the mailing list now and mark the patch as "Deferred" in patchwork. Once 22.07 is released it will get marked as "New", and under consideration for 22.11. > The other question is below, > > On 27.06.2022 18:51, Hunt, David wrote: >> Hi Ömer, >> >> I've a few comments: >> >> On 21/06/2022 21:15, Abdullah Ömer Yamaç wrote: >>> In this patch, >>>     * It is possible to switch the running mode of the distributor >>> using the command line argument. >>>     * With "-c" parameter, you can run RX and Distributor >>> on the same core. >>>     * Without "-c" parameter, you can run RX and Distributor >>> on the different core. >>>     * Syntax error of the single RX and distributor core is fixed. >>>     * When "-c" parameter is active, the wasted distributor core is >>> also deactivated in the main function. >>> >>> Fixes: 4a7f40c0ff9a ("examples/distributor: add dedicated core") >>> Cc: stable@dpdk.org >>> >>> Signed-off-by: Abdullah Ömer Yamaç >>> >>> --- --snip-- >>>                   "1 lcore for stats (can be core 0)\n" >>> @@ -733,6 +808,15 @@ main(int argc, char *argv[]) >>>                   "1 lcore for packet TX\n" >>>                   "and at least 1 lcore for worker threads\n"); >>>   +    if (rte_lcore_count() < 4 && enable_lcore_rx_distributor) >>> +        rte_exit(EXIT_FAILURE, "Error, This application needs at " >>> +                "least 4 logical cores to run:\n" >>> +                "1 lcore for stats (can be core 0)\n" >>> +                "1 lcore for packet RX and distribution\n" >>> +                "1 lcore for packet TX\n" >>> +                "and at least 1 lcore for worker threads\n"); >>> + >> >> >> the two checks above could be replaced with something like: >> >> min_cores = 4 + enable_lcore_rx_distributor; >> if (rte_lcore_count() < min_cores) >>                 rte_exit(EXIT_FAILURE, "Error, This application needs >> at " >>                                 "least %d logical cores to run:\n" >>                                 "1 lcore for stats (can be core 0)\n" >>                                 "1 lcore for packet RX\n" >>                                 "1 lcore for distribution\n" >>                                 "1 lcore for packet TX\n" >>                                 "and at least 1 lcore for worker >> threads\n", >>                                 min_cores); >> > Is it okay, if I change the error string such that: > "1 or 2 lcore for packet RX and distribution" > Sure, that's fine. --snip-- Thanks, Dave.