From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 39337423FB; Tue, 17 Jan 2023 11:50:32 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C55EE42D47; Tue, 17 Jan 2023 11:50:28 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 25ABF42D3F for ; Tue, 17 Jan 2023 11:50:27 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1673952626; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Z0xyUCWaYg9hhliH76XGbpvq3TrM9M9H+86QcfuDUpY=; b=i7Jv12KE2UiFu26npvW/gsNXUfVBbrwnluHhfKClpR8abHiz9gwagN1PuiCN+map2xnqR6 NdGRp3D8Earte0gVgWHwM+fWVrOAGMiptuEGtDvSlby3IqSgxBy1UAAitkoVTcYkkZjZAa LfikRvjOGlGB0QjhC+5QFE5x3EeIYtU= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-60-Uz28yIzcOqCCPX61vsn1bA-1; Tue, 17 Jan 2023 05:50:25 -0500 X-MC-Unique: Uz28yIzcOqCCPX61vsn1bA-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id B837C85A588; Tue, 17 Jan 2023 10:50:24 +0000 (UTC) Received: from [10.39.208.23] (unknown [10.39.208.23]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 72F8DC15BA0; Tue, 17 Jan 2023 10:50:23 +0000 (UTC) Message-ID: Date: Tue, 17 Jan 2023 11:50:22 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH v3 7/7] baseband/acc: acc100 ignore missing mempools To: Hernan Vargas , dev@dpdk.org, gakhil@marvell.com, trix@redhat.com Cc: nicolas.chautru@intel.com, qi.z.zhang@intel.com References: <20230112193609.273578-1-hernan.vargas@intel.com> <20230112193609.273578-8-hernan.vargas@intel.com> From: Maxime Coquelin In-Reply-To: <20230112193609.273578-8-hernan.vargas@intel.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.8 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 1/12/23 20:36, Hernan Vargas wrote: > Mempool not strictly required to be present in op for processing. > Previous criteria too strict. No functional impact. > > Signed-off-by: Hernan Vargas > --- > drivers/baseband/acc/rte_acc100_pmd.c | 9 --------- > 1 file changed, 9 deletions(-) > > diff --git a/drivers/baseband/acc/rte_acc100_pmd.c b/drivers/baseband/acc/rte_acc100_pmd.c > index d3aaeb8f2c..0992cb5d1e 100644 > --- a/drivers/baseband/acc/rte_acc100_pmd.c > +++ b/drivers/baseband/acc/rte_acc100_pmd.c > @@ -8,7 +8,6 @@ > #include > #include > #include > -#include > #include > #include > #include > @@ -1830,10 +1829,6 @@ validate_enc_op(struct rte_bbdev_enc_op *op, struct acc_queue *q) > if (!validate_op_required(q)) > return 0; > > - if (op->mempool == NULL) { > - rte_bbdev_log(ERR, "Invalid mempool pointer"); > - return -1; > - } > if (turbo_enc->input.data == NULL) { > rte_bbdev_log(ERR, "Invalid input pointer"); > return -1; > @@ -2677,10 +2672,6 @@ validate_dec_op(struct rte_bbdev_dec_op *op, struct acc_queue *q) > if (!validate_op_required(q)) > return 0; > > - if (op->mempool == NULL) { > - rte_bbdev_log(ERR, "Invalid mempool pointer"); > - return -1; > - } > if (turbo_dec->input.data == NULL) { > rte_bbdev_log(ERR, "Invalid input pointer"); > return -1; Reviewed-by: Maxime Coquelin Thanks, Maxime