From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk0-f176.google.com (mail-qk0-f176.google.com [209.85.220.176]) by dpdk.org (Postfix) with ESMTP id 4E37834F2 for ; Fri, 30 Mar 2018 20:10:55 +0200 (CEST) Received: by mail-qk0-f176.google.com with SMTP id v2so9774864qkh.10 for ; Fri, 30 Mar 2018 11:10:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-transfer-encoding:content-language; bh=iNwFE4AKQp4UsP1D1zABQRYITwfysJ1qzX2kUiS3WCQ=; b=TCKHrTd7858DLOgbb/28ywVRb+kDJB8xcZtAb8nfBcnQDsatQqieub1PlqxsaRCVwJ fz/gvCkU94RYkGFeo8lf5VZvloStbe58szOup+2JNZxkqccbKlMTPMmiwwXzgyOLAMcT fgyJK1XEixsqv1jRnzNpS7ePXKheyzLoxCO30= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=iNwFE4AKQp4UsP1D1zABQRYITwfysJ1qzX2kUiS3WCQ=; b=Yz9D+FfoHhzoQTx5PrwJMnhakOzHzvKMJTAoaip78RsbS1v2HAllCfjL59ZEmOWzC0 cCaqlor9SEH/5KQ6tqh3WExk/GgMQSH9cYGlYgM6IVjeSHwJWINVKc/gUdXIRwfZMQRG KZaWBMuG4FRNR2pwwPn5xfjDi4rwmL4J4eZt76+LcX2hQXH7CUkxJK86hXkLnLQReoSU 0lwTSFdnWy2p3FMr/WYH+ueEavP/p/+ceBcBT0QwJJsm7/qY9iq7LzUYvotb5g+0ll+k O/96x1atuC0hQxj/Z7WahA3fQI7VHdKPmjvwMzJauvG27HXQWMgd7GVw4pVUyoa8WqMh y95g== X-Gm-Message-State: ALQs6tBvewGfUjINRcEo8WuQAGMwCre07iEo8eKZHD5nm0pW7XKhsmmW DhDwCnOplGI8p+zX7yMJQ5xh/ure X-Google-Smtp-Source: AIpwx48KxfopJwZP+/meNTYDBP0eUr6VWQdNnTXl0uSB9BOez4H4aSjT/+5VNt1jTSQCfwi+MlMgrg== X-Received: by 10.233.232.215 with SMTP id a206mr23013qkg.238.1522433453090; Fri, 30 Mar 2018 11:10:53 -0700 (PDT) Received: from [10.136.13.65] ([192.19.224.250]) by smtp.gmail.com with ESMTPSA id y66sm7308647qky.61.2018.03.30.11.10.51 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 30 Mar 2018 11:10:52 -0700 (PDT) To: Ferruh Yigit , Ajit Khaparde , dev@dpdk.org References: <20180329164021.51728-1-ajit.khaparde@broadcom.com> <7c992ec1-3cef-7a08-2a45-1142798b6af4@intel.com> From: Scott Branden Message-ID: Date: Fri, 30 Mar 2018 11:10:50 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <7c992ec1-3cef-7a08-2a45-1142798b6af4@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Subject: Re: [dpdk-dev] [PATCH v2] net/bnxt: convert to SPDX license tag X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 Mar 2018 18:10:55 -0000 Hi Ferruh, On 18-03-30 03:35 AM, Ferruh Yigit wrote: > On 3/29/2018 5:40 PM, Ajit Khaparde wrote: >> From: Scott Branden >> >> Update the license header on bnxt files to be the standard >> BSD-3-Clause license used for the rest of DPDK, >> bring the files in compliance with the DPDK licensing policy. >> >> Signed-off-by: Scott Branden >> Signed-off-by: Ajit Khaparde >> Cc:hemant.agrawal@nxp.com >> ---- >> v1->v2: modify first line of SPDX identifer as per review comment. >> --- >> doc/guides/nics/bnxt.rst | 30 ++---------------------------- >> drivers/net/bnxt/bnxt.h | 32 ++------------------------------ >> drivers/net/bnxt/bnxt_cpr.c | 32 ++------------------------------ >> drivers/net/bnxt/bnxt_cpr.h | 32 ++------------------------------ >> drivers/net/bnxt/bnxt_ethdev.c | 32 ++------------------------------ >> drivers/net/bnxt/bnxt_filter.c | 32 ++------------------------------ >> drivers/net/bnxt/bnxt_filter.h | 32 ++------------------------------ >> drivers/net/bnxt/bnxt_hwrm.c | 32 ++------------------------------ >> drivers/net/bnxt/bnxt_hwrm.h | 32 ++------------------------------ >> drivers/net/bnxt/bnxt_irq.c | 32 ++------------------------------ >> drivers/net/bnxt/bnxt_irq.h | 32 ++------------------------------ >> drivers/net/bnxt/bnxt_nvm_defs.h | 11 +++-------- >> drivers/net/bnxt/bnxt_ring.c | 32 ++------------------------------ >> drivers/net/bnxt/bnxt_ring.h | 32 ++------------------------------ >> drivers/net/bnxt/bnxt_rxq.c | 32 ++------------------------------ >> drivers/net/bnxt/bnxt_rxq.h | 32 ++------------------------------ >> drivers/net/bnxt/bnxt_rxr.c | 32 ++------------------------------ >> drivers/net/bnxt/bnxt_rxr.h | 32 ++------------------------------ >> drivers/net/bnxt/bnxt_stats.c | 32 ++------------------------------ >> drivers/net/bnxt/bnxt_stats.h | 32 ++------------------------------ >> drivers/net/bnxt/bnxt_txq.c | 32 ++------------------------------ >> drivers/net/bnxt/bnxt_txq.h | 32 ++------------------------------ >> drivers/net/bnxt/bnxt_txr.c | 32 ++------------------------------ >> drivers/net/bnxt/bnxt_txr.h | 32 ++------------------------------ >> drivers/net/bnxt/bnxt_vnic.c | 32 ++------------------------------ >> drivers/net/bnxt/bnxt_vnic.h | 32 ++------------------------------ >> drivers/net/bnxt/hsi_struct_def_dpdk.h | 32 ++------------------------------ >> drivers/net/bnxt/rte_pmd_bnxt.c | 32 ++------------------------------ >> drivers/net/bnxt/rte_pmd_bnxt.h | 32 ++------------------------------ >> 29 files changed, 59 insertions(+), 846 deletions(-) > Can you please update Makefile too, but I can see it has multiple coypright, it > can be better to send it as a separate patch to not block this one. Yes, Makefile change should be in another patch. I don't know how to change the header on that one though. Intel and 6WIND shouldn't really have any copyright on the Makefile, though? It looks like somebody just cut and paste the license header from another Makefile. Please suggest what should be done with this file. > > <...> > >> @@ -1,34 +1,6 @@ >> -/*- >> - * BSD LICENSE >> - * >> - * Copyright(c) Broadcom Limited. >> +/* SPDX-License-Identifier: BSD-3-Clause >> + * Copyright(c) 2014-2018 Broadcom >> * All rights reserved. > It might be nit-picking but we don't have leading spaces [1] in format, are they > intentional? > If not it is easy to fix when introduced otherwise will stay as it is forever J Yes, it was intentional. > > [1] > /* SPDX-License-Identifier: BSD-3-Clause > * Copyright(c) 2014-2018 Broadcom > * All rights reserved. > */ > > <...> Thanks,  Scott