From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5B9ED43877; Tue, 9 Jan 2024 19:07:56 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4B6B0402E0; Tue, 9 Jan 2024 19:07:56 +0100 (CET) Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2067.outbound.protection.outlook.com [40.107.244.67]) by mails.dpdk.org (Postfix) with ESMTP id 52C4F4021F for ; Tue, 9 Jan 2024 19:07:55 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=f6kRAhAQ05Jg6hFfcLOucIam+Rom8ykA8Cko9I064nXrF/jLwxkN2NBMX70ZfWCdPNxr71FYqki5G5xRXJ8P2oIR+qE7aNNE58NA5//vets6kFh1KkgINvDoaOc4o0QOfz1OIvvw5O2vJCGwYouj2GzlTyEuV1eNDzFKTiSHLU2k8gB7zIB+r6c6Ardb1QKyV06l2oONtKsYjQb8aQkEeTyQ+5UuHzyrFpQWPYN3Ov4wCT95m9SFe44vOgbf+rs5K5vrMprUeQv0y+aI40/NA3YyGXSby+SzfyFuX22MtYrI4xjsMm/LwAcLUAc44UXV6CeIaCK4qALtyglB4SRfWQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ODkOv/5NN1NSpkR8MGf8BRJmXJOdjJc7a7e2c/9Hyb0=; b=EKR1yt5JLDq/Pxo3EbxXeGKWlHN6j2CA0CjBlCsdRncybqIZg4f6ja80zAP8C5RuL60bmFCgrX3S+L0oAFvSm/dSkc9MRz3pvjQ+Wg/YD4Oz43HarVcCJ7BozxwcCuqaiaZyrcYnTqcy5YXCod99QPMdvZnHqPI83G2Va6Q5fh9SRTdxpI5FM90IckEwagGmwMDIcIJh9fPEfbj0UFcL2FlASJ8T2xGf78r6FzYk9kRt6f6F8yEEesNkqINFGL/lK5ZV7eKC1jk25ANrbGNaDl5qdhJI58yLtaJQMTKhJfEHd3+3gP93oiwiRPPTC4+N4MdBQEwQUToKTRukV5Nuog== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ODkOv/5NN1NSpkR8MGf8BRJmXJOdjJc7a7e2c/9Hyb0=; b=izbFlNMBrfez8VTrQFPBB+Af4RAJPTPGeP7lJyUGDlfcj6MatL6hpcUO2VgS49glIoSiJgHMw4bmPR7DB5xVbxUvpS+TBE9Ma1ctZV68b5Y1/sJ3aBLzDDkErRtepiRLi/9T0hpE4btf0fjv7BWK7Y0zzlODSS5PjXsWRMVVANg= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by DM4PR12MB5376.namprd12.prod.outlook.com (2603:10b6:5:39f::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7159.23; Tue, 9 Jan 2024 18:07:52 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::815a:45e6:cf5e:479f]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::815a:45e6:cf5e:479f%4]) with mapi id 15.20.7159.020; Tue, 9 Jan 2024 18:07:52 +0000 Message-ID: Date: Tue, 9 Jan 2024 18:07:50 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1] net/axgbe: read and save the port property register Content-Language: en-US To: "Ande, Venkat Kumar" , "dev@dpdk.org" Cc: "Sebastian, Selwin" References: <20240105113250.11492-1-venkatkumar.ande@amd.com> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0085.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1f::22) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|DM4PR12MB5376:EE_ X-MS-Office365-Filtering-Correlation-Id: 9fad2867-0451-4b36-ca8b-08dc113de5ab X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: zwN8jyQGxDw3qD2gRRU0rhPtz6BUIwPJgH6it3DOKVyUzMawxex4SSSZGbWhuGNB0uUGkk7bbHU7WV+0nG1Exj358TdJuoHpLytcoaykvd4tQzFdXADyA0uR66+SI0I0BZTiHGi4oCvVHmRk7AITZw7sQPxHXHauagh5YkJPSHVyAoRwQ7wzJHkGaqQ8Z8/2V9IIavsXp5a8n/VynlUXULeknZ9iK2UT2qkulooQoIPc3lp55EZKRlKNfau98hT4rEmlX80AI716V7QpUcOffcD5dJb8lffT1t3vNEGxgvB9TGHOVK5fZ+D0ufRkjkq3+/SfuorFsmjzxwHX6ofewnrNCaAZgZ0l3wjCMHS0awrJpr5n8lve92NnMYoLV4lsab9+bnr4kakz/lNWXN09c9cgLRMmN4RYl06CptDRbq8DIAwv78eSAORTyiwwlDLTJvGnnFh4OXpNW0wHcONhmN6Zj/N8p9pFz3A9Sixq3lfR3cCr57hNqWl84cM/m+YSVEROcx6wbnJ0N9FRybvBlEmh14RIQrXrgICUHIE0VMH0HGfywAjEFZifWBNnQ9ELmLncAyld4I+9pxVHUqPenqr3mbMtk1+x1py1LJFEX+/FqQcY0KzmmoBZijXUfcj9T6cEDSrGEjvIwbGOsmMV9Q== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(376002)(366004)(39860400002)(136003)(346002)(396003)(230922051799003)(1800799012)(186009)(64100799003)(451199024)(31686004)(110136005)(41300700001)(36756003)(86362001)(31696002)(38100700002)(2906002)(83380400001)(26005)(2616005)(6512007)(6506007)(478600001)(66556008)(316002)(66946007)(6486002)(53546011)(66476007)(8936002)(5660300002)(4326008)(8676002)(44832011)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MXNwYmRjU0hENm1NY3RUd3ljTXBzYnV2K3dHQUdyY0hGVTY3WWQ0UzZmQWEw?= =?utf-8?B?ZDUvMjVuZkhnbUorNUdleGRxY04zQlg4Sk9GWVZNbmg5cWFkSEpOUncxN0Zv?= =?utf-8?B?Y0Q4cWFlTGVOSHpHY2dza3RObUc1SWVGNE40VWd3OGNGUy9OMXpqT0ZhaGdU?= =?utf-8?B?cXM5WndyMHROTUgvejE0MGRTYVBuSVA5bkpxYngwbVJzbWJIeWl4em9uZm5S?= =?utf-8?B?WFd4ajEyd2RaVWNGYXZvSWlKaUQra0pIVzJheWJnc2Npa1RhMFVKNGNUSHhC?= =?utf-8?B?VFN0dStJcE9rRkF0K1NQRDNMVFduVzJHcW04QkFDVlcvaFpITjgvdHVwZlJW?= =?utf-8?B?WUR0K25QM3hRQnZzVTdqZ0NrdXpsL1BHWitTLy9TYmVuakRCSmtVTm5Sd0sz?= =?utf-8?B?bmlwSmx2N09VOHVndkhOMTZrSjBGM0pYcVhBY0dPM1lxc0gvWWg2VEJhanpu?= =?utf-8?B?d01IR2ZsekFuTlhJRGlHQ0pWT2kvb0cxVWx0ODAwNXBHNzZsR1BqZXFseW9I?= =?utf-8?B?Z3I3cXVkci9tNjJPV0YzcXlQRWl0TmVrQWQ0TVRlMHlCM2p5cjkrckxXT0tq?= =?utf-8?B?MVRRdkVERDZPaXZMQjV3N1JOQVBoYWF3Nkd3NkJMdDhsVlZXcTVxTEVjek5v?= =?utf-8?B?TGluNkdra1IwRkpWT1VJMHhiUzNZVjVMTjUwcGJuYWs2U3lETEtFdFg5Qm9H?= =?utf-8?B?ZDFHTFpTdEhTN1BqankwWXVoakVjdmxMMTcxQlBxYmxpUENac1ZwbFl0NThN?= =?utf-8?B?Tkc2VklqVkVzdDZSbnpmOFNyWTBqaWUxUk80dmZ1MUpYbEV5QWVEdkZWdjVm?= =?utf-8?B?ZFVQUDgvdGhvOTBNUlVKNDAycmp1Z2I2WkdkdTU2OHRIYUNodUNUazRlR2lh?= =?utf-8?B?NEMxRzVCWTloTGZldnljRlFDN3BSajZxVzI4ZEhKNkVnUmh2VHNLVDhYTUlV?= =?utf-8?B?M2dZU1djU1V3QmZqUGZONWxEaDJ5cEwrUWJ6VzY2Z1lNNHVtaEFpTjFETDlF?= =?utf-8?B?NWQxeUZRVVBRV1VieWovV0thS3pxSVk3R3dDa01URlQyekpTa1UzZThiZkFM?= =?utf-8?B?VVYwcHZDU2NWMmkycVdZaGVveUxQZlhjTWV1MkdsTG0zR1RUSkpIUzhNSnFV?= =?utf-8?B?bWx1MGRkWWVweGdFbjJ0UU0zOGlQR28zSThtQXlVVFJNZm9sQmh4SXcybmhi?= =?utf-8?B?UlkyVVJPNDkrMytwazdPOGlCMHVndzVISjZOa0pWRE5adHpqV0dpTTRmOUZN?= =?utf-8?B?NmNiRUU5QVBPbCtHdkJSeVROcEpZMkI2Tzh5aHFCc0JONjRxeUhQQkJTUUEy?= =?utf-8?B?SFFJL3FUZmY5VktFUEw2QUtNREJVK1hUR2VybGh2azRQRllPMXRqVGZaU1F6?= =?utf-8?B?SzNVOGdmTFdJVXJoM0V1TXJlMHFEUVN0TzQ4R1JPMU9EZFVDY3UyNjNQNG1Q?= =?utf-8?B?d2o3UU5lOHZlNEwrQzdqbUZ1VHBha21vdUIrVTZIbkp4cFJKOUJVemVRZHI2?= =?utf-8?B?Z0xWM0pwSEoxZ3RoSUxhZlNBbnpEOVJQTlRkVjVyL3JibDFhMW01eXRQNHY1?= =?utf-8?B?eXowS0lBMjRkekFaYUZQNlAydFhiZ2tVZCtrVldrZXhSVzlsTkpNcWVYSXdu?= =?utf-8?B?QnlPK3ZnUFZTL005d01zd0FnUk1Fd3ZNbUVjTW52T0s3QVJINWxkQmdxWW9P?= =?utf-8?B?NU5sZDhkTldwa1BFcHRYdWxqT3BZdTdydmRUTkF3ZWFyL2tyKzVOSEl5SDJz?= =?utf-8?B?Qy90QUdSSnhoTWlxSW1Ya3BQN2pHcHIzYWdMdVNLUW5IWVBSVlZKN0h0akRn?= =?utf-8?B?alhudG9PNmdXN0RrTDhtbHVsZll2YTJ5alUvNzFQcXVXNm4rSVZWbENQYkpL?= =?utf-8?B?enp6bzl4UnR5bXdVK3lUZ1VKdTVhcHJFT0RrOFZFby9pZHpvaW94T05PUUdB?= =?utf-8?B?b0JIbng5RjVpUGlwS0NROWhEbXprL1g1elVvZFVtdG9jUjRLOGovZmgzN1Q2?= =?utf-8?B?Q2FFMFBWVG5JSzA5bG1iaC9XOFdrZlZtQy8yWW5zOTJXTVdqUHE0bGZGVXor?= =?utf-8?B?YTJvRElrYVlxK1BKd0pGUElUWTQvUTIvUUVDK3p4bklhbFE4OWhwY2lwSE1C?= =?utf-8?Q?few8=3D?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9fad2867-0451-4b36-ca8b-08dc113de5ab X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Jan 2024 18:07:52.6054 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: oliCanbrmti1S22Hv2TLvsFF0Vu/7CocASWdHb1+rGhAJpMfAXEFpv/8a4mqSfkV X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5376 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 1/9/2024 11:14 AM, Ande, Venkat Kumar wrote: > [AMD Official Use Only - General] > > Hi Ferruh, > > This change will be refactoring for future code readability of AMD AXGBE driver. > Thanks for clarification, I can update commit log with this info while merging. > Regards, > Venkat > > -----Original Message----- > From: Yigit, Ferruh > Sent: Tuesday, January 9, 2024 4:05 PM > To: Ande, Venkat Kumar ; dev@dpdk.org > Cc: Sebastian, Selwin > Subject: Re: [PATCH v1] net/axgbe: read and save the port property register > > On 1/5/2024 11:32 AM, Venkat Kumar Ande wrote: >> From: Venkat Kumar Ande >> >> Read and save the port property registers once during the device probe >> and then use the saved values as they are needed. >> > > Hi Venkat, > > Can you please describe what is the motivation/reason for the change? > > Is it addressing a functional problem or refactoring for coming feature etc...? > >> Signed-off-by: Venkat Kumar Ande >> --- >> drivers/net/axgbe/axgbe_ethdev.c | 21 +++++---- >> drivers/net/axgbe/axgbe_ethdev.h | 7 +++ >> drivers/net/axgbe/axgbe_phy_impl.c | 68 >> ++++++++++++------------------ >> 3 files changed, 48 insertions(+), 48 deletions(-) >> >> diff --git a/drivers/net/axgbe/axgbe_ethdev.c >> b/drivers/net/axgbe/axgbe_ethdev.c >> index f174d46143..3450374535 100644 >> --- a/drivers/net/axgbe/axgbe_ethdev.c >> +++ b/drivers/net/axgbe/axgbe_ethdev.c >> @@ -2342,23 +2342,28 @@ eth_axgbe_dev_init(struct rte_eth_dev *eth_dev) >> pdata->arcache = AXGBE_DMA_OS_ARCACHE; >> pdata->awcache = AXGBE_DMA_OS_AWCACHE; >> >> + /* Read the port property registers */ >> + pdata->pp0 = XP_IOREAD(pdata, XP_PROP_0); >> + pdata->pp1 = XP_IOREAD(pdata, XP_PROP_1); >> + pdata->pp2 = XP_IOREAD(pdata, XP_PROP_2); >> + pdata->pp3 = XP_IOREAD(pdata, XP_PROP_3); >> + pdata->pp4 = XP_IOREAD(pdata, XP_PROP_4); >> + > > <...> >