From: Ray Kinsella <mdr@ashroe.eu>
To: Thomas Monjalon <thomas@monjalon.net>, Akhil Goyal <akhil.goyal@nxp.com>
Cc: Arek Kusztal <arkadiuszx.kusztal@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"fiona.trahe@intel.com" <fiona.trahe@intel.com>,
"bruce.richardson@intel.com" <bruce.richardson@intel.com>
Subject: Re: [dpdk-dev] [PATCH v2] cryptodev: version rte_cryptodev_info_get function
Date: Thu, 16 Apr 2020 15:03:01 +0100 [thread overview]
Message-ID: <c6398716-3b2c-d1e7-fa44-dc4632738538@ashroe.eu> (raw)
In-Reply-To: <3446856.KiezcSG77Q@thomas>
FYI ... not ignoring this, by any means.
Need to check a few points before I respond.
Ray K
On 16/04/2020 09:31, Thomas Monjalon wrote:
> 16/04/2020 10:18, Akhil Goyal:
>> ++Ray and Thomas for review on ABI
>
> Akhil, please work with Ray to understand what needs to be checked
> in general for ABI. We need you to maintain ABI in crypto area.
> First step: run the new ABI checking tool.
>
>
>>> This patch adds versioned function rte_cryptodev_info_get.
>>> Node 20.0.2 function works the same way it was working before.
>>> Node 20.0 function strips capability added in 20.05 release
>>> to prevent some issues with ABI policy. To do that new capability
>>> array is allocated per device and returned to user instead of the
>>> original array passed by PMD.
>>> Because rte_cryptodev_info_get is called by other API functions,
>>> rte_cryptodev_sym_capability_get function was versioned the same way.
>>>
>>> Signed-off-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>
>>> ---
>>>
>>> This patch depends on following patches:
>>>
>>> [1] - "[v3] cryptodev: add chacha20-poly1305 aead algorithm"
>
>
>
prev parent reply other threads:[~2020-04-16 14:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-16 8:12 Arek Kusztal
2020-04-16 8:18 ` Akhil Goyal
2020-04-16 8:31 ` Thomas Monjalon
2020-04-16 14:03 ` Ray Kinsella [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c6398716-3b2c-d1e7-fa44-dc4632738538@ashroe.eu \
--to=mdr@ashroe.eu \
--cc=akhil.goyal@nxp.com \
--cc=arkadiuszx.kusztal@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=fiona.trahe@intel.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).