From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [148.163.129.52]) by dpdk.org (Postfix) with ESMTP id 0D0281B100 for ; Fri, 21 Sep 2018 18:34:12 +0200 (CEST) X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (webmail.solarflare.com [12.187.104.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mx1-us4.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with ESMTPS id D47B0BC00E0; Fri, 21 Sep 2018 16:34:09 +0000 (UTC) Received: from [192.168.38.17] (91.220.146.112) by ocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Fri, 21 Sep 2018 09:34:07 -0700 To: Stephen Hemminger CC: Gaetan Rivet , References: <1535730814-24624-1-git-send-email-arybchenko@solarflare.com> <1537544182-17823-1-git-send-email-arybchenko@solarflare.com> <20180921092108.50830844@xeon-e3> From: Andrew Rybchenko Message-ID: Date: Fri, 21 Sep 2018 19:33:16 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.0 MIME-Version: 1.0 In-Reply-To: <20180921092108.50830844@xeon-e3> Content-Language: ru X-Originating-IP: [91.220.146.112] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ocex03.SolarFlarecom.com (10.20.40.36) X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.5.1010-24108.005 X-TM-AS-Result: No-13.931400-4.000000-10 X-TMASE-MatchedRID: QfHZjzml1E8OwH4pD14DsPHkpkyUphL9iK5qg1cmsr9nnK6mXN72mxRE XZwhDuFx9xmlfFVxiVd7mtb1vVEYNwMWCgdCzp+aydRN/Yyg4pi+1Vx7rDn4r2HaXGR9wawUw/8 trk0/Um/uzcUA0q2gBV+ClygMtX1zDRAXHVIwGYPBtFDYGmaWKpkShYcLpGH9H06W6rwtvNXN2W jbpqXgofa8+G6VxpdYgWg8WzvAdS0FrDF4OCzISWY0Io4Kxb86x22bBvE+WY47LF3pX3rdVLjxa 5EVBV1q4vM1YF6AJbZFi+KwZZttL7ew1twePJJBsjvNV98mpPMqNb5A/L0xx0lszIImPi44my9W ML/AjTNc8+Jbgt1xzmXOcA5BstRh24J+yDar2QqTANhqyuNics9t3JsPbrK4X8L/0rqXDK0= X-TM-AS-User-Approved-Sender: No X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--13.931400-4.000000 X-TMASE-Version: SMEX-12.5.0.1300-8.5.1010-24108.005 X-MDID: 1537547650-uCkHRWCdLBjq Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v3 0/2] net/failsafe: support multicast MAC address set X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Sep 2018 16:34:12 -0000 On 9/21/18 7:21 PM, Stephen Hemminger wrote: > On Fri, 21 Sep 2018 16:36:19 +0100 > Andrew Rybchenko wrote: > >> v3: >> - move apply on sync to fs_eth_dev_conf_apply() to apply to >> a new subdevice only >> - use ethdev API to apply to sub-device on sync >> - remove unnecessary check the same pointer from the method >> implementation in failsafe >> >> v2: >> - fix setting of zero addresses since rte_realloc() returns NULL >> >> Evgeny Im (2): >> net/failsafe: remove not supported multicast MAC filter >> net/failsafe: support multicast address list set >> >> doc/guides/rel_notes/release_18_11.rst | 1 + >> drivers/net/failsafe/failsafe.c | 1 + >> drivers/net/failsafe/failsafe_ether.c | 17 +++++++++ >> drivers/net/failsafe/failsafe_ops.c | 50 +++++++++++++++++++++++++ >> drivers/net/failsafe/failsafe_private.h | 2 + >> 5 files changed, 71 insertions(+) >> > Since TAP has no filtering this doesn't really do much for the slowpath. Yes, I know that TAP does not support it. Is failsafe so tighly bound to TAP to block it?