From: Kevin Laatz <kevin.laatz@intel.com>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] usertools/dpdk-telemetry: add file-prefix cmdline argument
Date: Mon, 15 Feb 2021 18:00:59 +0000 [thread overview]
Message-ID: <c6427595-bee0-105e-c4cf-42229080fca3@intel.com> (raw)
In-Reply-To: <20210215160826.GA255@bricha3-MOBL.ger.corp.intel.com>
On 15/02/2021 16:08, Bruce Richardson wrote:
> On Mon, Feb 15, 2021 at 03:50:51PM +0000, Kevin Laatz wrote:
>> Currently the dpdk-telemetry.py script connects to all running DPDK apps
>> consecutively. With the addition of this file-prefix argument, we can limit
>> the amount of information returned providing improved consumability and
>> precision to the user.
>>
>> Signed-off-by: Kevin Laatz <kevin.laatz@intel.com>
> Couple of comments below. With those fixed, please add my reviewed and
> tested-by tags. This is a handy change when working with multiple DPDK
> processes simultaneously - in my case I tested with OVS and a testpmd
> instance using virtio-user connected to it.
>
> Reviewed-by: Bruce Richardson <bruce.richardson@intel.com>
> Tested-by: Bruce Richardson <bruce.richardson@intel.com>
Thanks for reviewing and testing, Bruce. Will make those changes for v2.
/Kevin
next prev parent reply other threads:[~2021-02-15 18:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-15 15:50 Kevin Laatz
2021-02-15 16:08 ` Bruce Richardson
2021-02-15 18:00 ` Kevin Laatz [this message]
2021-02-16 10:44 ` Burakov, Anatoly
2021-02-16 10:56 ` [dpdk-dev] [PATCH v2] " Kevin Laatz
2021-02-16 11:50 ` [dpdk-dev] [PATCH v3] " Kevin Laatz
2021-03-25 16:49 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c6427595-bee0-105e-c4cf-42229080fca3@intel.com \
--to=kevin.laatz@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).