From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 44E014545B; Fri, 14 Jun 2024 14:19:16 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C6FEB4060B; Fri, 14 Jun 2024 14:19:15 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.17]) by mails.dpdk.org (Postfix) with ESMTP id 545A640264 for ; Fri, 14 Jun 2024 14:19:14 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1718367554; x=1749903554; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=yPTVCoTFaUTb45tYBNKlQITn77+YB5IS9Zj8N+s5Prg=; b=OVbd/mmn25a9yfyX8n78OQjx8uqfiTEmJfehNVewi9OoCPQbexw3uxbS /9KO5hEvSGpm1tgcjTR0NqBwfhkdJQRCTtL7Hzsa2/2VTTjZlrNzS/8T2 AHz/2aqy1SdZcfiI87GPAgu5+Pf5mZAefTcZDnA4reDD1+uSIa34xwvlf vYaZ9hlE/PczfqirVFpEr4cuKpZx30ZmdLT1bdUphHo6+bRqObKqdUpKn llTS5/rp+ReDCDkg0WtyMYRFp8yyc33++vxqoDiNX2fiQunh6E9Ju2yCF NjffJnDU2yMg1d75kM4TlUhGhlQv7z6DPvtye84jDCv2C8GbmL0v8BanY g==; X-CSE-ConnectionGUID: pxo/v693RumFpUEqdJQfAg== X-CSE-MsgGUID: tqRhMB4zTP6Y+o6McFcHUg== X-IronPort-AV: E=McAfee;i="6700,10204,11102"; a="15123640" X-IronPort-AV: E=Sophos;i="6.08,237,1712646000"; d="scan'208";a="15123640" Received: from fmviesa009.fm.intel.com ([10.60.135.149]) by fmvoesa111.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Jun 2024 05:19:13 -0700 X-CSE-ConnectionGUID: +xXk23NfSUex7qWFkyppNg== X-CSE-MsgGUID: mmbOvnwnSI29a8AOBwIE/w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,237,1712646000"; d="scan'208";a="40586929" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmviesa009.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 14 Jun 2024 05:19:11 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Fri, 14 Jun 2024 05:19:10 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Fri, 14 Jun 2024 05:19:10 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Fri, 14 Jun 2024 05:19:10 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.47) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Fri, 14 Jun 2024 05:19:10 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jU3iNn01oMmbrpepXIkEke6iq08EIQaV60ffMk02Gp+iKJXeex+M6PaHn15QJVFwsIg6D8r76QTiLjq027HSMDR1py06gsoYzXAl/Tly7HDm9/AdiCMUOg31nB3/FhyyqNqg2hVF3qJvzJrs3JpVGqLdCWLi7X65NPJ5nGk2YXz1kfsRUiND4ADc4UzRSs+Pv+HdMaEHBwhpVYxSzo4gsLH7Y8pSf4tMBb9DALVzIfWRXyOU21ft/bcNJam/RJQ3hK3GGf7xjEb0r9v2LThvLtnJv8WwwrizYjWaSUTdBhb6UCyaPmo/BSzWMPfuvaUvdT7wwFoJdrT+L1zvlx7CXA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7L6odq7CnaO6nEQVpguqgSpH+Mx7WbtEMioE07jcffU=; b=WEMgFxPI6+kFoBMrEdcDlt/z4ye4b+p+0ZPvpbdvYqZ+22+gGQAAmp/TxsXr2Jho3ZS+NT0X48kFfw2qliXOe68mV27bt5OkrdLiVMuoD73mcDhTFVYRvzhgvPcPhKmFAArunzBm+oW829YYPZnOAiz9mKtV9IoBaEo1OdEccPMYIVUD4794xx00mtCFakY3WN+JVK4yKS/zq0B405UEBidF8CwicaUxN2Fnxwgn4TSh/zMcVpdkQ33JtPAkdBGnxv1qu52kgaCL9Hs5XDm1YLsF7rmA8Y3+RWSoNDu92tt9KVW+JfsVNreCNXG4zlmttYC2NNs0jFoPzgupkfo9sQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DM4PR11MB6502.namprd11.prod.outlook.com (2603:10b6:8:89::7) by SA3PR11MB7536.namprd11.prod.outlook.com (2603:10b6:806:320::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7677.25; Fri, 14 Jun 2024 12:19:07 +0000 Received: from DM4PR11MB6502.namprd11.prod.outlook.com ([fe80::21e4:2d98:c498:2d7a]) by DM4PR11MB6502.namprd11.prod.outlook.com ([fe80::21e4:2d98:c498:2d7a%5]) with mapi id 15.20.7677.024; Fri, 14 Jun 2024 12:19:07 +0000 Message-ID: Date: Fri, 14 Jun 2024 14:19:01 +0200 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 07/22] common/idpf: convert data type to 'le' To: Soumyadeep Hore , CC: References: <20240604080611.2197835-1-soumyadeep.hore@intel.com> <20240612035257.2245824-1-soumyadeep.hore@intel.com> <20240612035257.2245824-8-soumyadeep.hore@intel.com> Content-Language: en-US From: "Burakov, Anatoly" In-Reply-To: <20240612035257.2245824-8-soumyadeep.hore@intel.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DU7P191CA0021.EURP191.PROD.OUTLOOK.COM (2603:10a6:10:54e::21) To DM4PR11MB6502.namprd11.prod.outlook.com (2603:10b6:8:89::7) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM4PR11MB6502:EE_|SA3PR11MB7536:EE_ X-MS-Office365-Filtering-Correlation-Id: 0a121e21-705a-465a-404f-08dc8c6c3078 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230037|366013|376011|1800799021; X-Microsoft-Antispam-Message-Info: =?utf-8?B?UzIzbnRhMHZHT05xRXhGcFJIc09KZFJnTmVieW5KMWNUSW12bWpOSEo0N1Nv?= =?utf-8?B?WG1xOHFralRsSzl5YlR0eTlZa3cyOG1kdUFFWkpvTWx0VUZOUzdNcEhXdkZt?= =?utf-8?B?dWlpMXp2TXJVS0dXd3lZdEtxTjhGZWY5Kyt3OFBZNmtuQ1Q0bFRmbTgzT2w2?= =?utf-8?B?VVlxb1dhbWdRR255ZGRPU2luODBKTEE1cEVPWmM2THg5Rjcrb05pTUFVWUFW?= =?utf-8?B?RjJwTzNjR0c5cnFhV2lBdlpydHJRUHhwQjRZWlNJT2JEb3J6azl6LzFFK1Jj?= =?utf-8?B?TDJzNEZWWUVFK0c0ZWhPUlc5dm1Sc3JVS1RCRkcyUDRHODExUnJtK3lDOExW?= =?utf-8?B?Y21iS0JKalViNVdNSjU1UmtLU0FmUTd1Q3lYdnZqZ0w4bXZVK2FtSXpLM0FU?= =?utf-8?B?QXpBVVJvbGNBMGIxckllcHJLeStKYkR2WnllSitvcVozNWduUVhjMnp5bm9p?= =?utf-8?B?Q1ZXcS90NWw4OTM5S2VHZHVXdU0wVXd1OEQvckZsYyt2R0t6ck1UTlk4Zmlx?= =?utf-8?B?YW80WndMOVc1MEl6SkZ6WnVlN2Q2V1Vvay81RDFIUTJHamg4cUtzS085OElv?= =?utf-8?B?UHAwSDdpbVpkVjlNV29SbjFxMUZERlV3d1cvS2daMDJOMi9zUEpHZHcwK0JI?= =?utf-8?B?S2lTc0J0bkJyL096bUZoZVNxUGsrTW9lUzNJN204NUVQQXFHTkFaOVkxL1Zy?= =?utf-8?B?OGlNM01malljVzFWaWJNSTJqYmlZRE0xekRYOStFL1pUOE5LZWE0SjlKSzBS?= =?utf-8?B?YzJ6U1ltUXVSZi85RUdrc1psYjNKTmhWdEthU29hQWpCb0k0b0ZmZHJsc1JP?= =?utf-8?B?ZHlCODNNNFRydkF4NHVqMXMvTlF1enAzeS9zSHR2TG45eGJ3V0x1Z2dyN3JR?= =?utf-8?B?VXRJdlRkSHlTTzdkWVBiMkVEM04xRytDNW52cmZVZ09LalFwdGkzU0JLM3ZU?= =?utf-8?B?L21qYk5HM29SbkFVUmZvK1NBTXMrTTJHczM5MThrSzRyN0UrMG1nV3RZY2FJ?= =?utf-8?B?aVNQNk11Q1ZYRFRCOU9KNFNwNnZVaUNpL0FQdDN6YXIyeGFQVXo3UldzUUFL?= =?utf-8?B?ekJiOGNVNlU4MElwSktDOUIzTVhCczMzNVdwMGJvOXJyU2JER0dFQytyWjFB?= =?utf-8?B?T0NpWWdJV2dnbks5YmR5M21VTVV0TUJuaTU5WTJMTnNxZzFvNlNiWTZNRW8z?= =?utf-8?B?azNxTGVDb2tHcEdoczgrSTlnTVc2UTlna1h6eGVQYldsdUNtSHY3R0NSSUpi?= =?utf-8?B?em9sWTRHaVpDeXl2Zmlsc0JETVZJcmI0c01mdHZNWG9YVW8wNVc3djBvbDVw?= =?utf-8?B?b0VobXFhRTMrbDJTY1FoWk5veStVaFNrL29TRTdnNzFmcVZUTVdPa1g2WUM1?= =?utf-8?B?UXd4SHplamJRUitBZ1dvdVU4YU1wRzRYWEc3TjlOdFFXcDhINU5ET1doS25n?= =?utf-8?B?YndrdnBuampNOVNLOFVOaWgyNHB2WXIrKzl1UEFUQlJEZEN0NVhvcXFRRVdZ?= =?utf-8?B?REQxSmFzY25wV09ka2tIbi8rQzduSUh1N1MxQm1PV0JmVVRNZ1Jla3NwRnpl?= =?utf-8?B?V0JWbW4ya1QvZXg1N2YrQ1NzMFdFem1vTEVMUVpZL0pyYlR0VHdZaXRIaGRk?= =?utf-8?B?cjlWMFZjeWoxamJXUFk0MCs2YkhER1ErNzBzTitXSjlqY094Y2lITjd1YW1i?= =?utf-8?B?bzBFMkhmYWtSMGxCM3B3UlpMMWpEYjIvdWt2R2ZTSHNmZ01sQ3MyZ2NQLytY?= =?utf-8?Q?ljJcCpofkgD7NwtYUaTjQUVOs83Ayw6GpgBV4lo?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR11MB6502.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230037)(366013)(376011)(1800799021); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Q1BVZmpSU2NUSjFxTEU5TG8vQkM2Zm0yZmp5UDE0SUduQThxYm5Uazl4ODJK?= =?utf-8?B?MVI1aUphNGRmdC9FLzJsYU5jZ1BLSjVJVnJ3VEprT3lXS1hnMzVxRUhOUVBI?= =?utf-8?B?czZISHlwMm9YUTFZODcydHAvYjM3M2xTRHIwbWtOcFVFOU9rTHcvZDJMciti?= =?utf-8?B?STI0Wjc1MFN0NzVmZTU3dHVGZjJoTnp0VFZqeFcxaVFLd0d3cnVjdHNEUXBj?= =?utf-8?B?ajkvSDdTalJueXpEdE9YSTNQazRBTG5YZ29VaUNlZ3VPeThCbkJ0a09jc3ho?= =?utf-8?B?YzRzeWhNVFllRXNycmJ4c05DWFN4MGwxKzVrWExXTEkySiszRGVJejhGcGM0?= =?utf-8?B?NWdRb3RPRzVNWTExSmlvOXZDK0JYck5ENGduRVd0YjgwUEZyUVJIbzNXSVJU?= =?utf-8?B?SXBMTHZBYWlNVEpkTTdFVk5sSEVHUFdjdWNVMzcxNGdtS3UvMHJ0N1VyMldM?= =?utf-8?B?bzVXWkFVVVQ3ZGg1S0ZtQVdNK2xvdldSZkhWYkI3Uzd6S3JrMWVwY2FLMlZm?= =?utf-8?B?TVE2YTMySlRXMmFCQmxwdnRQeTgrcmZrWGJRNVBySlFtOGhoWXV3UFVvaFJl?= =?utf-8?B?UVlNVVY3anJ3eTZBRnloTkRlaGpHQVlQZ1JmS0hpQmVOaUxqUU1DRDZuVEtQ?= =?utf-8?B?VWRGOGlSdVZSWnF4NTIyOHNtZkd0S2JyaUd1ak56MEdkYVdHRXorRWQra01W?= =?utf-8?B?bnBtYjZqOTFOUGVsTTNqRTY5ZCtWREZoV3hVMGtCSExDQnIzdGpmUE5iNmlq?= =?utf-8?B?OEFTeE54N25BUFBUbDBPTVpibm0zQlBhNU56ajkzS2ZieWRyOVdCdW15TmlP?= =?utf-8?B?d0VjYjMrN1Q4WmJHbW53RmNCMHYzV0MrNVhZZHBldFB1YVJjdk9mVWNXN3VO?= =?utf-8?B?ZHpHL1JxRzN6L3dqUWVXUGRac0xNNFFCWldaRk1yb2xPbGtVYWtxU05qek9M?= =?utf-8?B?allBVGVjVnl1ZW8yVGlzek5uMmVwSjdCN0F6RXBybkR0OHBQay9qT25zZ2dq?= =?utf-8?B?Wit0NTB2TmEzdVFqT0ZXRlJqZ05ZK043TDg1UXVFTVlrbFk2c25qcGlUOEpG?= =?utf-8?B?QlNTSkt2amlrSzQ3WWdtSFhYa2d3ZFl6SUlpRWYvaWxLU1B1ZG1HRXBENHZI?= =?utf-8?B?T2J2ZzM4VjVZTTlDT3QrMmU1UXRSc0U0T1dvaUM5c3kyMEZzQlNqRWozalg3?= =?utf-8?B?UVoybk1LYlZmck9QazRVL2o1ZURPZ1ppd0pnbHliQnpZbytMWmdaY3FEcWk2?= =?utf-8?B?dXJYaE5XMkU0Rndub3Jma1F5UXo2cGZpOWdQMUZPNWUvMllNeWFtZUtEZjhx?= =?utf-8?B?SU9zazc5ejduS0E1WGdVcmFjR0FidVFKYjlITXh6STNEbFpWN0NuSkJWUVVt?= =?utf-8?B?TW9aYlR4YlU5K05nSG54UFRpemVZY1FYbHZpc0JwZmVHaWY5M3lvRm9ZdlYw?= =?utf-8?B?OFlrTkdFMTJGdDdMUmp2WlBLTTZaekcwQTJBQ1Vjc2Zpem0vWmZsWjNqNGs2?= =?utf-8?B?U0pjTHdBT3dSdG85S1hQSlB5UGFnT2hya09Xbm8ydk8vV0VHbGRrK3lUVVFo?= =?utf-8?B?ckg3L2NQelphM0Z0NmJpTXdxckRsbitFTFBSY083WklyQ1JCbUtKNUR5YkFy?= =?utf-8?B?WTZIQ1FsOWpTNTI5a3ptTVJmRWJISlJLV2JBWkR1VjZDVlo5T3JlM1pncXli?= =?utf-8?B?Z3drRGxqcTdEcVl2bEZtL0xDUjRPU01idnNSQ3phd1hxUGhxaG0wV2VKbDVq?= =?utf-8?B?bWZqZFZVZTVTTVlQdms2bzVKT3M2S2VhOG1xSmtUY2x4VEVqUlA4ekh4QVEy?= =?utf-8?B?QXhDOElycHg2cUxaSVI4dGx0R3FTY2Q5T1FDR05ScmF5Q3RNTng5ellJdFdi?= =?utf-8?B?a1VBdDZDVlRkT09uK0FBZjVVcUpnLzBaSDlTbHJNb2N6YU9ES3lwckJXZFhz?= =?utf-8?B?UUhjZ00wdDlOM3ovUFQyUThZZkw2aElKVEEzRE1CcFNJVnZaL0plb2U4Uk85?= =?utf-8?B?NUtPMFkxTlJXaGRCdVNCZVYzVFR3R1VOQU13WmV5Mjl2RCtXVnZMVUdEWCsw?= =?utf-8?B?UGFkeE13dktxUWx3QzdWRm5mZlQ2clhMM05BUHVmK25oV0wzVFFkOUluQm9U?= =?utf-8?B?dnFnVnpLMk1vYnhsUVdnZFV5aGhlSDh3Rjk1NVFzdXMyZHhFelk5TFk5b1R1?= =?utf-8?B?MlE9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: 0a121e21-705a-465a-404f-08dc8c6c3078 X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB6502.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jun 2024 12:19:07.8180 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 1gzKQ06ZzN1LPq8+UqRFpvW47pvWvX5/+054PAix31yuFoE/3PzKP7Qp0tWoffckDJAsXQo24zVTija9+yzSF6A//d+tpCRKIwrXMOeQ0kk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA3PR11MB7536 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 6/12/2024 5:52 AM, Soumyadeep Hore wrote: > 'u32' data type is used for the struct members in > 'virtchnl2_version_info' which should be '__le32'. > Make the change accordingly. It is not stated why the data type "should" be __le32. Can the commit message be clarified to explain why this should be the case? > > Signed-off-by: Soumyadeep Hore > --- > drivers/common/idpf/base/virtchnl2.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/common/idpf/base/virtchnl2.h b/drivers/common/idpf/base/virtchnl2.h > index 851c6629dd..1f59730297 100644 > --- a/drivers/common/idpf/base/virtchnl2.h > +++ b/drivers/common/idpf/base/virtchnl2.h > @@ -471,8 +471,8 @@ > * error regardless of version mismatch. > */ > struct virtchnl2_version_info { > - u32 major; > - u32 minor; > + __le32 major; > + __le32 minor; > }; > > VIRTCHNL2_CHECK_STRUCT_LEN(8, virtchnl2_version_info); -- Thanks, Anatoly