From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 000174C71 for ; Tue, 6 Mar 2018 12:57:37 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 06 Mar 2018 03:57:35 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.47,431,1515484800"; d="scan'208";a="23328242" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.237.221.62]) ([10.237.221.62]) by orsmga006.jf.intel.com with ESMTP; 06 Mar 2018 03:57:34 -0800 To: "Varghese, Vipin" , "dev@dpdk.org" , "Pattan, Reshma" Cc: "Mcnamara, John" References: <1520236631-21500-1-git-send-email-vipin.varghese@intel.com> <6cb37db7-9efd-93de-0136-d327f41f9879@intel.com> <4C9E0AB70F954A408CC4ADDBF0F8FA7D4D19DE9B@BGSMSX101.gar.corp.intel.com> From: Ferruh Yigit Message-ID: Date: Tue, 6 Mar 2018 11:57:34 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <4C9E0AB70F954A408CC4ADDBF0F8FA7D4D19DE9B@BGSMSX101.gar.corp.intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v1] app/pdump: add check for PCAP PMD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Mar 2018 11:57:39 -0000 On 3/6/2018 8:45 AM, Varghese, Vipin wrote: > Hi Ferruh, > >> -----Original Message----- >> From: Yigit, Ferruh >> Sent: Monday, March 5, 2018 2:33 PM >> To: Varghese, Vipin ; dev@dpdk.org; Pattan, >> Reshma >> Cc: Mcnamara, John >> Subject: Re: [dpdk-dev] [PATCH v1] app/pdump: add check for PCAP PMD >> >> On 3/5/2018 7:57 AM, Vipin Varghese wrote: >>> dpdk-pdump makes use of LIBRTE_PMD_PCAP for interfacing the ring to >>> the device-queue pair. Updating Makefile to check for the same. >>> >>> Signed-off-by: Vipin Varghese >>> --- >>> app/pdump/Makefile | 4 ++++ >>> 1 file changed, 4 insertions(+) >>> >>> diff --git a/app/pdump/Makefile b/app/pdump/Makefile index >>> bd3c208..038a34f 100644 >>> --- a/app/pdump/Makefile >>> +++ b/app/pdump/Makefile >>> @@ -3,6 +3,10 @@ >>> >>> include $(RTE_SDK)/mk/rte.vars.mk >>> >>> +ifeq ($(CONFIG_RTE_LIBRTE_PMD_PCAP),n) $(error "Please enable >>> +CONFIG_RTE_LIBRTE_PMD_PCAP") endif >> >> pdump is enabled default, so won't this break the default build? > > Yes, you are right it will fail. Which then forces the user to enable PCAP. We shouldn't break the default build because of missing dependencies. > >> >> What about moving this to lib/librte_pdump, convert $(error ..) to $(warning ..) >> and disable CONFIG_RTE_LIBRTE_PDUMP there? > > If we set to warning and there are no PCAP headers in build system. The application gets built, but will fail internally becz the pcap API will fails during execution. if CONFIG_RTE_LIBRTE_PDUMP disabled application won't be compiled > >> >>> + >>> ifeq ($(CONFIG_RTE_LIBRTE_PDUMP),y) >>> >>> APP = dpdk-pdump >>> >