From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 18D8147D1 for ; Fri, 9 Dec 2016 12:54:18 +0100 (CET) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga103.fm.intel.com with ESMTP; 09 Dec 2016 03:54:18 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,324,1477983600"; d="scan'208";a="40810982" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.29]) ([10.237.220.29]) by fmsmga006.fm.intel.com with ESMTP; 09 Dec 2016 03:54:17 -0800 To: Bernard Iremonger , thomas.monjalon@6wind.com, dev@dpdk.org References: <1481282878-26176-1-git-send-email-bernard.iremonger@intel.com> From: Ferruh Yigit Message-ID: Date: Fri, 9 Dec 2016 11:54:16 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <1481282878-26176-1-git-send-email-bernard.iremonger@intel.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v1 0/5] net/ixgbe: move set VF functions. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 Dec 2016 11:54:19 -0000 On 12/9/2016 11:27 AM, Bernard Iremonger wrote: > This patchset implements the following deprecation notice: > [PATCH v1] doc: announce API and ABI change for librte_ether > > The following functions from eth_dev_ops have been moved to the ixgbe PMD > and renamed: > > ixgbe_set_pool_rx_mode > ixgbe_set_pool_rx > ixgbe_set_pool_tx > ixgbe_set_pool_vlan_filter > ixgbe_set_vf_rate_limit > > Renamed the functions to the following: > > rte_pmd_ixgbe_set_vf_rxmode > rte_pmd_ixgbe_set_vf_rx > rte_pmd_ixgbe_set_vf_tx > rte_pmd_ixgbe_set_vf_vlan_filter > rte_pmd_ixgbe_set_vf_rate_limit > > Testpmd has been modified to use the following functions: > rte_pmd_ixgbe_set_vf_rxmode > rte_pmd_ixgbe_set_vf_rate_limit > > New testpmd commands have been added to test the following functions: > rte_pmd_ixgbe_set_vf_rx > rte_pmd_ixgbe_set_vf_tx > rte_pmd_ixgbe_set_vf_vlan_filter > > The testpmd user guide has been updated for the new commands. > > Bernard Iremonger (5): > net/ixgbe: move set VF functions from the ethdev > app/testpmd: use ixgbe public functions > app/testpmd: add command for set VF VLAN filter > app/testpmd: add command for set VF receive > app/testpmd: add command for set VF transmit > > app/test-pmd/cmdline.c | 270 +++++++++++++++++++++++++++- > app/test-pmd/config.c | 31 ++-- > doc/guides/testpmd_app_ug/testpmd_funcs.rst | 21 +++ > drivers/net/ixgbe/ixgbe_ethdev.c | 263 +++++++++++++++++++++++++++ > drivers/net/ixgbe/rte_pmd_ixgbe.h | 104 +++++++++++ > drivers/net/ixgbe/rte_pmd_ixgbe_version.map | 10 ++ > 6 files changed, 678 insertions(+), 21 deletions(-) > Why this patchset doesn't remove ethdev updates for these functions? ixgbe is the only user for these eth-dev_ops, since code moved to ixgbe driver, they and relevant rte_eth_xx functions (and deprecation notice) can be removed in this patchset. Most probably after testpmd updated to prevent compilation errors.