DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] ethdev: increase length device internal name
@ 2017-09-27  9:23 Stephen Hemminger
  2017-10-09 23:12 ` Ferruh Yigit
  0 siblings, 1 reply; 3+ messages in thread
From: Stephen Hemminger @ 2017-09-27  9:23 UTC (permalink / raw)
  To: dev; +Cc: Stephen Hemminger, Stephen Hemminger

Allow sufficicent space for UUID in string form (36+1).
Needed to use UUID with Hyper-V. This was in deprecation notice
for previous release and make it so in 17.11.

Signed-off-by: Stephen Hemminger <sthemmin@microsoft.com>
---
 doc/guides/rel_notes/deprecation.rst    | 3 +++
 lib/librte_eal/common/include/rte_dev.h | 6 +++++-
 2 files changed, 8 insertions(+), 1 deletion(-)

diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
index 3362f33501dd..ba5b68e70098 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -120,3 +120,6 @@ Deprecation Notices
   The non-"do-sig" versions of the hash tables will be removed
   (including the ``signature_offset`` parameter)
   and the "do-sig" versions renamed accordingly.
+
+* ethdev: in 17.11 the size of internal device name is increased
+  to 64 characters to allow for storing longer bus specific name.
diff --git a/lib/librte_eal/common/include/rte_dev.h b/lib/librte_eal/common/include/rte_dev.h
index 5386d3a28be5..4c4ac7e5d375 100644
--- a/lib/librte_eal/common/include/rte_dev.h
+++ b/lib/librte_eal/common/include/rte_dev.h
@@ -152,7 +152,11 @@ struct rte_driver {
 	const char *alias;              /**< Driver alias. */
 };
 
-#define RTE_DEV_NAME_MAX_LEN (32)
+/*
+ * Internal identifier length
+ * Sufficiently large to allow for UUID or PCI address
+ */
+#define RTE_DEV_NAME_MAX_LEN 64
 
 /**
  * A structure describing a generic device.
-- 
2.11.0

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH] ethdev: increase length device internal name
  2017-09-27  9:23 [dpdk-dev] [PATCH] ethdev: increase length device internal name Stephen Hemminger
@ 2017-10-09 23:12 ` Ferruh Yigit
  2017-10-09 23:14   ` Ferruh Yigit
  0 siblings, 1 reply; 3+ messages in thread
From: Ferruh Yigit @ 2017-10-09 23:12 UTC (permalink / raw)
  To: Stephen Hemminger, dev; +Cc: Stephen Hemminger

On 9/27/2017 10:23 AM, Stephen Hemminger wrote:
> Allow sufficicent space for UUID in string form (36+1).
> Needed to use UUID with Hyper-V. This was in deprecation notice
> for previous release and make it so in 17.11.
> 
> Signed-off-by: Stephen Hemminger <sthemmin@microsoft.com>

Except from below note,
Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>

> ---
>  doc/guides/rel_notes/deprecation.rst    | 3 +++
>  lib/librte_eal/common/include/rte_dev.h | 6 +++++-
>  2 files changed, 8 insertions(+), 1 deletion(-)
> 
> diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
> index 3362f33501dd..ba5b68e70098 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -120,3 +120,6 @@ Deprecation Notices
>    The non-"do-sig" versions of the hash tables will be removed
>    (including the ``signature_offset`` parameter)
>    and the "do-sig" versions renamed accordingly.
> +
> +* ethdev: in 17.11 the size of internal device name is increased
> +  to 64 characters to allow for storing longer bus specific name.

There is already a deprecation notice added in previous release for this
release. Since this patch implements it, notice should be removed,
instead of adding new one.

> diff --git a/lib/librte_eal/common/include/rte_dev.h b/lib/librte_eal/common/include/rte_dev.h
> index 5386d3a28be5..4c4ac7e5d375 100644
> --- a/lib/librte_eal/common/include/rte_dev.h
> +++ b/lib/librte_eal/common/include/rte_dev.h
> @@ -152,7 +152,11 @@ struct rte_driver {
>  	const char *alias;              /**< Driver alias. */
>  };
>  
> -#define RTE_DEV_NAME_MAX_LEN (32)
> +/*
> + * Internal identifier length
> + * Sufficiently large to allow for UUID or PCI address
> + */
> +#define RTE_DEV_NAME_MAX_LEN 64
>  
>  /**
>   * A structure describing a generic device.
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH] ethdev: increase length device internal name
  2017-10-09 23:12 ` Ferruh Yigit
@ 2017-10-09 23:14   ` Ferruh Yigit
  0 siblings, 0 replies; 3+ messages in thread
From: Ferruh Yigit @ 2017-10-09 23:14 UTC (permalink / raw)
  To: Stephen Hemminger, dev; +Cc: Stephen Hemminger

On 10/10/2017 12:12 AM, Ferruh Yigit wrote:
> On 9/27/2017 10:23 AM, Stephen Hemminger wrote:
>> Allow sufficicent space for UUID in string form (36+1).
>> Needed to use UUID with Hyper-V. This was in deprecation notice
>> for previous release and make it so in 17.11.
>>
>> Signed-off-by: Stephen Hemminger <sthemmin@microsoft.com>

> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>

Applied to dpdk-next-net/master, thanks.

(deprecation notice fixed while applying)

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2017-10-09 23:14 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-09-27  9:23 [dpdk-dev] [PATCH] ethdev: increase length device internal name Stephen Hemminger
2017-10-09 23:12 ` Ferruh Yigit
2017-10-09 23:14   ` Ferruh Yigit

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).