From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [148.163.129.52]) by dpdk.org (Postfix) with ESMTP id 1F5F85F2D for ; Tue, 16 Apr 2019 11:33:46 +0200 (CEST) X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mx1-us3.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with ESMTPS id B8857B40057; Tue, 16 Apr 2019 09:33:43 +0000 (UTC) Received: from [192.168.38.17] (91.220.146.112) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Tue, 16 Apr 2019 10:33:33 +0100 To: Ferruh Yigit , Thomas Monjalon CC: , Chas Williams , Hemant Agrawal , Shreyansh Jain , Wenzhuo Lu , Matan Azrad , Shahaf Shuler , Rasesh Mody , Shahed Shaikh , Tomasz Duszynski , Liron Himi , Alan Winkowski , Jasvinder Singh , Cristian Dumitrescu References: <8025349.HGM0LRMdJy@xps> <366feb0e-cb95-5520-7daf-665818085d8c@solarflare.com> <75db6e78-275e-80fb-9a57-305344a03b38@intel.com> From: Andrew Rybchenko Message-ID: Date: Tue, 16 Apr 2019 12:33:29 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <75db6e78-275e-80fb-9a57-305344a03b38@intel.com> Content-Language: en-GB X-Originating-IP: [91.220.146.112] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.5.1010-24554.003 X-TM-AS-Result: No-15.487500-8.000000-10 X-TMASE-MatchedRID: C/snMIRQLS0OwH4pD14DsPHkpkyUphL99p2lk/q5LLrb6Y+fnTZUL80J wDpl3OPvFrWw8IJlURsyy1N8n/3eDF+FEY5pP0i/vJsORwCzNhE4gG1vqBBN+JsfQQp16jP3NUI c8ma/DM/rUWEjTM9FINMRv+b57d0FZSU6HajahM4QDf0hTLXhcSmkZgwpl7M3gB9jdxVa+8mstL 0AohSuUA+I8OroL5/1b6fm/8CuE0/1gIcH5B4YaNxajlW+zwxCxBgaBynd2vkWnuSeJfGi8yQ5B pELg58DAKF12TsXeQ8bHN3VKWm8wJO7ij3TaTVLj56aIafJ4NHj5lyuq8IOQTTp2FynA0cQcsEJ zzK7CbKkRgEg7nrRyuutPg6r34pTgiIO7Sf/7rE00dkxYNMRt4n4DdeD/uLNw7+XQ3Lk9nkahnO 4XreYZkAGsuRpDYyrLqrhiVS5o0Bojy6sieK6UAcbMHjYNxGhhZApJAdFDDabKItl61J/ycnjLT A/UDoAoTCA5Efyn8AiEOZmeUqhz3zSD32RQxb6/ioBdS0CxS4VgKYdOTFFDY0p6MCvGG4zt/05z ptIbBd+EtvZoZhavwNrMpndR2WdvahCm1dcecG0ekPn8SYnkRyFdNnda6Rv X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--15.487500-8.000000 X-TMASE-Version: SMEX-12.5.0.1300-8.5.1010-24554.003 X-MDID: 1555407225-p64ShEuHX1wV Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] ethdev flow director/filtering/steering API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Apr 2019 09:33:46 -0000 On 4/12/19 8:57 PM, Ferruh Yigit wrote: > On 4/11/2019 9:43 AM, Andrew Rybchenko wrote: >> On 4/11/19 10:49 AM, Thomas Monjalon wrote: >>> About the features called flow director, filtering or flow steering, >>> we have some overlap in our API that we should clean. >>> It is especially important when considering to freeze the API for stability. >>> >>> Please read this deprecation notice from December 2016: >>> >>> * ethdev: the legacy filter API, including >>> ``rte_eth_dev_filter_supported()``, ``rte_eth_dev_filter_ctrl()`` as well >>> as filter types MACVLAN, ETHERTYPE, FLEXIBLE, SYN, NTUPLE, TUNNEL, FDIR, >>> HASH and L2_TUNNEL, is superseded by the generic flow API (rte_flow) in >>> PMDs that implement the latter. >>> Target release for removal of the legacy API will be defined once most >>> PMDs have switched to rte_flow. >>> >>> We must mark the eth_dev_filter API as deprecated and decide about >>> a date to remove it. >>> >>> Which PMD is implementing this API and not rte_flow? >> In accordance with feature matrix is it i40e_vec, ixgbe_vec and qede, but >> I think it is just a mistake in documentation. >> >> Flow API support tick is missing for many PMDs which actually implement >> (as far as I can see): bonding, dppa2, e100, mlx4, qede, mvpp2, softnic. >> I've added maintainers to CC. > I think having both "Flow control" and "Flow API" is confusing, it looks to me > "Flow control" is name of the feature, "Flow API" is implementation detail and > other implementation detail is "Flow director" > > From the consumers point of view, to they need to know if the flow control > implemented using "Flow API"? This information looks like more driver internal. Flow control and flow API are absolutely different features. Flow control is about Ethernet pauses etc. Flow API is about filtering and actions. Flow director is mainly filtering approach and I would agree to classify it as implementation detail. I'd consider to move it under flow API umbrella finally, but I don't know enough details on it. > Keeping only "Flow control" in feature list, and remove "Flow API" & "Flow > director", and set "Flow control" as support both with implementations makes > sense to me. What do you think? > >>> If there are still some, deadlines should help them to be converted :) >>> If some help is needed, please ask. >>> >>> Anyway, after more than 2 years of notice, I think it is fair to mark >>> the legacy API as deprecated in 19.05 release. >> I agree. I think it is a good idea. >> >> Andrew. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 02164A00E6 for ; Tue, 16 Apr 2019 11:33:48 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 07D701B494; Tue, 16 Apr 2019 11:33:48 +0200 (CEST) Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [148.163.129.52]) by dpdk.org (Postfix) with ESMTP id 1F5F85F2D for ; Tue, 16 Apr 2019 11:33:46 +0200 (CEST) X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mx1-us3.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with ESMTPS id B8857B40057; Tue, 16 Apr 2019 09:33:43 +0000 (UTC) Received: from [192.168.38.17] (91.220.146.112) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Tue, 16 Apr 2019 10:33:33 +0100 To: Ferruh Yigit , Thomas Monjalon CC: , Chas Williams , Hemant Agrawal , Shreyansh Jain , Wenzhuo Lu , Matan Azrad , Shahaf Shuler , Rasesh Mody , Shahed Shaikh , Tomasz Duszynski , Liron Himi , Alan Winkowski , Jasvinder Singh , Cristian Dumitrescu References: <8025349.HGM0LRMdJy@xps> <366feb0e-cb95-5520-7daf-665818085d8c@solarflare.com> <75db6e78-275e-80fb-9a57-305344a03b38@intel.com> From: Andrew Rybchenko Message-ID: Date: Tue, 16 Apr 2019 12:33:29 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <75db6e78-275e-80fb-9a57-305344a03b38@intel.com> Content-Language: en-GB X-Originating-IP: [91.220.146.112] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.5.1010-24554.003 X-TM-AS-Result: No-15.487500-8.000000-10 X-TMASE-MatchedRID: C/snMIRQLS0OwH4pD14DsPHkpkyUphL99p2lk/q5LLrb6Y+fnTZUL80J wDpl3OPvFrWw8IJlURsyy1N8n/3eDF+FEY5pP0i/vJsORwCzNhE4gG1vqBBN+JsfQQp16jP3NUI c8ma/DM/rUWEjTM9FINMRv+b57d0FZSU6HajahM4QDf0hTLXhcSmkZgwpl7M3gB9jdxVa+8mstL 0AohSuUA+I8OroL5/1b6fm/8CuE0/1gIcH5B4YaNxajlW+zwxCxBgaBynd2vkWnuSeJfGi8yQ5B pELg58DAKF12TsXeQ8bHN3VKWm8wJO7ij3TaTVLj56aIafJ4NHj5lyuq8IOQTTp2FynA0cQcsEJ zzK7CbKkRgEg7nrRyuutPg6r34pTgiIO7Sf/7rE00dkxYNMRt4n4DdeD/uLNw7+XQ3Lk9nkahnO 4XreYZkAGsuRpDYyrLqrhiVS5o0Bojy6sieK6UAcbMHjYNxGhhZApJAdFDDabKItl61J/ycnjLT A/UDoAoTCA5Efyn8AiEOZmeUqhz3zSD32RQxb6/ioBdS0CxS4VgKYdOTFFDY0p6MCvGG4zt/05z ptIbBd+EtvZoZhavwNrMpndR2WdvahCm1dcecG0ekPn8SYnkRyFdNnda6Rv X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--15.487500-8.000000 X-TMASE-Version: SMEX-12.5.0.1300-8.5.1010-24554.003 X-MDID: 1555407225-p64ShEuHX1wV Content-Type: text/plain; charset="UTF-8"; format="flowed" Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] ethdev flow director/filtering/steering API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190416093329.HTl0orWQGGBMv6HknPLTfzaoH2ygtt1ZROzFv8GkwMA@z> On 4/12/19 8:57 PM, Ferruh Yigit wrote: > On 4/11/2019 9:43 AM, Andrew Rybchenko wrote: >> On 4/11/19 10:49 AM, Thomas Monjalon wrote: >>> About the features called flow director, filtering or flow steering, >>> we have some overlap in our API that we should clean. >>> It is especially important when considering to freeze the API for stability. >>> >>> Please read this deprecation notice from December 2016: >>> >>> * ethdev: the legacy filter API, including >>> ``rte_eth_dev_filter_supported()``, ``rte_eth_dev_filter_ctrl()`` as well >>> as filter types MACVLAN, ETHERTYPE, FLEXIBLE, SYN, NTUPLE, TUNNEL, FDIR, >>> HASH and L2_TUNNEL, is superseded by the generic flow API (rte_flow) in >>> PMDs that implement the latter. >>> Target release for removal of the legacy API will be defined once most >>> PMDs have switched to rte_flow. >>> >>> We must mark the eth_dev_filter API as deprecated and decide about >>> a date to remove it. >>> >>> Which PMD is implementing this API and not rte_flow? >> In accordance with feature matrix is it i40e_vec, ixgbe_vec and qede, but >> I think it is just a mistake in documentation. >> >> Flow API support tick is missing for many PMDs which actually implement >> (as far as I can see): bonding, dppa2, e100, mlx4, qede, mvpp2, softnic. >> I've added maintainers to CC. > I think having both "Flow control" and "Flow API" is confusing, it looks to me > "Flow control" is name of the feature, "Flow API" is implementation detail and > other implementation detail is "Flow director" > > From the consumers point of view, to they need to know if the flow control > implemented using "Flow API"? This information looks like more driver internal. Flow control and flow API are absolutely different features. Flow control is about Ethernet pauses etc. Flow API is about filtering and actions. Flow director is mainly filtering approach and I would agree to classify it as implementation detail. I'd consider to move it under flow API umbrella finally, but I don't know enough details on it. > Keeping only "Flow control" in feature list, and remove "Flow API" & "Flow > director", and set "Flow control" as support both with implementations makes > sense to me. What do you think? > >>> If there are still some, deadlines should help them to be converted :) >>> If some help is needed, please ask. >>> >>> Anyway, after more than 2 years of notice, I think it is fair to mark >>> the legacy API as deprecated in 19.05 release. >> I agree. I think it is a good idea. >> >> Andrew.