From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EAF18A00C4; Sun, 6 Nov 2022 11:04:42 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 773B340691; Sun, 6 Nov 2022 11:04:42 +0100 (CET) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by mails.dpdk.org (Postfix) with ESMTP id A380A4003C for ; Sun, 6 Nov 2022 11:04:41 +0100 (CET) Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 4189562; Sun, 6 Nov 2022 13:04:40 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 4189562 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru; s=default; t=1667729080; bh=cfTT6EfFQd4ygNK3nrYLDrzPtqg+OMOV8DWTRtiW9Tw=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=fPAfQRHgI45Dhf9cBgbtm2NhC3KyLGPJzglWbPddaUDvnQ4rp81Wt7yGZkP1KbSzQ OOaX4K7mKcVn2PHF9ONX0Glh6U4YO/l9hJFGjeUNoSxOivIHrSPr2nToAocyfSfUHi OYzIjx2i1P/hdWeZotNpr6mhddtfzDrmN8u3vgHU= Message-ID: Date: Sun, 6 Nov 2022 13:04:40 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Subject: Re: [PATCH V3] app/testpmd: update bond port configurations when add slave Content-Language: en-US To: "humin (Q)" , Huisong Li , dev@dpdk.org Cc: ferruh.yigit@amd.com, 3chas3@gmail.com, liudongdong3@huawei.com, huangdaode@huawei.com References: <20221028035331.49406-1-lihuisong@huawei.com> <20221029035013.8348-1-lihuisong@huawei.com> <9c1c20bf-9c41-5a82-7613-6124f8c496c4@huawei.com> From: Andrew Rybchenko Organization: OKTET Labs In-Reply-To: <9c1c20bf-9c41-5a82-7613-6124f8c496c4@huawei.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 11/1/22 06:41, humin (Q) wrote: > Reviewed-by: Min Hu (Connor) > > 在 2022/10/29 11:50, Huisong Li 写道: >> Some capabilities (like, rx_offload_capa and tx_offload_capa) of bonding >> device in dev_info is zero when no slave is added. And its capability >> will >> be updated when add a new slave device. >> >> The capability to update dynamically may introduce some problems if not >> handled properly. For example, the reconfig() is called to initialize >> bonding port configurations when create a bonding device. The global >> tx_mode is assigned to dev_conf.txmode. The DEV_TX_OFFLOAD_MBUF_FAST_FREE >> which is the default value of global tx_mode.offloads in testpmd is >> removed >> from bonding device configuration because of zero rx_offload_capa. >> As a result, this offload isn't set to bonding device. >> >> Generally, port configurations of bonding device must be within the >> intersection of the capability of all slave devices. If use original port >> configurations, the removed capabilities because of adding a new slave >> may >> cause failure when re-initialize bonding device. >> >> So port configurations of bonding device also need to be updated >> because of >> the added and removed capabilities. In addition, this also helps to >> ensure >> consistency between testpmd and bonding device. >> >> Signed-off-by: Huisong Li >> --- >>   - v3: fix code comment >>   - v2: fix a spelling error in commit log It fails to apply on dpdk-next-net/main. Could you rebase it, please, and send v4. Thanks.