From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3218CA00BE; Fri, 11 Feb 2022 09:07:54 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CEA25410E5; Fri, 11 Feb 2022 09:07:53 +0100 (CET) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mails.dpdk.org (Postfix) with ESMTP id 96C1B40042 for ; Fri, 11 Feb 2022 09:07:52 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1644566872; x=1676102872; h=message-id:date:subject:to:cc:references:from: in-reply-to:mime-version; bh=+fGNuL31tYjdGA8Xtc0zpEuqlRScCUjNzxs1oEHw2Xc=; b=nb2HX28kyg5U2VP8Tnz8gJFXIh1aIjKBRzvTVzx0kG4iozGDaeVE3Z2a EMLLWrIapTqvWwBsWkds9eoRJGPVjUT8hdfJO2GjuYQwpQSvvHAhUT8aV JL+aiI4o2TwwwgnmSR6Z2cJ/FKjT1vQLyS4zMjlr564b9DhqguS644ntk 7OrRX3TuED36Ey5cpDIW45Zi0UXM3CQS4G51CdbdOhN7nPLW84WGCURJb SZMh3OXiSRiu4j+h2R04d/j2NK3FSAneTiBd0Q3wVCHnCWmbE7wOK4b2c qD2wdGvvcMrkPJuZHLGZa68b7Of2eCj+gdo+XYQ3zSUurbA+KRM/DO/iu A==; X-IronPort-AV: E=McAfee;i="6200,9189,10254"; a="247277094" X-IronPort-AV: E=Sophos;i="5.88,360,1635231600"; d="scan'208,217";a="247277094" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Feb 2022 00:07:51 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,360,1635231600"; d="scan'208,217";a="774170810" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by fmsmga005.fm.intel.com with ESMTP; 11 Feb 2022 00:07:51 -0800 Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Fri, 11 Feb 2022 00:07:50 -0800 Received: from orsmsx602.amr.corp.intel.com (10.22.229.15) by ORSMSX607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Fri, 11 Feb 2022 00:07:50 -0800 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Fri, 11 Feb 2022 00:07:50 -0800 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.107) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Fri, 11 Feb 2022 00:07:50 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PJS9XMeKA7z6wFnEhtLv7Ho7TRC4Jwu9lo+ugNSFfmFgaey6tg79oqLMbyX2pAv75mfmTfgj+TIlYrcaikQsKZBlkcWX33Yg+xiKNhphs14247WPJKtVHTeCzlwxJu/LHAyMhND0kAID70HdLczTM3WEt9tyxmCHUbE3+bdKZYvUxZxh8CrjePABBE4Tf6AXRbpklenXcYfjVgyjxdor2R/zZZwIu6pa1xfctgXtM6HC+507xvlVkCkYlKc4jb2PmFEeGkokJ624C415xwb/ivwmpCfsvEpTI9QD5J1cd/dAnUIhZGC4b08v4zHGiBQ8t1NiztWfPrrTvGx3xRQR8Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qs2G/36uEDqjFnxLL9RINp7B4eT7Y/u5Lt4M+xmF3qo=; b=kD7B/X5bHaFVIpEAtJpfKKwpMZAiogSJ0C8B60ge3czH3S6zc9VlcI9ajwpmMAv49XnkBxGID58SCYEy3k5FasOxLbyOvI7mddFQDBcxOyClO2A6GkcNC+ErkiwRt/NikZdKRDFdgrMixEOvFnTXpJUhWhG3b+BXdOQCUIlDo7EC5lJLDZRz4Xi3HKcV5vws6eqa8xnx3D7awT6WdkcirmBN2qWZPNOMWLbUUBon98octYdRE90cLY0/ixy/mqy1hVZxuSg7ZNi9Hxb/NBoPJOOoFJ/KKoNiKeNwZYQAKGGvZ9sSutP8nKVlLcAnu7NYrBpBBn9OuLKveBkmTHswTA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from MWHPR11MB0062.namprd11.prod.outlook.com (2603:10b6:301:67::34) by MWHPR11MB1774.namprd11.prod.outlook.com (2603:10b6:300:10a::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.11; Fri, 11 Feb 2022 08:07:48 +0000 Received: from MWHPR11MB0062.namprd11.prod.outlook.com ([fe80::417b:7df4:d3fb:2b0a]) by MWHPR11MB0062.namprd11.prod.outlook.com ([fe80::417b:7df4:d3fb:2b0a%3]) with mapi id 15.20.4975.014; Fri, 11 Feb 2022 08:07:48 +0000 Content-Type: multipart/alternative; boundary="------------IgxpgBR502kZUq0MEJjpgGnl" Message-ID: Date: Fri, 11 Feb 2022 13:37:38 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.5.1 Subject: Re: [PATCH v2] devtools/cocci: update cocci for ethdev namespace Content-Language: en-US To: Thomas Monjalon CC: , References: <20220123172046.1296964-1-aman.deep.singh@intel.com> <1842607.g5d078U9FE@thomas> <1843605.IobQ9Gjlxr@thomas> From: "Singh, Aman Deep" In-Reply-To: <1843605.IobQ9Gjlxr@thomas> X-ClientProxiedBy: PN2PR01CA0174.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c01:26::29) To MWHPR11MB0062.namprd11.prod.outlook.com (2603:10b6:301:67::34) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e668ae20-5f74-49bf-38ba-08d9ed359791 X-MS-TrafficTypeDiagnostic: MWHPR11MB1774:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: KmcNh5DIGo/o9zs7TipUTKaErwNnmmxtAGrgGaly0S2gO8aDv6OJHtgJx4axiT9MUsvb8fpx/08xo3jqZ+9pCqnooi44L6Ajx/s8VUAmzY8PJGFa118aQ7ZslAcSGRsSKjI7q4QnCU4IYs7XBRmOfifuo0u3gEzKm1gccgc072AKq+blEXeGL5QxRqha/Kr8pX+77b0y8eZUv4liTMb0USBjgBwprbRJbU39m0iM/n2LpquDKIv49VqEJmGZjUKw/FG12W44X7sxY04nu082Tzb8wDigdj4FBebXQ80J7SRq9qtabpPyopAMmbw1oQgKHqPj8cDdMjQa0CdISc247fJASSlCbO22YDW/uovpAyJLOr32mZE/GHaSZDgzYFpMsPba/s3MtRa/LvOIqMBKhx2gWPjRM0OOzrNhvYYK4r7CsytcXC9iwLVB3Utg8rqv6fUX68aZGU5IOkTC6h8LCgBZI87kX5jEK3txSHJQUs7hnA/IoNvFLMDsS3u2AOI28Ea9D+cfUtFBaIo0R1j7Vt5NZbEsPEOlreowNOnG7nU4KJAw+AGV7uNnxPdfSNIDFaFo1EPVz9z0AKUgUGa+h0QVSl4SwaOEQkTzTkYVcYEdIWsf3+sy2dY9vUoCrQdNctaTyCZKaAcJs53zH1TkwYeStI6ooBfh9r2U/lIwsYzeQ9vzdumDP56K5rH2lX/7EZn6DUns+DLFwlkjpsaI7kSuenoV3542D0xqwJvNLyzJLhQ4EaobKWyzWFK9wKjYzt9PRvHhGDmgYsStYbPmLA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR11MB0062.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(36756003)(31686004)(6486002)(31696002)(508600001)(86362001)(5660300002)(2906002)(82960400001)(83380400001)(26005)(6916009)(33964004)(6506007)(66476007)(66946007)(66556008)(15650500001)(8676002)(6666004)(4326008)(6512007)(53546011)(2616005)(107886003)(8936002)(186003)(38100700002)(316002)(21314003)(45980500001)(43740500002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?S0NKaGVLSnhjWUhJWHRQMGdUZU96NFlEN0hsT1FkV2QxYzdPNkJVcmZLallJ?= =?utf-8?B?MHlaMXVldllCYTcrSjZtbU1hZ2dMT0JrdmtYZmIyQXpCQzhTdC9NbVRweUJ1?= =?utf-8?B?cGh6d1FORXRNVFJ0L21tU3VrZm9hNVhnU0lRYi9IaW4zRjBNdVN6RGRIenhz?= =?utf-8?B?eGNoMUtEK2VHTmJPekl3S2VubWYxL2RyU0FyM0pLd2lpNElaUHd2Qm9FNWRB?= =?utf-8?B?MFFyaDhRN3pXVXBNbFJXSm1jdEIwdDhoL2Z2cTJ5SC9yYUpaMlBCTHRxWmxX?= =?utf-8?B?ZG9ZR1Z1ZzRScHc4aXQyY1dHenZvcG1Nc2k0ZDR3Vm90bVVpTHBkOFpaYlRm?= =?utf-8?B?YUtnZEEzVmVXTk1abURsdjFuek9qUm9VLzNReTlYcjBQR3R6NU9MSXNxNVV3?= =?utf-8?B?NC9mdkJNUHB0RFlUVUVFWlVFeHdzem1WaXl1V2J5aFVsZGM1Q05RVFc3U1BS?= =?utf-8?B?V1RyQ1NLRWVXbDdLMit3cjhlTTVESVR0SmpFeU1hZU95WDdBam9GQlQyQXRQ?= =?utf-8?B?NnNMdHBQVWIwWnJ0VmNCTEtLMnRONnlOL0p4dEl4S1JPWjZWdVErMmJ0WFph?= =?utf-8?B?SEM5WHVQM1hwVE9RK2h4b255NjRkS0tjeDUwak9wR1ZRc1I5dWcvN2dnajJy?= =?utf-8?B?cm80SERkT0JCSE43Q1hZazJ0N0tJMzZLakpGNUhKVllPWSttR0pOWG84Y0Y2?= =?utf-8?B?T25yRndtYzFxZk95MSt1Y05pZFpRVzFYQjNsU0VCdlIyWkkySUhMNU1BN2I4?= =?utf-8?B?T2Y5ZjNhdDZCK0hOR1JaMGdjRUh1QnFHallOZkZYUXBubm5SWUViNDcyWXQ4?= =?utf-8?B?YUU5WHZGVEJ4NTZoRndoU2NacyszSkZjRWg4SDVRdXZRZFVBYlVKTnlHU0Zw?= =?utf-8?B?S2lIOCttQTZic3Y5TkxGVUVpU0JJMVg2cXlJVTlDTjZiYmttdmp1Z05WdnpR?= =?utf-8?B?VWdCdTN3bnJTSkJRYUZJZDQ0VC9VYlRvc3lXenVQYXhRajN6YU14amwvdjJi?= =?utf-8?B?MnVOYWExSGtMN2d0K1dQT2hoeTl0RHZtN1I4WXlUV1VmSTFMTkhhK296WGN0?= =?utf-8?B?OVNscUZMbFJmdmVndFRFclNZMnlLNHFvMjRQMHZhMUFKeFdIRllNVFlMVGcv?= =?utf-8?B?WkZiSmppcll6S1lUWFJNVUhnNHNqRFZqc3JrT1BlL0ttNG1mdnlsa2VIdUFq?= =?utf-8?B?ZzUrcXVyZUJnam9PcFpPWlZXUHdDenJSN3NlRGlNOEVpT1NVbXFQRDQ0bUlw?= =?utf-8?B?VTE3THN3QWRuOThTYVpLc0lBU1JyQzNVWXFHK2J2cnkyRWJtOVhRVXZqZWlx?= =?utf-8?B?eWprM1ZsUm1HRzN2Y1BWS2wzT0s0V1pWVXUyMGRoS1J5bEYyaGNRRmcvTVR5?= =?utf-8?B?aGlDQVhrUEJlOS9US2xQT1FiSlJNV3FMNTMxVUZteis4UUdid01HZEhLU2lZ?= =?utf-8?B?Q3U5eDdwcGxuc3dZY09Ba1lHSzRnUUIzUVZjWkNsbGs4NEgrRkZramJ0Y0wv?= =?utf-8?B?R0ZDUDd3N1liZ0ZmVnEzeERjYWxJeU5aTzBPTmpEV0Q2K3lxK2t5bHJDMVRn?= =?utf-8?B?Z0RVUzNIalIwdkhxSkJ6M3B1S1BLZmY1M3lycTI4c0djV1NPQ1RkUFFwMkta?= =?utf-8?B?d2cwYnZ2eDJVWlQySWloLzFaNWZaVmQzSitQMnZ6VjJRWVptR1FzSU9jeXVB?= =?utf-8?B?QlhvcG1QT3pvTjQrME5uUExkeXBRbFNkT3IvY3NmQUVMUkJCNmE3UzdGVFQx?= =?utf-8?B?aGlLZ0k5UytEcjlzQ2dVWHpVT2tOVFdjWm9qNXNNNStqdzR2RzlvcDM1emto?= =?utf-8?B?bkhWNThvcjZLT1BRZVZmOU8rYTVQYVdOR2pWczRuSFprVFlFdDRoV0xOMmdL?= =?utf-8?B?WHZoaFA1emdMMGI5QlZjb3FuNGFBRjd5Z2x2NWY4cVhWemZFU1NrdE14UWV1?= =?utf-8?B?Q09tdWxFZlNRcDhvcFEzRWJwMnozTVRmWlV5eURRSGFRbk01MHZLdk4zc0J5?= =?utf-8?B?Y3Z1ajQxaHhlakExWitaMlNDTmhiTGUrY3hDWVZRS2xQMUptQnRsM3k3WW5n?= =?utf-8?B?VmVOYlllLzJlK1FPMnNsZzZ5LzZjOS9teGw1QVZKZ0J1WWhoUUNXL3U1TG5W?= =?utf-8?B?MXNhbTdCOWhkN0lPc2VTUEgyN1BiWXJyeEJ5NEQ2cUlPMHhMRjdpczJNdEZC?= =?utf-8?B?QnZSbEJaTk1YY0hzTDZ2MUJqVnpIZWpVdzlkaExqam04UnZoaXBYT1N1aExi?= =?utf-8?Q?Nr82+ZFsxr24MtZCvHiEZD4hzYJFs5vbpDeYw6mWms=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: e668ae20-5f74-49bf-38ba-08d9ed359791 X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB0062.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Feb 2022 08:07:48.4530 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: A/0WXRXd+u7ZWUTPpveuTi5m4bFyF4FPnARzYP2tYMugPseQvTnGpvrBPk2jTco99RFDZqLrLuFLdvVisrP+2crArk+ijRFTOh5ORQnIoj0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1774 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --------------IgxpgBR502kZUq0MEJjpgGnl Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit On 2/10/2022 9:00 PM, Thomas Monjalon wrote: > 10/02/2022 14:26, Singh, Aman Deep: >> On 2/4/2022 1:17 PM, Thomas Monjalon wrote: >>> 04/02/2022 07:13, Singh, Aman Deep: >>>> Hi Thomas >>>> >>>> On 2/3/2022 2:31 AM, Thomas Monjalon wrote: >>>>> 23/01/2022 18:20, Aman Singh: >>>>>> Added two specific exceptions for ETH_SPEED_10G >>>>>> and ETH_SPEED_25G to avoid there name change. >>>>>> Added check for ETH_TUNNEL_FILTER and ETH_RSS_RETA >>>>> Please could you explain why? >>>> These two macro's ETH_SPEED_10G & ETH_SPEED_25G are used by ifpga >>>> driver and script should no change these. >>>> There are multiple ETH_SPEED_NUM_xxx macro that need to be changed >>>> to RTE_ETH_SPEED_NUM_xxx. So added above two as specific exceptions. >>> Why doing this exception? What is special with ifpga? >> These two macro's are defined in 'ifpga/base/opae_eth_group.h' >> we don't intend to change these. Target is ethdev namespace only. > So we will miss future use of a deprecated macro > because ifpga is redefining it? > I think it is a wrong approach. > We should not make any exception in the check. > Instead we can just ignore the warning for ifpga. Actually ifpga is not redefining these two macro's ETH_SPEED_10G & ETH_SPEED_25G, they are unique to it. Only there prefix, matches with ethdev macro's ETH_SPEED_NUM_xxx, which caused coccinelle script to modify these to RTE_ETH_SPEED_10G & RTE_ETH_SPEED_25G. So just avoiding it by this change. > >>>> The other two patterns ETH_TUNNEL_FILTER & ETH_RSS_RETA were missed before. >>>> The script should change these to RTE_ETH_TUNNEL_FILTER & RTE_ETH_RSS_RETA >>> The explanations should be part of the commit log please. >> Sure, if this explanation is fine? Will update in next version. > Yes thanks. > > --------------IgxpgBR502kZUq0MEJjpgGnl Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: 7bit


On 2/10/2022 9:00 PM, Thomas Monjalon wrote:
10/02/2022 14:26, Singh, Aman Deep:

On 2/4/2022 1:17 PM, Thomas Monjalon wrote:

04/02/2022 07:13, Singh, Aman Deep:

Hi Thomas

On 2/3/2022 2:31 AM, Thomas Monjalon wrote:

23/01/2022 18:20, Aman Singh:

Added two specific exceptions for ETH_SPEED_10G
and ETH_SPEED_25G to avoid there name change.
Added check for ETH_TUNNEL_FILTER and ETH_RSS_RETA

Please could you explain why?

These two macro's ETH_SPEED_10G & ETH_SPEED_25G are used by ifpga
driver and script should no change these.
There are multiple ETH_SPEED_NUM_xxx macro that need to be changed
to RTE_ETH_SPEED_NUM_xxx. So added above two as specific exceptions.

Why doing this exception? What is special with ifpga?

These two macro's are defined in 'ifpga/base/opae_eth_group.h'
we don't intend to change these. Target is ethdev namespace only.

So we will miss future use of a deprecated macro
because ifpga is redefining it?
I think it is a wrong approach.
We should not make any exception in the check.
Instead we can just ignore the warning for ifpga.
Actually ifpga is not redefining these two macro's ETH_SPEED_10G & ETH_SPEED_25G,
they are unique to it. Only there prefix, matches with ethdev macro's
ETH_SPEED_NUM_xxx, which caused coccinelle script to modify these to
RTE_ETH_SPEED_10G & RTE_ETH_SPEED_25G. So just avoiding it by this change.



The other two patterns ETH_TUNNEL_FILTER & ETH_RSS_RETA were missed before.
The script should change these to RTE_ETH_TUNNEL_FILTER & RTE_ETH_RSS_RETA

The explanations should be part of the commit log please.

Sure, if this explanation is fine? Will update in next version.

Yes thanks.
--------------IgxpgBR502kZUq0MEJjpgGnl--