From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EE64DA034F; Tue, 20 Jul 2021 18:20:00 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 49E5E4069F; Tue, 20 Jul 2021 18:20:00 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 0F2E54068B for ; Tue, 20 Jul 2021 18:19:58 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1626797998; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/7TNeqWvXc9ZG/1NcJa+B9Rm97xDJJ3GXPE4lIEbXcM=; b=ZWBexsKngyS0IL984VShoRy8AHe+mKJFh1Kw5GB675jTjSJJYf+F0e4M6h0TtF5w+AQQfy 7CIAUQ5OAuOBMXJjnXmdL5//es/sGzCv71Ny9+vIlo++Lt6Up8gFXAi+4Jq3UohwoIWwt8 sbOBTqntagFdD3Fl8rXp7POxB90NeWg= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-100-w1BEhmjaP0GBrYkEopA6SQ-1; Tue, 20 Jul 2021 12:19:56 -0400 X-MC-Unique: w1BEhmjaP0GBrYkEopA6SQ-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 56B10801A92; Tue, 20 Jul 2021 16:19:07 +0000 (UTC) Received: from [10.36.110.3] (unknown [10.36.110.3]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 66C3819C44; Tue, 20 Jul 2021 16:19:05 +0000 (UTC) To: Andrew Rybchenko , Chenbo Xia , Andrew Rybchenko , Konstantin Ananyev , Shahaf Shuler Cc: dev@dpdk.org, Ivan Ilchenko , stable@dpdk.org References: <20210706141407.2391177-1-andrew.rybchenko@oktetlabs.ru> <20210720075445.1146963-1-andrew.rybchenko@oktetlabs.ru> From: Maxime Coquelin Message-ID: Date: Tue, 20 Jul 2021 18:19:03 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210720075445.1146963-1-andrew.rybchenko@oktetlabs.ru> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=maxime.coquelin@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v3] net/virtio: fix Rx scatter offload X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 7/20/21 9:54 AM, Andrew Rybchenko wrote: > From: Ivan Ilchenko > > Report Rx scatter offload capability depending on VIRTIO_NET_F_MRG_RXBUF. > > If Rx scatter is not requested, ensure that provided Rx buffers on > each Rx queue are big enough to fit Rx packets up to configured MTU. > > Fixes: ce17eddefc20 ("ethdev: introduce Rx queue offloads API") > Cc: stable@dpdk.org > > Signed-off-by: Ivan Ilchenko > Signed-off-by: Andrew Rybchenko > Reviewed-by: Maxime Coquelin > --- > v3: > - fix segfault on MTU set if an Rx queue is not setup > > v2: > - do not overwrite Rx offloads when Rx scatter is added > > drivers/net/virtio/virtio.h | 2 + > drivers/net/virtio/virtio_ethdev.c | 65 ++++++++++++++++++++++++++++++ > drivers/net/virtio/virtio_ethdev.h | 5 +++ > drivers/net/virtio/virtio_rxtx.c | 10 +++++ > 4 files changed, 82 insertions(+) > Thanks for the fix. I see my R-by is already there, but I confirm this is good to me. Maxime