From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id EFF7BA00C2;
	Wed, 28 Sep 2022 09:57:43 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 9084D4113C;
	Wed, 28 Sep 2022 09:57:43 +0200 (CEST)
Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113])
 by mails.dpdk.org (Postfix) with ESMTP id 4C8BF41133
 for <dev@dpdk.org>; Wed, 28 Sep 2022 09:57:42 +0200 (CEST)
Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256)
 (No client certificate requested)
 by shelob.oktetlabs.ru (Postfix) with ESMTPSA id A7E9562;
 Wed, 28 Sep 2022 10:57:41 +0300 (MSK)
DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru A7E9562
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru;
 s=default; t=1664351861;
 bh=8jUU+qYe47p7e9W3zFFE8S9ajHmiustipV6b8IMZYcY=;
 h=Date:Subject:To:Cc:References:From:In-Reply-To:From;
 b=SkhFrtZFipL4RYSSUcb76MFu7XXdyduseTV1mGw3s5I2wVvst7fzmjInO8+b6qTcG
 QFzZqt2zavAFjBR3X8SuslA+jZVXCXUecXg7MLIoemj7qzCJ3q6aIPmyMsPMSFmf8m
 Z4HOFcC9klcmVW/YLco/eV6U/izOoOdX75+HQwaU=
Message-ID: <c6de70d5-9aa0-4731-9792-17354dfab866@oktetlabs.ru>
Date: Wed, 28 Sep 2022 10:57:41 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.13.0
Subject: Re: [PATCH] ethdev: rte_eth_rx_queue_count is a dataplane function
Content-Language: en-US
To: =?UTF-8?Q?Morten_Br=c3=b8rup?= <mb@smartsharesystems.com>,
 Ferruh Yigit <ferruh.yigit@xilinx.com>, thomas@monjalon.net
Cc: dev@dpdk.org
References: <20220818093744.76157-1-mb@smartsharesystems.com>
 <f4d6fbd0-4c30-15cb-ace5-27212a435f7b@xilinx.com>
 <12a94c58-0905-5df3-5bec-65ea9292f22d@oktetlabs.ru>
 <98CBD80474FA8B44BF855DF32C47DC35D87350@smartserver.smartshare.dk>
From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Organization: OKTET Labs
In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35D87350@smartserver.smartshare.dk>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On 9/22/22 16:46, Morten Brørup wrote:
>> From: Andrew Rybchenko [mailto:andrew.rybchenko@oktetlabs.ru]
>> Sent: Monday, 12 September 2022 16.47
>>
>> On 8/18/22 15:23, Ferruh Yigit wrote:
>>> On 8/18/2022 10:37 AM, Morten Brørup wrote:
>>>> Applications may use rte_eth_rx_queue_count() in the RX stage of the
>>>> dataplane, so only check the function parameters if built with
>>>> RTE_ETHDEV_DEBUG_RX.
>>>>
>>>> Signed-off-by: Morten Brørup <mb@smartsharesystems.com>
>>>
>>> I don't remember if those checks done by default intentionally, but I
>>> don't think so,
>>>
>>> And since other relevant functions do the same thing:
>>>
>>> Acked-by: Ferruh Yigit <ferruh.yigit@xilinx.com>
>>>
>>
>> The patch itself looks good to me.
>> Summary should be fixed to be not a statement and should not
>> mention function name.
> 
> Please feel free to fix when merging. :-)
> 
>> Other than that:
>>
>> Reviewed-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
> 
> Thank you.
> 
> -Morten
> 

Applied to dpdk-next-net/main, thanks.