From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 676EBA0564; Fri, 12 Mar 2021 01:08:41 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 062154067E; Fri, 12 Mar 2021 01:08:41 +0100 (CET) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mails.dpdk.org (Postfix) with ESMTP id 6ABA84014D for ; Fri, 12 Mar 2021 01:08:39 +0100 (CET) IronPort-SDR: fmcvAKwYd1ysV++C+GVfMWfJbNDcciFdCAMtddof0Vj4IMQnt5sbdeM+dvdps+bk5Di3ciwRyn BaOlIB+XNHiQ== X-IronPort-AV: E=McAfee;i="6000,8403,9920"; a="168032733" X-IronPort-AV: E=Sophos;i="5.81,241,1610438400"; d="scan'208";a="168032733" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Mar 2021 16:08:32 -0800 IronPort-SDR: 2yKbgwABkjcEVLQyoOE4GdD/8lcpSwgMxnCECHVh7sImKtkVOjZBXleb4pJeNVDh3O9kOhrquE lSPiOiWQYeCg== X-IronPort-AV: E=Sophos;i="5.81,241,1610438400"; d="scan'208";a="404247777" Received: from bcarpe2x-mobl4.ger.corp.intel.com (HELO [10.252.22.85]) ([10.252.22.85]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Mar 2021 16:08:30 -0800 To: Ajit Khaparde Cc: dev@dpdk.org, kalesh-anakkur.purayil@broadcom.com References: <20210310212637.72205-1-ajit.khaparde@broadcom.com> <20210310212637.72205-7-ajit.khaparde@broadcom.com> From: Ferruh Yigit X-User: ferruhy Message-ID: Date: Fri, 12 Mar 2021 00:08:23 +0000 MIME-Version: 1.0 In-Reply-To: <20210310212637.72205-7-ajit.khaparde@broadcom.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v2 06/12] net/bnxt: update HWRM structures X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 3/10/2021 9:26 PM, Ajit Khaparde wrote: > From: Kalesh AP > > Patch brings in the latest hsi_struct_def_dpdk.h. > HWRM API is now updated to version 1.10.2.15. > > Signed-off-by: Kalesh AP > Reviewed-by: Ajit Khaparde > --- > doc/guides/rel_notes/release_21_05.rst | 4 + > drivers/net/bnxt/hsi_struct_def_dpdk.h | 3689 +++++++++++++++++++----- > 2 files changed, 2972 insertions(+), 721 deletions(-) > > diff --git a/doc/guides/rel_notes/release_21_05.rst b/doc/guides/rel_notes/release_21_05.rst > index 9fc5e0d6ca..d5cdb2cd2c 100644 > --- a/doc/guides/rel_notes/release_21_05.rst > +++ b/doc/guides/rel_notes/release_21_05.rst > @@ -80,6 +80,10 @@ New Features > > * Added support for preferred busy polling. > > +* **Updated Broadcom bnxt driver.** > + > + * Updated HWRM structures to 1.10.2.15 version. > + Can you please chage the order in the release notes, the order is: ethdev library, pysical PMDs (alphabetical order for vendor), vitual PMDs, apps (like testpms) Acording this order, in current release notes the PMD should be first item in the section. > @@ -45297,8 +47545,8 @@ struct hwrm_nvm_mod_dir_entry_input { > */ > uint16_t dir_ext; > /* > - * Directory Entry Attribute flags (see BNX_DIR_ATTR_* for attribute flag > - * definitions). > + * Directory Entry Attribute flags (see BNX_DIR_ATTR_* for attribute > + * flag definitions). > */ > uint16_t dir_attr; > /* > @@ -45474,8 +47722,7 @@ struct hwrm_nvm_install_update_input { > #define HWRM_NVM_INSTALL_UPDATE_INPUT_FLAGS_REMOVE_UNUSED_PKG \ > UINT32_C(0x2) > /* > - * If set to 1, FW will defragment the NVM if defragmentation is required > - * for the update. > + * If set to 1, FW will defragment the NVM if defragmentation is required for the update. > * Allow additional time for this command to complete if this bit is set to 1. > */ > #define HWRM_NVM_INSTALL_UPDATE_INPUT_FLAGS_ALLOWED_TO_DEFRAG \ > These changes are only because of word wrapping, there are many samples in the patch. I guess the original code has long lines, as the first version, and when they are converted to shorter lines, it has been done differently from previous time causing these diffs. Can you keep the previous version wrapping to prevent the unnecesarry diffs?