From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 51E7941DF5; Mon, 6 Mar 2023 14:17:52 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EAB8B40E50; Mon, 6 Mar 2023 14:17:51 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id CCF4040A8A for ; Mon, 6 Mar 2023 14:17:49 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1678108669; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/QOl0ugIK+7Ju7EI12VMdrI8B+bmPGI+WcPq76miv30=; b=isSqpa09kTrz3dAj7eTMPUeVniX6iDsdKvoimz8PbGixaVTmYCZzHrgl2cW4r2CcJwynt/ d7VSBPIn4f/JwZ/JzY1Y9lwY9gKFFoAS4JOJj6svc/WXdbghLvCMtPf/uUM66SntLwkgAN 15cUnTLyYEq8spUdlggXKed7/dh/Ig8= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-404-VN8oEM4OONeH3Fab_aFt7g-1; Mon, 06 Mar 2023 08:17:46 -0500 X-MC-Unique: VN8oEM4OONeH3Fab_aFt7g-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id C42913C0F183; Mon, 6 Mar 2023 13:17:45 +0000 (UTC) Received: from [10.39.208.18] (unknown [10.39.208.18]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 6D60D40C10FA; Mon, 6 Mar 2023 13:17:44 +0000 (UTC) Message-ID: Date: Mon, 6 Mar 2023 14:17:42 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v3 01/17] test/bbdev: fix seg fault for non supported HARQ len To: Hernan Vargas , dev@dpdk.org, gakhil@marvell.com, trix@redhat.com Cc: nicolas.chautru@intel.com, qi.z.zhang@intel.com, stable@dpdk.org References: <20230302202211.170017-1-hernan.vargas@intel.com> <20230302202211.170017-2-hernan.vargas@intel.com> From: Maxime Coquelin In-Reply-To: <20230302202211.170017-2-hernan.vargas@intel.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.2 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 3/2/23 21:21, Hernan Vargas wrote: > Fix segmentation fault happening in corner case in test-bbdev. > This fault could happen when running some specific vectors which size > are not supported by the PMD. > > Fixes: 335c11fd276 ("app/bbdev: support HARQ validation") The Fixes tag is still wrong, the SHA-1 should be 12 chars. I'll fix it when applying > Cc: stable@dpdk.org > > Signed-off-by: Hernan Vargas > Reviewed-by: Maxime Coquelin > --- > app/test-bbdev/test_bbdev_perf.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/app/test-bbdev/test_bbdev_perf.c b/app/test-bbdev/test_bbdev_perf.c > index 45e1780df772..027f32cbf1b7 100644 > --- a/app/test-bbdev/test_bbdev_perf.c > +++ b/app/test-bbdev/test_bbdev_perf.c > @@ -84,7 +84,7 @@ > /* Increment for next code block in external HARQ memory */ > #define HARQ_INCR 32768 > /* Headroom for filler LLRs insertion in HARQ buffer */ > -#define FILLER_HEADROOM 1024 > +#define FILLER_HEADROOM 2048 > /* Constants from K0 computation from 3GPP 38.212 Table 5.4.2.1-2 */ > #define N_ZC_1 66 /* N = 66 Zc for BG 1 */ > #define N_ZC_2 50 /* N = 50 Zc for BG 2 */ > @@ -2111,9 +2111,9 @@ validate_op_harq_chain(struct rte_bbdev_op_data *op, > ops_ld->n_filler; > if (data_len > deRmOutSize) > data_len = deRmOutSize; > - if (data_len > orig_op->segments[i].length) > - data_len = orig_op->segments[i].length; > } > + if (data_len > orig_op->segments[i].length) > + data_len = orig_op->segments[i].length; > /* > * HARQ output can have minor differences > * due to integer representation and related scaling