From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9FAE6A04DD; Fri, 20 Nov 2020 17:48:55 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 42C11F90; Fri, 20 Nov 2020 17:48:53 +0100 (CET) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 5699CDED for ; Fri, 20 Nov 2020 17:48:50 +0100 (CET) IronPort-SDR: 3ENrRz1BqxE/1KOjJzCgHCPBTPm4FBztF6i0XuyVbhJ/2Q+3eBy1YEXkJKNRFBE+WwvjJkuRX7 ZHbDTJJCSVkg== X-IronPort-AV: E=McAfee;i="6000,8403,9810"; a="171667532" X-IronPort-AV: E=Sophos;i="5.78,357,1599548400"; d="scan'208";a="171667532" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Nov 2020 08:48:47 -0800 IronPort-SDR: vbB3BjRzvCVMKWVyxKSPIs0+z/7F1c8FILBnZyHfpZR+B2vQ5XF2TW02orWyQvW0/RTNtegpej dO/Blo+WY43A== X-IronPort-AV: E=Sophos;i="5.78,357,1599548400"; d="scan'208";a="360504171" Received: from aburakov-mobl.ger.corp.intel.com (HELO [10.213.212.249]) ([10.213.212.249]) by fmsmga004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Nov 2020 08:48:46 -0800 From: "Burakov, Anatoly" To: dev@dpdk.org Cc: ferruh.yigit@intel.com, thomas@monjalon.net References: <7bda955f729dd450e5cd63e93962df37de4ee91b.1605890459.git.anatoly.burakov@intel.com> Message-ID: Date: Fri, 20 Nov 2020 16:48:44 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <7bda955f729dd450e5cd63e93962df37de4ee91b.1605890459.git.anatoly.burakov@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH DPDK-KMODS] doc: allow external build X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 20-Nov-20 4:41 PM, Anatoly Burakov wrote: > Currently, when building sphinx documentation, the build will only > succeed if being run from the build system, because the conf.py script > expects DPDK_VERSION environment variable to be set, and crashes if it > is not. > > However, there are certain external tools (such as sphinx documentation > preview extensions for certain IDE's) that use live preview and thus > rely on running their own sphinx commands. In these cases, it is useful > to permit building sphinx documentation without specifying the > DPDK_VERSION environment variable. The version string is the only thing > preventing manual sphinx build commands from working. > > Fix the conf.py to use "None" as a version string in cases when > DPDK_VERSION environment variable is not set. > > Signed-off-by: Anatoly Burakov > Acked-by: Bruce Richardson > --- Apologies, something went wrong with my automation... -- Thanks, Anatoly