From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.advaoptical.com (mail.advaoptical.com [91.217.199.15]) by dpdk.org (Postfix) with ESMTP id AB8103989 for ; Wed, 7 May 2014 14:44:16 +0200 (CEST) Received: from MUC-SRV-MBX2.advaoptical.com ([172.20.1.96]) by muc-vsrv-fsmail.advaoptical.com (8.14.5/8.14.5) with ESMTP id s47CiMC4024281 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=FAIL); Wed, 7 May 2014 14:44:22 +0200 Received: from MUC-SRV-MBX2.advaoptical.com (172.20.1.96) by MUC-SRV-MBX2.advaoptical.com (172.20.1.96) with Microsoft SMTP Server (TLS) id 15.0.913.19; Wed, 7 May 2014 14:44:21 +0200 Received: from MUC-SRV-MBX2.advaoptical.com ([fe80::4c9d:240f:40f7:8e0b]) by MUC-SRV-MBX2.advaoptical.com ([fe80::2d63:66d4:833b:72f0%18]) with mapi id 15.00.0913.011; Wed, 7 May 2014 14:44:21 +0200 From: Samuel Monderer To: "Liu, Jijiang" Thread-Topic: could not l2fwd in DOM0 Thread-Index: Ac9j0vUnb82OilObREO8jzx6VqYofAFadQ8wABuIuhAABX/mEAAMM2EQ Date: Wed, 7 May 2014 12:44:20 +0000 Message-ID: References: <7b60de2c2b904fe78a5ab2f73c08955f@MUC-SRV-MBX2.advaoptical.com> <1ED644BD7E0A5F4091CF203DAFB8E4CC01C6C07E@SHSMSX101.ccr.corp.intel.com> <9f34498d15cd400eb2db76212778c038@MUC-SRV-MBX2.advaoptical.com> In-Reply-To: <9f34498d15cd400eb2db76212778c038@MUC-SRV-MBX2.advaoptical.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [192.168.179.71] Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:5.11.96, 1.0.14, 0.0.0000 definitions=2014-05-07_03:2014-05-07,2014-05-07,1970-01-01 signatures=0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] could not l2fwd in DOM0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 May 2014 12:44:16 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Liu, Jijiang > Sent: Wednesday, May 07, 2014 7:36 AM > To: dev@dpdk.org > Subject: Re: [dpdk-dev] could not l2fwd in DOM0 >=20 > Hi, >=20 > I have checked source codes of xen_create_contiguous_region function in > kernel 3.14, and found the dma_handle cannot be NULL. >=20 > int xen_create_contiguous_region(phys_addr_t pstart, unsigned int order, > unsigned int address_bits, > dma_addr_t *dma_handle) { > unsigned long *in_frames =3D discontig_frames, out_frame; > unsigned long flags; > int success; > unsigned long vstart =3D (unsigned long)phys_to_virt(pstart); > ... > *dma_handle =3D virt_to_machine(vstart).maddr; > return success ? 0 : -ENOMEM; > } >=20 > Thanks > Frank Liu >=20 Thanks Frank, I've changed the code as following but now the kernel module crashes. diff --git a/lib/librte_eal/linuxapp/xen_dom0/dom0_mm_misc.c=A0 b/lib/librte_eal/linuxapp/xen index 87fa3e6..8addc21 100644 --- a/lib/librte_eal/linuxapp/xen_dom0/dom0_mm_misc.c +++ b/lib/librte_eal/linuxapp/xen_dom0/dom0_mm_misc.c @@ -64,6 +64,7 @@ =A0#include =A0#include =A0#include =A0#include =A0#include @@ -309,6 +310,7 @@ dom0_prepare_memsegs(struct memory_info* meminfo, struc= t=A0 dom0_mm_data =A0=A0=A0=A0=A0=A0=A0=A0uint64_t pfn, vstart, vaddr; =A0=A0=A0=A0=A0=A0=A0=A0uint32_t i, num_block, size; =A0=A0=A0=A0=A0=A0=A0=A0int idx; +=A0=A0=A0=A0=A0=A0=A0dma_addr_t dma_handle; =A0=A0=A0=A0=A0=A0=A0=A0/* Allocate 2M memory once */ =A0=A0=A0=A0=A0=A0=A0=A0num_block =3D meminfo->size / 2; @@ -344,7 +346,7 @@ dom0_prepare_memsegs(struct memory_info* meminfo, struc= t=A0 dom0_mm_data =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0* contiguous physical ad= dresses, its maximum size is 2M. =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0*/ =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0if (xen_create_contiguous_r= egion(mm_data->block_info[i].vir_addr, -=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0= =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0DOM0_CONTIG_NUM_ORDER, 0) =3D=3D 0) { +=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0= =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0DOM0_CONTIG_NUM_ORDER, 0, + &dma_handle) =3D=3D 0) { =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0mm_= data->block_info[i].exchange_flag =3D 1; =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0mm_= data->block_info[i].mfn =3D =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0= =A0=A0=A0=A0=A0=A0=A0pfn_to_mfn(mm_data->block_info[i].pfn); Samuel > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Samuel Monderer > Sent: Wednesday, April 30, 2014 1:54 AM > To: dev@dpdk.org > Cc: Shimon Zadok > Subject: [dpdk-dev] could not l2fwd in DOM0 >=20 > Hi, >=20 > First I've encountered a compiling problem when compiling for DOM0 due to > prototype change of the function xen_create_contiguous_region I made the > following changes: >=20 > diff --git a/lib/librte_eal/linuxapp/xen_dom0/dom0_mm_misc.c > b/lib/librte_eal/linuxapp/xen index 87fa3e6..8addc21 100644 > --- a/lib/librte_eal/linuxapp/xen_dom0/dom0_mm_misc.c > +++ b/lib/librte_eal/linuxapp/xen_dom0/dom0_mm_misc.c > @@ -64,6 +64,7 @@ > #include > #include > #include > +//#include >=20 > #include > #include > @@ -309,6 +310,7 @@ dom0_prepare_memsegs(struct memory_info* > meminfo, struct dom0_mm_data > uint64_t pfn, vstart, vaddr; > uint32_t i, num_block, size; > int idx; > + dma_addr_t *dma_handle =3D NULL; >=20 > /* Allocate 2M memory once */ > num_block =3D meminfo->size / 2; > @@ -344,7 +346,7 @@ dom0_prepare_memsegs(struct memory_info* > meminfo, struct dom0_mm_data > * contiguous physical addresses, its maximum size is 2M. > */ > if (xen_create_contiguous_region(mm_data->block_info[i].v= ir_addr, > - DOM0_CONTIG_NUM_ORDER, 0) =3D=3D 0) { > + DOM0_CONTIG_NUM_ORDER, 0, > + dma_handle) =3D=3D 0) { > mm_data->block_info[i].exchange_flag =3D 1; > mm_data->block_info[i].mfn =3D > pfn_to_mfn(mm_data->block_info[i].pfn); >=20 > After that I tried to run l2fwd example and got a segmentation fault >=20 > root@Smart:~/samuelm/dpdk/dpdk# modprobe uio > root@Smart:~/samuelm/dpdk/dpdk# insmod ./x86_64-default-linuxapp- > gcc/kmod/igb_uio.ko > root@Smart:~/samuelm/dpdk/dpdk# insmod ./x86_64-default-linuxapp- > gcc/kmod/rte_dom0_mm.ko > root@Smart:~/samuelm/dpdk/dpdk# cd examples/l2fwd/build/ > root@Smart:~/samuelm/dpdk/dpdk/examples/l2fwd/build# echo 2048 > > /sys/kernel/mm/dom0-mm/memsize-mB/memsize > root@Smart:~/samuelm/dpdk/dpdk/examples/l2fwd/build# ./l2fwd -c 3 -n 4 > --xen-dom0 -- -q 1 -p 3 > EAL: Detected lcore 0 as core 0 on socket 0 > EAL: Detected lcore 1 as core 0 on socket 0 > EAL: Setting up memory... > Segmentation fault > root@Smart:~/samuelm/dpdk/dpdk/examples/l2fwd/build# >=20 > Has anyone already encountered this problem? >=20 > Samuelm