From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 87975A0503; Wed, 18 May 2022 12:26:33 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 55BC840156; Wed, 18 May 2022 12:26:33 +0200 (CEST) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2048.outbound.protection.outlook.com [40.107.243.48]) by mails.dpdk.org (Postfix) with ESMTP id 47972400D6 for ; Wed, 18 May 2022 12:26:32 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=d5zltiPGfoPnqvCcT4pUd1BS4qJWQYmUuUx3KtiK5yIGtFJ1LRWIO3q8xuUjUM0QVUOGndf3uAFwcuiLDEMobS/k5W13f0KagPD6U+EMwhnPth3IGCq/ChkuQq5bJVA+/TxZLDkrpAuAOI8c7Onm0cwSt1e4jLdc1r7VRtQgGBqo3sRaBm4GN9t2U+cP7LN+RR1yKJUJ3mAueo9pWL4UW5f772chhxeXN4mS0e35WdkkDZIMdDvyM0Vv7vFRgUhj7tsRFNDiA5vkzyfkWTfqAOmkQjmYDATJ7/BO3v9qeAchmi19nVV4s5BjKsa3EhA/d7QqVIodHn7CeHdTYgQuQA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jwqCB7MGcYiYVVzArYH67MXwR+0jxEudpmgfmIcEfxQ=; b=UN3yKvuVyioXpl9tTEi6YgRgu36WGB9HSWUKzAeGFVg+W44G+sFHkYobMsqrMT55EyP9zQPTt92iN0oDgoilanmU3AjXp6ss7XUdGq4nDW5GM0EzVmGMRRPwdN5PEGaCd+SsXxPMmYKiXg2lTpfNr3IilXx0mxhZGfnh3t4dErrAk5QvWFRVlYrx80jYLpfEvzWePFsQAXIXmTtjAtfiX58vNby3TPjJruaelh5mu/KbUDXhKRJQ9/fp9FaqYTEB+Q8phKoIqxUFU7Hq0aswtp2bCKU/tfSIsWojKM56wDU13jUtmcQu1ycoReEFsO42IA7LEBfbvkvMrIjal+BCQg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 149.199.80.198) smtp.rcpttodomain=intel.com smtp.mailfrom=xilinx.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=xilinx.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jwqCB7MGcYiYVVzArYH67MXwR+0jxEudpmgfmIcEfxQ=; b=FhvHZySoT4a/jNtaRBJR96gNXDkaJ5pr31pFqvpJ/dCPUErjmEiXy2F6NELzc3vaE9iUMGzTPkg8d648HmPh6nb7asEEWFtRh2VrorEuEq8My9Gl/fw6z1RtuxaAU8Rd0ej8bSOGR5tIl9fzilzexMQWhfAIrF7VW5a1EEctrdo= Received: from SA0PR11CA0006.namprd11.prod.outlook.com (2603:10b6:806:d3::11) by BY5PR02MB6676.namprd02.prod.outlook.com (2603:10b6:a03:212::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.13; Wed, 18 May 2022 10:26:30 +0000 Received: from SN1NAM02FT0008.eop-nam02.prod.protection.outlook.com (2603:10b6:806:d3:cafe::81) by SA0PR11CA0006.outlook.office365.com (2603:10b6:806:d3::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.15 via Frontend Transport; Wed, 18 May 2022 10:26:29 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.80.198) smtp.mailfrom=xilinx.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.80.198 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.80.198; helo=xir-pvapexch02.xlnx.xilinx.com; pr=C Received: from xir-pvapexch02.xlnx.xilinx.com (149.199.80.198) by SN1NAM02FT0008.mail.protection.outlook.com (10.97.5.9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5273.14 via Frontend Transport; Wed, 18 May 2022 10:26:29 +0000 Received: from xir-pvapexch02.xlnx.xilinx.com (172.21.17.17) by xir-pvapexch02.xlnx.xilinx.com (172.21.17.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.14; Wed, 18 May 2022 11:26:28 +0100 Received: from smtp.xilinx.com (172.21.105.198) by xir-pvapexch02.xlnx.xilinx.com (172.21.17.17) with Microsoft SMTP Server id 15.1.2176.14 via Frontend Transport; Wed, 18 May 2022 11:26:28 +0100 Envelope-to: bruce.richardson@intel.com, kai.ji@intel.com, dev@dpdk.org, roy.fan.zhang@intel.com Received: from [172.21.34.28] (port=49496) by smtp.xilinx.com with esmtp (Exim 4.90) (envelope-from ) id 1nrGst-0004jB-LT; Wed, 18 May 2022 11:26:28 +0100 Message-ID: Date: Wed, 18 May 2022 11:26:27 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [dpdk-dev v2 1/2] build: add in option for qat use intel ipsec-mb lib Content-Language: en-US To: Bruce Richardson , Kai Ji CC: , References: <20220407152931.8771-1-roy.fan.zhang@intel.com> <20220517141652.53769-1-kai.ji@intel.com> From: Ferruh Yigit In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c7684d53-a726-4f71-f3b0-08da38b8df3a X-MS-TrafficTypeDiagnostic: BY5PR02MB6676:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: TkWrluC3o9mG+A6TjoYAaHUDJEkYivSS8jEB0sGUiseu8Ld1CcJiFi2JbMWAzhlm5nRL2DXy99gtCJBloAyMe1KMrnwNcq/37dGRkCbBiPTElGM9+M6tU5+voSlt6KhfKx3c68rEhG418uYbyB2Ky4rbyLtMGSFsIcH1ZMXQED74TGPf0SkNKzs8xIsHon/TVNwICEHN83K+h8P8wRmNUkJUZHDSi/C4kxC5Z+cIIanj2zekjw3WuDC6/4ZBUeRVCBzW1BbDup1fknqvx0nPuz1NV1dj1OX2nz9cdE/Tnxf9fjXalgwLNlyh59tjnyWc5crrsTzuGc2eSOsgxQQCoT2FT2NZW7tcLG1l3IuKUIFsDhF2s51zL9fwNJKoIwiGG/xx56jQsitz68eLn8t7o4WXBkZUt4ke/XVwZEMsdYHrEedW70M05BGXFBCHxeImytE85lrEN5Y15x8NbRjg6G+fZAQ5K27G25+Xy6CexE5Spa7MQ8fvLLbkSxbr9LCs7CqOPYhcN12Q5spoYX3TDnwoSRHsNKSeB/M1X5z37umR2qo+xnjYxO6Yj4Af8VVFBVs1E/fxozJlykjN6V+9Omop3N6wI2Mn1BwUtVPgNo01pP5zaYe6URbaTktbqD0tFp3zRc1yC/zzethZ6+xllwZpHqRwUPgxIQqYZujHsvlp7DxqMzDe2NqQ6ZLQfjbPr8kV55MIXGB0Xe2aq4zbWG3wskdnwE/lqJ5W3Uv3gKg= X-Forefront-Antispam-Report: CIP:149.199.80.198; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:xir-pvapexch02.xlnx.xilinx.com; PTR:unknown-80-198.xilinx.com; CAT:NONE; SFS:(13230001)(4636009)(46966006)(40470700004)(36840700001)(31696002)(4326008)(54906003)(110136005)(26005)(426003)(316002)(336012)(7636003)(356005)(40460700003)(8676002)(70206006)(53546011)(70586007)(47076005)(31686004)(36860700001)(2616005)(186003)(2906002)(9786002)(8936002)(36756003)(82310400005)(508600001)(44832011)(5660300002)(50156003)(43740500002); DIR:OUT; SFP:1101; X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 May 2022 10:26:29.3854 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c7684d53-a726-4f71-f3b0-08da38b8df3a X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c; Ip=[149.199.80.198]; Helo=[xir-pvapexch02.xlnx.xilinx.com] X-MS-Exchange-CrossTenant-AuthSource: SN1NAM02FT0008.eop-nam02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR02MB6676 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 5/18/2022 9:04 AM, Bruce Richardson wrote: > On Tue, May 17, 2022 at 10:16:51PM +0800, Kai Ji wrote: >> Add in build option for QAT pmd use intel ipsec-mb lib >> instead openssl for precompute partial hash & aes. >> >> Signed-off-by: Kai Ji >> --- >> drivers/common/qat/meson.build | 12 ++++++++++++ >> meson_options.txt | 2 ++ >> 2 files changed, 14 insertions(+) >> >> diff --git a/drivers/common/qat/meson.build b/drivers/common/qat/meson.build >> index b7027f3164..d6eaff3e0e 100644 >> --- a/drivers/common/qat/meson.build >> +++ b/drivers/common/qat/meson.build >> @@ -35,6 +35,18 @@ if qat_crypto and not libcrypto.found() >> 'missing dependency, libcrypto') >> endif >> >> +if get_option('qat_libipsecmb') >> + IMB_required_ver = '1.0.0' >> + libipsecmb = cc.find_library('IPSec_MB', required: false) >> + if not lib.found() >> + build = false >> + reason = 'missing dependency, "libIPSec_MB"' >> + else >> + ext_deps += libipsecmb >> + dpdk_conf.set('RTE_QAT_LIBIPSECMB', true) >> + endif >> +endif >> + > > In general it's not a good idea for individual drivers to add top-level > meson.build options. If every driver does this for all its options we will > have an unmanageable set of hundreds of options. Unfortunately, though, I > don't see a really good way to replace this with something other than a > build option - I assume it's not just good enough to check which of the > dependencies is found/not-found? Is there some way that this can be a > generic option, that may be applicable to other drivers? Could the option > be instead to prioritize FIPs compatibility? > +1 to not have top level meson option for a driver. Will it work to give priority to intel-ipsec-mb lib, like when ipsec-mb library exists use it, else use openssl?