From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1A932A0562; Wed, 14 Apr 2021 23:34:13 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EB228161D45; Wed, 14 Apr 2021 23:34:12 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mails.dpdk.org (Postfix) with ESMTP id EC2D7161D3B for ; Wed, 14 Apr 2021 23:34:10 +0200 (CEST) IronPort-SDR: L7RoQhUTp4jtAxp9bPC1xUNgGQYnF3TuyoldPEcZdkwv+EqoZFXnYGd9GoRRMGcGt3XIUvxJLD iavxNsBmPc6g== X-IronPort-AV: E=McAfee;i="6200,9189,9954"; a="215238695" X-IronPort-AV: E=Sophos;i="5.82,223,1613462400"; d="scan'208";a="215238695" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Apr 2021 14:34:10 -0700 IronPort-SDR: sOsXCQhAis2oh/QwCZTdbfkwzRj/7Kfe280gu53966gCYpfMYFh6BQpnLduYo7gslBQ82lwLXo HV7V1JTdtoiw== X-IronPort-AV: E=Sophos;i="5.82,223,1613462400"; d="scan'208";a="612248768" Received: from rmenon-desk.amr.corp.intel.com (HELO [10.166.30.253]) ([10.166.30.253]) by fmsmga006-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Apr 2021 14:34:09 -0700 To: Thomas Monjalon , Dmitry Kozlyuk Cc: dev@dpdk.org References: <20210407222249.6729-1-dmitry.kozliuk@gmail.com> <138b06d2-ab7e-704e-5f9f-d369f2490b45@intel.com> <20210413100006.241c42fb@sovereign> <2549908.9JeyF6cTkx@thomas> From: Ranjit Menon Message-ID: Date: Wed, 14 Apr 2021 14:34:07 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101 Thunderbird/68.12.1 MIME-Version: 1.0 In-Reply-To: <2549908.9JeyF6cTkx@thomas> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Subject: Re: [dpdk-dev] [PATCH v9 0/4] eal/windows: do not expose POSIX symbols X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 4/14/2021 2:12 PM, Thomas Monjalon wrote: > 13/04/2021 09:00, Dmitry Kozlyuk: >> Hi Ranjit, >> >> 2021-04-12 21:46 (UTC-0700), Ranjit Menon: >> [...] >>> The change to remove the networking shim breaks l2fwd compilation on >>> Windows, since l2fwd/main.c includes netinet/in.h explicitly. >>> >>> How do you propose we fix this, only for Windows? >> This include is redundant for this file on all platforms, it can be removed. >> Since -Dexamples=all doesn't work on Windows because of missing dependencies, >> I wonder which of them need fixing. > Let's fix the examples which are supported on Windows. > Other examples may require more updates anyway. > Thanks, Thomas. For now, this is only required in l2fwd. Dmitry, can you please include this in your patch 4/4? thanks, ranjit m. >