From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 661DE2C60 for ; Thu, 23 Aug 2018 16:46:07 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 23 Aug 2018 07:46:06 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,278,1531810800"; d="scan'208";a="84321322" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.237.221.56]) ([10.237.221.56]) by orsmga001.jf.intel.com with ESMTP; 23 Aug 2018 07:46:05 -0700 To: Stephen Hemminger , dev@dpdk.org Cc: Stephen Hemminger References: <20180809175008.5787-1-stephen@networkplumber.org> <20180809175008.5787-5-stephen@networkplumber.org> From: Ferruh Yigit Openpgp: preference=signencrypt Message-ID: Date: Thu, 23 Aug 2018 15:46:04 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20180809175008.5787-5-stephen@networkplumber.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 4/4] netvsc: implement tx_done_cleanup X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Aug 2018 14:46:07 -0000 On 8/9/2018 6:50 PM, Stephen Hemminger wrote: > Add tx_done_cleanup ethdev hook to allow application to > control if/when it wants completions to be handled. > > Signed-off-by: Stephen Hemminger > --- > drivers/net/netvsc/hn_ethdev.c | 1 + > drivers/net/netvsc/hn_rndis.c | 2 +- > drivers/net/netvsc/hn_rxtx.c | 26 +++++++++++++++++++++----- > drivers/net/netvsc/hn_var.h | 4 +++- > 4 files changed, 26 insertions(+), 7 deletions(-) > > diff --git a/drivers/net/netvsc/hn_ethdev.c b/drivers/net/netvsc/hn_ethdev.c > index 148e6a33d682..2200ee319f98 100644 > --- a/drivers/net/netvsc/hn_ethdev.c > +++ b/drivers/net/netvsc/hn_ethdev.c > @@ -547,6 +547,7 @@ static const struct eth_dev_ops hn_eth_dev_ops = { > .allmulticast_disable = hn_dev_allmulticast_disable, > .tx_queue_setup = hn_dev_tx_queue_setup, > .tx_queue_release = hn_dev_tx_queue_release, > + .tx_done_cleanup = hn_dev_tx_done_cleanup, This requires "Free Tx mbuf on demand" feature advertised as supported on doc/guides/nics/features/netvsc.ini document. Will add while merging.