From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 943E21B1D5 for ; Wed, 10 Jan 2018 14:28:59 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Jan 2018 05:28:58 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,340,1511856000"; d="scan'208";a="165660763" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.48]) ([10.237.220.48]) by orsmga004.jf.intel.com with ESMTP; 10 Jan 2018 05:28:57 -0800 To: Wei Zhao , dev@dpdk.org Cc: qi.z.zhang@intel.com References: <20180109091858.73889-1-wei.zhao1@intel.com> <20180110021026.84006-1-wei.zhao1@intel.com> From: Ferruh Yigit Message-ID: Date: Wed, 10 Jan 2018 13:28:56 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: <20180110021026.84006-1-wei.zhao1@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v4] net/i40e: move RSS to flow API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Jan 2018 13:29:00 -0000 On 1/10/2018 2:10 AM, Wei Zhao wrote: > Rte_flow actually defined to include RSS, > but till now, RSS is out of rte_flow. > This patch is to move i40e existing RSS to rte_flow. > This patch also enable queue region configuration > using flow API for i40e. > > Signed-off-by: Wei Zhao <...> > @@ -4269,6 +4597,9 @@ i40e_flow_destroy(struct rte_eth_dev *dev, > ret = i40e_flow_add_del_fdir_filter(dev, > &((struct i40e_fdir_filter *)flow->rule)->fdir, 0); > break; > + case RTE_ETH_FILTER_HASH: > + ret = i40e_config_rss_filter_del(dev, > + (struct i40e_rte_flow_rss_conf *)flow->rule); This is causing build error [1], if the fallback is intentional compiler expects a /* Fallthrough */ comment. [1] .../drivers/net/i40e/i40e_flow.c:4601:7: error: this statement may fall through [-Werror=implicit-fallthrough=] ret = i40e_config_rss_filter_del(dev, ~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ (struct i40e_rte_flow_rss_conf *)flow->rule); ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ .../drivers/net/i40e/i40e_flow.c:4603:2: note: here default: ^~~~~~~