From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 95224A0527; Mon, 9 Nov 2020 10:49:58 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 70ED25AB8; Mon, 9 Nov 2020 10:49:57 +0100 (CET) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 4B8515A62 for ; Mon, 9 Nov 2020 10:49:54 +0100 (CET) IronPort-SDR: 1Fw6iy4enXQqBg+KLfyg4Fk9lydJDjuKI/TwLcrk2Yrs0PHsF26M5fx59ITQDQzyyIKxqySEyt f6RFKwiUr/og== X-IronPort-AV: E=McAfee;i="6000,8403,9799"; a="169928659" X-IronPort-AV: E=Sophos;i="5.77,463,1596524400"; d="scan'208";a="169928659" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Nov 2020 01:49:52 -0800 IronPort-SDR: z3WG9xPtZ6a1YlB2ZxwbGca6kdDOZfVxy6KpbSXaiQGzI2K1kEpmX+btbPEdt8/AHHyPM6AJtt WaNif42Q2Lig== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,463,1596524400"; d="scan'208";a="540777865" Received: from fmsmsx604.amr.corp.intel.com ([10.18.126.84]) by orsmga005.jf.intel.com with ESMTP; 09 Nov 2020 01:49:52 -0800 Received: from shsmsx602.ccr.corp.intel.com (10.109.6.142) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Mon, 9 Nov 2020 01:49:51 -0800 Received: from shsmsx601.ccr.corp.intel.com (10.109.6.141) by SHSMSX602.ccr.corp.intel.com (10.109.6.142) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Mon, 9 Nov 2020 17:49:49 +0800 Received: from shsmsx601.ccr.corp.intel.com ([10.109.6.141]) by SHSMSX601.ccr.corp.intel.com ([10.109.6.141]) with mapi id 15.01.1713.004; Mon, 9 Nov 2020 17:49:49 +0800 From: "Zhang, Qi Z" To: "Guo, Jia" , Prateek Agarwal CC: "dev@dpdk.org" Thread-Topic: [PATCH] Made i40 header CPP compatible using extern "C". Library headers work directly in cpp code. Linking errors thrown due to the absence of this change in i40e pmd header does not help in resolving the problem. I needed this header d... Thread-Index: AQHWtOSBwORGcIRXt068p9bxNtqUMKm/VwSQgAA57rA= Date: Mon, 9 Nov 2020 09:49:49 +0000 Message-ID: References: <3f94d598668b4279a2f5fb834124f3e2@intel.com> In-Reply-To: <3f94d598668b4279a2f5fb834124f3e2@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.5.1.3 dlp-product: dlpe-windows x-originating-ip: [10.108.32.68] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] Made i40 header CPP compatible using extern "C". Library headers work directly in cpp code. Linking errors thrown due to the absence of this change in i40e pmd header does not help in resolving the problem. I needed this header d... X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: dev On Behalf Of Guo, Jia > Sent: Monday, November 9, 2020 2:24 PM > To: Prateek Agarwal > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] Made i40 header CPP compatible using exte= rn > "C". Library headers work directly in cpp code. Linking errors thrown due= to the > absence of this change in i40e pmd header does not help in resolving the > problem. I needed this header d... >=20 > Hi, Agarwal >=20 > > -----Original Message----- > > From: Prateek Agarwal > > Sent: Saturday, November 7, 2020 5:01 PM > > To: Guo, Jia > > Cc: dev@dpdk.org; Prateek Agarwal > > Subject: [PATCH] Made i40 header CPP compatible using extern "C". > > Library headers work directly in cpp code. Linking errors thrown due > > to the absence of this change in i40e pmd header does not help in > > resolving the problem. I needed this header directly to use... > > >=20 > Obviously that is not you want to merge the title and the commit log. Ple= ase > separate it and update one new version. Fixed the format during merge as below net/i40e: add extern "C" for cpp compile Add extern "C" in rte_pmd_i40e.h when be compiled with cpp. Applied to dpdk-next-net-intel. Thanks Qi >=20 > > Signed-off-by: Prateek Agarwal > > --- > > drivers/net/i40e/rte_pmd_i40e.h | 8 ++++++++ > > 1 file changed, 8 insertions(+) > > > > diff --git a/drivers/net/i40e/rte_pmd_i40e.h > > b/drivers/net/i40e/rte_pmd_i40e.h index fc3560c28..4cb21c371 100644 > > --- a/drivers/net/i40e/rte_pmd_i40e.h > > +++ b/drivers/net/i40e/rte_pmd_i40e.h > > @@ -14,6 +14,10 @@ > > * > > */ > > > > +#ifdef __cplusplus > > +extern "C" { > > +#endif > > + > > #include > > #include > > #include > > @@ -1130,4 +1134,8 @@ __rte_experimental int > > rte_pmd_i40e_set_switch_dev(uint16_t port_id, struct rte_eth_dev > > *switch_dev); > > > > +#ifdef __cplusplus > > +} > > +#endif > > + > > #endif /* _PMD_I40E_H_ */ > > -- > > 2.25.1