From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: Marvin Liu <yong.liu@intel.com>, tiwei.bie@intel.com
Cc: zhihong.wang@intel.com, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v3 00/11] support in-order feature
Date: Fri, 29 Jun 2018 15:10:24 +0200 [thread overview]
Message-ID: <c7ec5d1f-8948-f10d-ef40-7d8ab6c0e9f7@redhat.com> (raw)
In-Reply-To: <20180628215235.106069-1-yong.liu@intel.com>
Hi,
I was about to apply it, but there are quite a few checkpatch and
git-check-log.sh issues reported.
Could you please resent with this fixed?
Also, I think it would be better to squash the doc patches in relevant
ones.
Thanks,
Maxime
On 06/28/2018 11:52 PM, Marvin Liu wrote:
> In latest virtio-spec, new feature bit VIRTIO_F_IN_ORDER was introduced.
> When this feature has been negotiated, virtio driver will use
> descriptors in ring order: starting from offset 0 in the table, and
> wrapping around at the end of the table. Vhost devices will always use
> descriptors in the same order in which they have been made available.
> This can reduce virtio accesses to used ring.
>
> Based on updated virtio-spec, this series realized IN_ORDER prototype
> in virtio driver. Due to new [RT]x path added into selection, also add
> two new parameters mrg_rx and in_order into virtio-user vdev parameters
> list. This will allow user to configure feature bits thus can impact
> [RT]x path selection.
>
> Performance of virtio user with IN_ORDER feature:
>
> Platform: Purely
> CPU: Intel(R) Xeon(R) Platinum 8160 CPU @ 2.10GHz
> DPDK baseline: 18.05
> Setup: testpmd with vhost vdev + testpmd with virtio vdev
>
> +--------------+----------+----------+---------+
> |Vhost->Virtio |1 Queue |2 Queues |4 Queues |
> +--------------+----------+----------+---------+
> |Inorder |12.0Mpps |24.2Mpps |26.0Mpps |
> |Normal |12.1Mpps |18.5Mpps |18.9Mpps |
> +--------------+----------+----------+---------+
>
> +--------------+----------+----------------+---------+
> |Virtio->Vhost |1 Queue |2 Queues |4 Queues |
> +--------------+----------+----------------+---------+
> |Inorder |13.8Mpps |10.7 ~ 15.2Mpps |11.5Mpps |
> |Normal |13.3Mpps |9.8 ~ 14Mpps |10.5Mpps |
> +--------------+----------+----------------+---------+
>
> +---------+----------+----------------+----------------+
> |Loopback |1 Queue |2 Queues |4 Queues |
> +---------+----------+----------------+----------------+
> |Inorder |7.4Mpps |9.1 ~ 11.6Mpps |10.5 ~ 11.3Mpps |
> +---------+----------+----------------+----------------+
> |Normal |7.5Mpps |7.7 ~ 9.0Mpps |7.6 ~ 7.8Mpps |
> +---------+----------+----------------+----------------+
>
> v3:
> - refine [RT]x function selection logic
> - fix in-order mergable packets index error
> - combine unsupport mask patch
> - doc virtio in-order update
> - fix checkpatch error
>
> v2:
> - merge to latest dpdk-net-virtio
> - not use in_direct for normal xmit packets
> - update available ring for each descriptor
> - clean up IN_ORDER xmit function
> - unmask feature bits when disabled in_order or mgr_rxbuf
> - extract common part between IN_ORDER and normal functions
> - update performance result
>
> Marvin Liu (11):
> vhost: advertise support in-order feature
> net/virtio: add in-order feature bit definition
> net/virtio-user: add unsupported features mask
> net/virtio-user: add mrg_rxbuf and in_order vdev parameters
> net/virtio: free in-order descriptors before device start
> net/virtio: extract common part for in-order functions
> net/virtio: support in-order Rx and Tx
> net/virtio: add in-order Rx/Tx into selection
> net/virtio: advertise support in-order feature
> doc: add mrg_rxbuf and in_order parameters for virtio device
> doc: add in-order funciton for virtio device
>
> doc/guides/nics/virtio.rst | 27 +-
> drivers/net/virtio/virtio_ethdev.c | 29 +-
> drivers/net/virtio/virtio_ethdev.h | 7 +
> drivers/net/virtio/virtio_pci.h | 8 +
> drivers/net/virtio/virtio_rxtx.c | 635 ++++++++++++++++--
> .../net/virtio/virtio_user/virtio_user_dev.c | 26 +-
> .../net/virtio/virtio_user/virtio_user_dev.h | 4 +-
> drivers/net/virtio/virtio_user_ethdev.c | 45 +-
> drivers/net/virtio/virtqueue.c | 8 +
> drivers/net/virtio/virtqueue.h | 2 +
> lib/librte_vhost/socket.c | 6 +
> lib/librte_vhost/vhost.h | 10 +-
> 12 files changed, 723 insertions(+), 84 deletions(-)
>
next prev parent reply other threads:[~2018-06-29 13:10 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-28 21:52 Marvin Liu
2018-06-28 21:52 ` [dpdk-dev] [PATCH v3 01/11] vhost: advertise " Marvin Liu
2018-06-28 14:32 ` Maxime Coquelin
2018-06-28 21:52 ` [dpdk-dev] [PATCH v3 02/11] net/virtio: add in-order feature bit definition Marvin Liu
2018-06-28 14:33 ` Maxime Coquelin
2018-06-28 21:52 ` [dpdk-dev] [PATCH v3 03/11] net/virtio-user: add unsupported features mask Marvin Liu
2018-06-28 14:34 ` Maxime Coquelin
2018-06-28 21:52 ` [dpdk-dev] [PATCH v3 04/11] net/virtio-user: add mrg_rxbuf and in_order vdev parameters Marvin Liu
2018-06-28 14:43 ` Maxime Coquelin
2018-06-28 21:52 ` [dpdk-dev] [PATCH v3 05/11] net/virtio: free in-order descriptors before device start Marvin Liu
2018-06-28 14:45 ` Maxime Coquelin
2018-06-28 21:52 ` [dpdk-dev] [PATCH v3 06/11] net/virtio: extract common part for in-order functions Marvin Liu
2018-06-28 14:48 ` Maxime Coquelin
2018-06-28 21:52 ` [dpdk-dev] [PATCH v3 07/11] net/virtio: support in-order Rx and Tx Marvin Liu
2018-06-28 15:08 ` Maxime Coquelin
2018-06-28 21:52 ` [dpdk-dev] [PATCH v3 08/11] net/virtio: add in-order Rx/Tx into selection Marvin Liu
2018-06-28 15:16 ` Maxime Coquelin
2018-06-28 15:39 ` Liu, Yong
2018-06-29 8:04 ` Maxime Coquelin
2018-06-30 2:42 ` Tiwei Bie
2018-06-28 21:52 ` [dpdk-dev] [PATCH v3 09/11] net/virtio: advertise support in-order feature Marvin Liu
2018-06-28 15:16 ` Maxime Coquelin
2018-06-28 21:52 ` [dpdk-dev] [PATCH v3 10/11] doc: add mrg_rxbuf and in_order parameters for virtio device Marvin Liu
2018-06-28 15:17 ` Maxime Coquelin
2018-06-28 21:52 ` [dpdk-dev] [PATCH v3 11/11] doc: add in-order funciton " Marvin Liu
2018-06-28 15:17 ` Maxime Coquelin
2018-06-29 13:10 ` Maxime Coquelin [this message]
2018-06-30 16:07 ` [dpdk-dev] [PATCH v3 00/11] support in-order feature Liu, Yong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c7ec5d1f-8948-f10d-ef40-7d8ab6c0e9f7@redhat.com \
--to=maxime.coquelin@redhat.com \
--cc=dev@dpdk.org \
--cc=tiwei.bie@intel.com \
--cc=yong.liu@intel.com \
--cc=zhihong.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).