From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by dpdk.org (Postfix) with ESMTP id 028DC5F16 for ; Fri, 29 Jun 2018 15:10:27 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 682B6818F037; Fri, 29 Jun 2018 13:10:27 +0000 (UTC) Received: from [10.36.112.15] (unknown [10.36.112.15]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 653CD21565E1; Fri, 29 Jun 2018 13:10:26 +0000 (UTC) To: Marvin Liu , tiwei.bie@intel.com Cc: zhihong.wang@intel.com, dev@dpdk.org References: <20180628215235.106069-1-yong.liu@intel.com> From: Maxime Coquelin Message-ID: Date: Fri, 29 Jun 2018 15:10:24 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <20180628215235.106069-1-yong.liu@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.8]); Fri, 29 Jun 2018 13:10:27 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.8]); Fri, 29 Jun 2018 13:10:27 +0000 (UTC) for IP:'10.11.54.6' DOMAIN:'int-mx06.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'maxime.coquelin@redhat.com' RCPT:'' Subject: Re: [dpdk-dev] [PATCH v3 00/11] support in-order feature X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 29 Jun 2018 13:10:28 -0000 Hi, I was about to apply it, but there are quite a few checkpatch and git-check-log.sh issues reported. Could you please resent with this fixed? Also, I think it would be better to squash the doc patches in relevant ones. Thanks, Maxime On 06/28/2018 11:52 PM, Marvin Liu wrote: > In latest virtio-spec, new feature bit VIRTIO_F_IN_ORDER was introduced. > When this feature has been negotiated, virtio driver will use > descriptors in ring order: starting from offset 0 in the table, and > wrapping around at the end of the table. Vhost devices will always use > descriptors in the same order in which they have been made available. > This can reduce virtio accesses to used ring. > > Based on updated virtio-spec, this series realized IN_ORDER prototype > in virtio driver. Due to new [RT]x path added into selection, also add > two new parameters mrg_rx and in_order into virtio-user vdev parameters > list. This will allow user to configure feature bits thus can impact > [RT]x path selection. > > Performance of virtio user with IN_ORDER feature: > > Platform: Purely > CPU: Intel(R) Xeon(R) Platinum 8160 CPU @ 2.10GHz > DPDK baseline: 18.05 > Setup: testpmd with vhost vdev + testpmd with virtio vdev > > +--------------+----------+----------+---------+ > |Vhost->Virtio |1 Queue |2 Queues |4 Queues | > +--------------+----------+----------+---------+ > |Inorder |12.0Mpps |24.2Mpps |26.0Mpps | > |Normal |12.1Mpps |18.5Mpps |18.9Mpps | > +--------------+----------+----------+---------+ > > +--------------+----------+----------------+---------+ > |Virtio->Vhost |1 Queue |2 Queues |4 Queues | > +--------------+----------+----------------+---------+ > |Inorder |13.8Mpps |10.7 ~ 15.2Mpps |11.5Mpps | > |Normal |13.3Mpps |9.8 ~ 14Mpps |10.5Mpps | > +--------------+----------+----------------+---------+ > > +---------+----------+----------------+----------------+ > |Loopback |1 Queue |2 Queues |4 Queues | > +---------+----------+----------------+----------------+ > |Inorder |7.4Mpps |9.1 ~ 11.6Mpps |10.5 ~ 11.3Mpps | > +---------+----------+----------------+----------------+ > |Normal |7.5Mpps |7.7 ~ 9.0Mpps |7.6 ~ 7.8Mpps | > +---------+----------+----------------+----------------+ > > v3: > - refine [RT]x function selection logic > - fix in-order mergable packets index error > - combine unsupport mask patch > - doc virtio in-order update > - fix checkpatch error > > v2: > - merge to latest dpdk-net-virtio > - not use in_direct for normal xmit packets > - update available ring for each descriptor > - clean up IN_ORDER xmit function > - unmask feature bits when disabled in_order or mgr_rxbuf > - extract common part between IN_ORDER and normal functions > - update performance result > > Marvin Liu (11): > vhost: advertise support in-order feature > net/virtio: add in-order feature bit definition > net/virtio-user: add unsupported features mask > net/virtio-user: add mrg_rxbuf and in_order vdev parameters > net/virtio: free in-order descriptors before device start > net/virtio: extract common part for in-order functions > net/virtio: support in-order Rx and Tx > net/virtio: add in-order Rx/Tx into selection > net/virtio: advertise support in-order feature > doc: add mrg_rxbuf and in_order parameters for virtio device > doc: add in-order funciton for virtio device > > doc/guides/nics/virtio.rst | 27 +- > drivers/net/virtio/virtio_ethdev.c | 29 +- > drivers/net/virtio/virtio_ethdev.h | 7 + > drivers/net/virtio/virtio_pci.h | 8 + > drivers/net/virtio/virtio_rxtx.c | 635 ++++++++++++++++-- > .../net/virtio/virtio_user/virtio_user_dev.c | 26 +- > .../net/virtio/virtio_user/virtio_user_dev.h | 4 +- > drivers/net/virtio/virtio_user_ethdev.c | 45 +- > drivers/net/virtio/virtqueue.c | 8 + > drivers/net/virtio/virtqueue.h | 2 + > lib/librte_vhost/socket.c | 6 + > lib/librte_vhost/vhost.h | 10 +- > 12 files changed, 723 insertions(+), 84 deletions(-) >