From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C314BA0032; Wed, 6 Jul 2022 18:15:15 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 94C5840687; Wed, 6 Jul 2022 18:15:15 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id DD04040156 for ; Wed, 6 Jul 2022 18:15:13 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1657124113; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yFOHeRKd5LtwJ/bNcvJ26IUautO1OdsdThef8lXA/68=; b=h34gTDGZAjxLtbMlijucw1T8+7fASJWUFPRtL5dVStGiB6DR7xYX2aVYXOQj5Yib/uaotU 5x0a3wioqIaKpGkgyk/t1KZlnDMXojtiHxYvVPm4nOg07XaHKg7vNX65UUk9Ai+irHlQmP g5BA3Ltg15PkQDt8jMfmiOYSRZtvqAk= Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-527-V31Zeu9IMMeZ-IsFGH2JZw-1; Wed, 06 Jul 2022 12:15:12 -0400 X-MC-Unique: V31Zeu9IMMeZ-IsFGH2JZw-1 Received: by mail-qt1-f197.google.com with SMTP id f14-20020ac8068e000000b0031e899fabdcso4142578qth.5 for ; Wed, 06 Jul 2022 09:15:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=yFOHeRKd5LtwJ/bNcvJ26IUautO1OdsdThef8lXA/68=; b=6mWiqJMgQqpdvDACMFV2p9cQjo6vkEtKe9CIL2dHPVVfBv2jKwisj0HR+tuTAdo77M GeVDFi0Q2C+u2/lI1ROi9/DIIzLZBsdBF2yU2ICln9BLEzkRCfvl1IEUHA5AZbKQwE+4 Y+qMbfiNt0dWfbvXVSq/g2kexldqk3tmdB1lkh1g9KTPIGqas7sca9ET/g1Jj8sep9K1 RLVubwa31CDcGOZODMWcX/RystA4VMKcWv4V196WdNRvNTdF08Ph/jnBtgkZTYmteryg sYZVE7pyt3douDdyN2UG0+AopZvGqxUv6dUe2cKBBWNNjMbhtrpXIc9asEijkcC1AD2C bNXg== X-Gm-Message-State: AJIora9oBVJxK1X8KE1Xnrw5AhHNIg24FTJJPSHvvgmdBGdsWTRaIqZF Z/G/iIhUyS8CFQWhYSECDOznoq3rP3Us52JJZFnTKsclJPXcn3LBCDbrDDHNvkgYlp2xDiO+TVN 54S8= X-Received: by 2002:a05:6214:5010:b0:470:3e52:d893 with SMTP id jo16-20020a056214501000b004703e52d893mr37172610qvb.24.1657124111727; Wed, 06 Jul 2022 09:15:11 -0700 (PDT) X-Google-Smtp-Source: AGRyM1uCjkS6D6NaXA5+juF3Y+WUBZi5a+K/+frRNaOtkoBJiUjYUOvUWdDiNqdri+FRfJ6VX/rSUQ== X-Received: by 2002:a05:6214:5010:b0:470:3e52:d893 with SMTP id jo16-20020a056214501000b004703e52d893mr37172580qvb.24.1657124111433; Wed, 06 Jul 2022 09:15:11 -0700 (PDT) Received: from localhost.localdomain (024-205-208-113.res.spectrum.com. [24.205.208.113]) by smtp.gmail.com with ESMTPSA id w4-20020a05620a424400b006af08c26774sm30736454qko.47.2022.07.06.09.15.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 06 Jul 2022 09:15:09 -0700 (PDT) Subject: Re: [PATCH v4 4/7] drivers/baseband: update PMDs to expose queue per operation To: Nicolas Chautru , dev@dpdk.org, thomas@monjalon.net, gakhil@marvell.com, hemant.agrawal@nxp.com Cc: maxime.coquelin@redhat.com, mdr@ashroe.eu, bruce.richardson@intel.com, david.marchand@redhat.com, stephen@networkplumber.org References: <1655491040-183649-6-git-send-email-nicolas.chautru@intel.com> <1657067022-54373-1-git-send-email-nicolas.chautru@intel.com> <1657067022-54373-5-git-send-email-nicolas.chautru@intel.com> From: Tom Rix Message-ID: Date: Wed, 6 Jul 2022 09:15:05 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <1657067022-54373-5-git-send-email-nicolas.chautru@intel.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=trix@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 7/5/22 5:23 PM, Nicolas Chautru wrote: > Add support in existing bbdev PMDs for the explicit number of queue > and priority for each operation type configured on the device. > > Signed-off-by: Nicolas Chautru > --- > drivers/baseband/acc100/rte_acc100_pmd.c | 29 +++++++++++++--------- > drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c | 8 ++++++ > drivers/baseband/fpga_lte_fec/fpga_lte_fec.c | 8 ++++++ > drivers/baseband/la12xx/bbdev_la12xx.c | 7 ++++++ > drivers/baseband/turbo_sw/bbdev_turbo_software.c | 11 ++++++++ > 5 files changed, 51 insertions(+), 12 deletions(-) > > diff --git a/drivers/baseband/acc100/rte_acc100_pmd.c b/drivers/baseband/acc100/rte_acc100_pmd.c > index 17ba798..d568d0d 100644 > --- a/drivers/baseband/acc100/rte_acc100_pmd.c > +++ b/drivers/baseband/acc100/rte_acc100_pmd.c > @@ -966,6 +966,7 @@ > struct rte_bbdev_driver_info *dev_info) > { > struct acc100_device *d = dev->data->dev_private; > + int i; > > static const struct rte_bbdev_op_cap bbdev_capabilities[] = { > { > @@ -1062,19 +1063,23 @@ > fetch_acc100_config(dev); > dev_info->device_status = RTE_BBDEV_DEV_NOT_SUPPORTED; > > - /* This isn't ideal because it reports the maximum number of queues but > - * does not provide info on how many can be uplink/downlink or different > - * priorities > - */ > - dev_info->max_num_queues = > - d->acc100_conf.q_dl_5g.num_aqs_per_groups * > - d->acc100_conf.q_dl_5g.num_qgroups + > - d->acc100_conf.q_ul_5g.num_aqs_per_groups * > - d->acc100_conf.q_ul_5g.num_qgroups + > - d->acc100_conf.q_dl_4g.num_aqs_per_groups * > - d->acc100_conf.q_dl_4g.num_qgroups + > - d->acc100_conf.q_ul_4g.num_aqs_per_groups * > + /* Expose number of queues */ > + dev_info->num_queues[RTE_BBDEV_OP_NONE] = 0; > + dev_info->num_queues[RTE_BBDEV_OP_TURBO_DEC] = d->acc100_conf.q_ul_4g.num_aqs_per_groups * > d->acc100_conf.q_ul_4g.num_qgroups; > + dev_info->num_queues[RTE_BBDEV_OP_TURBO_ENC] = d->acc100_conf.q_dl_4g.num_aqs_per_groups * > + d->acc100_conf.q_dl_4g.num_qgroups; > + dev_info->num_queues[RTE_BBDEV_OP_LDPC_DEC] = d->acc100_conf.q_ul_5g.num_aqs_per_groups * > + d->acc100_conf.q_ul_5g.num_qgroups; > + dev_info->num_queues[RTE_BBDEV_OP_LDPC_ENC] = d->acc100_conf.q_dl_5g.num_aqs_per_groups * > + d->acc100_conf.q_dl_5g.num_qgroups; > + dev_info->queue_priority[RTE_BBDEV_OP_TURBO_DEC] = d->acc100_conf.q_ul_4g.num_qgroups; > + dev_info->queue_priority[RTE_BBDEV_OP_TURBO_ENC] = d->acc100_conf.q_dl_4g.num_qgroups; > + dev_info->queue_priority[RTE_BBDEV_OP_LDPC_DEC] = d->acc100_conf.q_ul_5g.num_qgroups; > + dev_info->queue_priority[RTE_BBDEV_OP_LDPC_ENC] = d->acc100_conf.q_dl_5g.num_qgroups; > + dev_info->max_num_queues = 0; > + for (i = RTE_BBDEV_OP_TURBO_DEC; i < RTE_BBDEV_OP_LDPC_ENC; i++) should this be i <=  ? > + dev_info->max_num_queues += dev_info->num_queues[i]; > dev_info->queue_size_lim = ACC100_MAX_QUEUE_DEPTH; > dev_info->hardware_accelerated = true; > dev_info->max_dl_queue_priority = > diff --git a/drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c b/drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c > index 57b12af..b4982af 100644 > --- a/drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c > +++ b/drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c > @@ -379,6 +379,14 @@ > if (hw_q_id != FPGA_INVALID_HW_QUEUE_ID) > dev_info->max_num_queues++; > } > + /* Expose number of queue per operation type */ > + dev_info->num_queues[RTE_BBDEV_OP_NONE] = 0; > + dev_info->num_queues[RTE_BBDEV_OP_TURBO_DEC] = 0; > + dev_info->num_queues[RTE_BBDEV_OP_TURBO_ENC] = 0; > + dev_info->num_queues[RTE_BBDEV_OP_LDPC_DEC] = dev_info->max_num_queues / 2; > + dev_info->num_queues[RTE_BBDEV_OP_LDPC_ENC] = dev_info->max_num_queues / 2; > + dev_info->queue_priority[RTE_BBDEV_OP_LDPC_DEC] = 1; > + dev_info->queue_priority[RTE_BBDEV_OP_LDPC_ENC] = 1; > } > > /** > diff --git a/drivers/baseband/fpga_lte_fec/fpga_lte_fec.c b/drivers/baseband/fpga_lte_fec/fpga_lte_fec.c > index 2a330c4..dc7f479 100644 > --- a/drivers/baseband/fpga_lte_fec/fpga_lte_fec.c > +++ b/drivers/baseband/fpga_lte_fec/fpga_lte_fec.c > @@ -655,6 +655,14 @@ struct __rte_cache_aligned fpga_queue { > if (hw_q_id != FPGA_INVALID_HW_QUEUE_ID) > dev_info->max_num_queues++; > } > + /* Expose number of queue per operation type */ > + dev_info->num_queues[RTE_BBDEV_OP_NONE] = 0; > + dev_info->num_queues[RTE_BBDEV_OP_TURBO_DEC] = dev_info->max_num_queues / 2; > + dev_info->num_queues[RTE_BBDEV_OP_TURBO_ENC] = dev_info->max_num_queues / 2; > + dev_info->num_queues[RTE_BBDEV_OP_LDPC_DEC] = 0; > + dev_info->num_queues[RTE_BBDEV_OP_LDPC_ENC] = 0; > + dev_info->queue_priority[RTE_BBDEV_OP_TURBO_DEC] = 1; > + dev_info->queue_priority[RTE_BBDEV_OP_TURBO_ENC] = 1; > } > > /** > diff --git a/drivers/baseband/la12xx/bbdev_la12xx.c b/drivers/baseband/la12xx/bbdev_la12xx.c > index c1f88c6..e99ea9a 100644 > --- a/drivers/baseband/la12xx/bbdev_la12xx.c > +++ b/drivers/baseband/la12xx/bbdev_la12xx.c > @@ -102,6 +102,13 @@ struct bbdev_la12xx_params { > dev_info->min_alignment = 64; > dev_info->device_status = RTE_BBDEV_DEV_NOT_SUPPORTED; > > + dev_info->num_queues[RTE_BBDEV_OP_NONE] = 0; > + dev_info->num_queues[RTE_BBDEV_OP_TURBO_DEC] = 0; > + dev_info->num_queues[RTE_BBDEV_OP_TURBO_ENC] = 0; > + dev_info->num_queues[RTE_BBDEV_OP_LDPC_DEC] = LA12XX_MAX_QUEUES / 2; > + dev_info->num_queues[RTE_BBDEV_OP_LDPC_ENC] = LA12XX_MAX_QUEUES / 2; > + dev_info->queue_priority[RTE_BBDEV_OP_LDPC_DEC] = 1; > + dev_info->queue_priority[RTE_BBDEV_OP_LDPC_ENC] = 1; > rte_bbdev_log_debug("got device info from %u", dev->data->dev_id); > } > > diff --git a/drivers/baseband/turbo_sw/bbdev_turbo_software.c b/drivers/baseband/turbo_sw/bbdev_turbo_software.c > index dbc5524..647e706 100644 > --- a/drivers/baseband/turbo_sw/bbdev_turbo_software.c > +++ b/drivers/baseband/turbo_sw/bbdev_turbo_software.c > @@ -256,6 +256,17 @@ struct turbo_sw_queue { > dev_info->data_endianness = RTE_LITTLE_ENDIAN; > dev_info->device_status = RTE_BBDEV_DEV_NOT_SUPPORTED; > > + const struct rte_bbdev_op_cap *op_cap = bbdev_capabilities; Should this be done through dev instead of assigning directly ? Tom > + int num_op_type = 0; > + for (; op_cap->type != RTE_BBDEV_OP_NONE; ++op_cap) > + num_op_type++; > + op_cap = bbdev_capabilities; > + if (num_op_type > 0) { > + int num_queue_per_type = dev_info->max_num_queues / num_op_type; > + for (; op_cap->type != RTE_BBDEV_OP_NONE; ++op_cap) > + dev_info->num_queues[op_cap->type] = num_queue_per_type; > + } > + > rte_bbdev_log_debug("got device info from %u\n", dev->data->dev_id); > } >