From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B8FAAA00C4; Sun, 6 Nov 2022 10:40:28 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5F60840691; Sun, 6 Nov 2022 10:40:28 +0100 (CET) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by mails.dpdk.org (Postfix) with ESMTP id AF08E4003C; Sun, 6 Nov 2022 10:40:26 +0100 (CET) Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 3A74062; Sun, 6 Nov 2022 12:40:26 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 3A74062 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru; s=default; t=1667727626; bh=ylEA0G2+nAz3LuyUD7pO0YvQNOk09OHojIc/t6XXaRE=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=Y3+uNvFiZPWbQtIn7t+GtkbKTpHgBJ8QPp3A39SHnHpdcQUN7NbS4U5Zz/eLzex7r NKkfVsJapbVM55DfNuPA4IghNtpPustmnJuxPMnCKjzlrP5UIw33EKDfkB/RUb3puW Yz9IZ9KnSyQPD0a7P9ehid9NT49AdZEdrLvsqlCs= Message-ID: Date: Sun, 6 Nov 2022 12:40:25 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Subject: Re: [PATCH] net/bonding: set initial value of descriptor count alignment Content-Language: en-US To: "Li, WeiyuanX" , "humin (Q)" , Ivan Malov , "dev@dpdk.org" Cc: Chas Williams , Hari Kumar Vemula , "stable@dpdk.org" References: <20221031131744.2340150-1-ivan.malov@oktetlabs.ru> From: Andrew Rybchenko Organization: OKTET Labs In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 11/2/22 10:07, Li, WeiyuanX wrote: >> -----Original Message----- >> From: humin (Q) >> Sent: Tuesday, November 1, 2022 10:21 AM >> To: Ivan Malov ; dev@dpdk.org >> Cc: Li, WeiyuanX ; Chas Williams ; >> Hari Kumar Vemula ; stable@dpdk.org; >> Andrew Rybchenko >> Subject: Re: [PATCH] net/bonding: set initial value of descriptor count >> alignment >> >> Acked-by: Min Hu (Connor) >> >> 在 2022/10/31 21:17, Ivan Malov 写道: >>> The driver had once been broken by patch [1] looking to have a >>> non-zero "nb_max" value in a use case not involving adding any >>> back-end ports. That was addressed afterwards ([2]). But, as per >>> report [3], similar test cases exist which attempt to setup Rx queues >>> on a void bond before attaching any back-end ports. Rx queue setup, in >>> turn, involves device info get API invocation, and one of the checks >>> on received data causes an exception (division by zero). The >>> "nb_align" value is indeed zero at that time, but, as explained in >>> [2], such test cases are totally incorrect since a bond device must >>> have at least one back-end port plugged before any ethdev APIs can be >>> used. >>> >>> Once again, to avoid any problems with fixing the test cases, this >>> patch adjusts the bond PMD itself to workaround the bug. >>> >>> [1] commit 5be3b40fea60 ("net/bonding: fix values of descriptor >>> limits") [2] commit d03c0e83cc00 ("net/bonding: fix descriptor limit >>> reporting") [3] https://bugs.dpdk.org/show_bug.cgi?id=1118 >>> >>> Fixes: d03c0e83cc00 ("net/bonding: fix descriptor limit reporting") >>> Cc: stable@dpdk.org >>> >>> Signed-off-by: Ivan Malov >>> Reviewed-by: Andrew Rybchenko >>> --- > Tested-by: Weiyuan Li > > This patch needs to be applied additionally https://patches.dpdk.org/project/dpdk/patch/20221101161853.2702425-1-ivan.malov@oktetlabs.ru/ can be verified to pass > Applied to dpdk-next-net/main, thanks.