From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by inbox.dpdk.org (Postfix) with ESMTP id EF949A0546;
Thu, 16 Jul 2020 09:43:27 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id ABC0D1BED0;
Thu, 16 Jul 2020 09:43:22 +0200 (CEST)
Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com
[205.139.110.61]) by dpdk.org (Postfix) with ESMTP id C91E21BEA7
for <dev@dpdk.org>; Thu, 16 Jul 2020 09:43:17 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
s=mimecast20190719; t=1594885397;
h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
to:to:cc:cc:mime-version:mime-version:content-type:content-type:
content-transfer-encoding:content-transfer-encoding:
in-reply-to:in-reply-to:references:references:autocrypt:autocrypt;
bh=gCvKzOAn1GDN8Vai7Coz1jgsBoLf0Dpd7Jtn5PQo74k=;
b=XiWpflejTgBeOmLDvnokOoxS8dMJEhG7pVuECGiYVMzBII8tutfZ3q4MGdfLPQCqvGXvHk
hMW16c8bKjim/HYL7s1HjAvrTCeqQbJQrg37/vS0gdXSZslVRYTH4GP4jCwCrjcrgsshl7
TSTldzktdyOUHB1aMAhQtwfkMu7tJmg=
Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com
[209.85.128.71]) (Using TLS) by relay.mimecast.com with ESMTP id
us-mta-276-sT0jxf3tMCqprTuDz-Lmmg-1; Thu, 16 Jul 2020 03:43:13 -0400
X-MC-Unique: sT0jxf3tMCqprTuDz-Lmmg-1
Received: by mail-wm1-f71.google.com with SMTP id 65so4469490wmd.8
for <dev@dpdk.org>; Thu, 16 Jul 2020 00:43:13 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20161025;
h=x-gm-message-state:subject:to:cc:references:from:autocrypt
:message-id:date:user-agent:mime-version:in-reply-to
:content-language:content-transfer-encoding;
bh=gCvKzOAn1GDN8Vai7Coz1jgsBoLf0Dpd7Jtn5PQo74k=;
b=AdPM+zHblswEoLS3HmDyiuOfGDNqQNLO9kufPgczPZ1JyEhSQyGUIj2mSps0cPp6vD
Bm0qCMAIX0uBjFcoMDx9fS522viXOUZv6lgWsoL/VU5Goyu4++PVRjrP5H6Gkwqdr6Dh
YEPeQ+SAJLkDYxTV0dF3iXYD3tPpgSjS9h/+9QFq8KWcVor4ngFNAqglpXsPKSvL/7kn
hXuBqUesB3auZAbjT7FyDCPt4o0MJ8apyUeMiRrPz1EcKgAK+cHMmwDVna+4BnZR6w/X
CVLUYHo0HjruxH1mQeI4IlVzw4ro/XGmIu6Otk8uyjWfKFD+GsQLicz+5QCyC2Ngv6Sw
eRfw==
X-Gm-Message-State: AOAM5331nQYxplo8w5MHvK3ggVjo3sLPcmbxqqHQvHPKSk/jWhbhIRnF
rGPmtb3UHnXq1QKpk0pkHYB/2R83367WpLhH1fCe53Srx2PWviwb85Ky85rWLAL2uPmBA6p22rn
81G4=
X-Received: by 2002:adf:f5ce:: with SMTP id k14mr3575260wrp.234.1594885392470;
Thu, 16 Jul 2020 00:43:12 -0700 (PDT)
X-Google-Smtp-Source: ABdhPJwayyFrIq2MU5Z0KSsVKKFfbVAfFeSYWZXibhSW3i+Xz5ak3mCCO1YIwj/CMUlSZMNN3j9POA==
X-Received: by 2002:adf:f5ce:: with SMTP id k14mr3575244wrp.234.1594885392262;
Thu, 16 Jul 2020 00:43:12 -0700 (PDT)
Received: from amorenoz.users.ipa.redhat.com ([92.176.159.3])
by smtp.gmail.com with ESMTPSA id s15sm6986166wmj.41.2020.07.16.00.43.10
(version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
Thu, 16 Jul 2020 00:43:11 -0700 (PDT)
To: "Xia, Chenbo" <chenbo.xia@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "maxime.coquelin@redhat.com" <maxime.coquelin@redhat.com>,
"Wang, Zhihong" <zhihong.wang@intel.com>
References: <20200715171828.95887-1-amorenoz@redhat.com>
<20200715171828.95887-4-amorenoz@redhat.com>
<MN2PR11MB406317295EF7C30F07950CDA9C7F0@MN2PR11MB4063.namprd11.prod.outlook.com>
From: Adrian Moreno <amorenoz@redhat.com>
Autocrypt: addr=amorenoz@redhat.com; prefer-encrypt=mutual; keydata=
mQENBF1syNUBCADQ9dk3fDMxOZ/+OQpmbanpodYxEv8IRtDz8PXw8YX7UyGfozOpLjQ8Fftj
ZxuubYNbt2QVbSgviFilFdNWu2eTnN/JaGtfhmTOLPVoakkPHZF8lbgImMoch7L0fH8wN2IM
KPxQyPNlX+K9FD5brHsV1lfe1TwAxmhcvLW8yNrVq+9eDIDykxc7tH4exIqXgZroahGxMHKy
c8Ti2kJka/t6pDfRaY0J+6J7I1nrn6GXXSMNA45EH8+0N/QlcXhP3rfftnoPeVmpjswzvJqY
FNjf/Q5VPLx7RX0Qx+y8mMB2JcChV5Bl7D7x5EUbItj6+Sy7QfOgCtPegk9HSrBCNYaLABEB
AAG0I0FkcmlhbiBNb3Jlbm8gPGFtb3Jlbm96QHJlZGhhdC5jb20+iQFUBBMBCAA+FiEEogUD
gihhmbOPHy26d5C5fbYeFsUFAl1syNUCGwMFCQHhM4AFCwkIBwIGFQoJCAsCBBYCAwECHgEC
F4AACgkQd5C5fbYeFsX7qwgArGHSkX+ILNcujkVzjTG4OtkpJMPFlkn/1PxSEKD0jLuzx14B
COzpg/Mqj3Re/QBuOas+ci9bsUA0/2nORtmmEBvzDOJpR5FH1jaGCx8USlY4WM6QqEDNZgTw
hsy9KhjFzFjMk+oo3HyItXA+Uq9yrRBTjNBGTXxezMRcMuUZ4MIAfY0IRBglL2BufiuL43jD
BvTENNFLoQ/wFV7qkFWSkv+8IjTsxr7M6XUo1QLd29Hn0dvwssN579HL1+BP46i2REpzeBEG
L75iVChi+YnIQQNMJ9NYarVabZx4Y1Gn8+7B/1SNArDV+IDgnYgt7E58otoV2Ap310dmtuvE
VbxGpbkBDQRdbMjVAQgAqyp9oA7WDu7/Y9T4Ommt69iZx8os7shUIfdgPEy5xrcPn6qGwN1/
HQ4j8nWfBG9uuX1X0RXUZIUEtYTxtED4yaCQMTqDUf9cBAwAA2mYxBfoiNYx8YqxM+sT0/J4
2qmDd+y+20UR4yzHE8AmIbspTzDFIJDAi+jKSR8F355z0sfW7CIMDC4ZWrPsskjEy1YN/U10
r6tRRH1kNyrCSbTG0d9MtcQO58h7DLXuzUhErB+BtG52A04t5cweIJTJC+koV5XPeilzlHnm
RFoj0ncruGa9Odns21BNt3cy9wLfK+aUnWuAB1uc6bJGQPiAwjkilz7g7MBRUuIQ2Zt7HGLc
SwARAQABiQE8BBgBCAAmFiEEogUDgihhmbOPHy26d5C5fbYeFsUFAl1syNUCGwwFCQHhM4AA
CgkQd5C5fbYeFsUlSwf8CH+u/IXaE7WeWxwFkMaORfW8cM4q0xrL3M6yRGuQNW+kMjnrvK9U
J9G+L1/5uTRbDQ/4LdoKqize8LjehA+iF6ba4t9Npikh8fLKWgaJfQ/hPhH4C3O5gWPOLTW6
ylGxiuER4CdFwQIoAMMslhFA7G+teeOKBq36E+1+zrybI6Xy1UBSlpDK9j4CtTnMQejjuSQb
Qhle+l8VroaUHq869wjAhRHHhqmtJKggI+OvzgQpDIwfHIDypb1BuKydi2W6cVYEALUYyCLS
dTBDhzj8zR5tPCsga8J7+TclQzkWOiI2C6ZtiWrMsL/Uym3uXk5nsoc7lSj7yLd/MrBRhYfP JQ==
Message-ID: <c81c01ed-e737-6a4b-f2e0-ebdc5a1efbb6@redhat.com>
Date: Thu, 16 Jul 2020 09:43:09 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
Thunderbird/68.9.0
MIME-Version: 1.0
In-Reply-To: <MN2PR11MB406317295EF7C30F07950CDA9C7F0@MN2PR11MB4063.namprd11.prod.outlook.com>
Content-Language: en-US
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Subject: Re: [dpdk-dev] [PATCH 3/5] net/virtio: add VIRTIO_SET_STATUS
support to Virtio-user
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
On 7/16/20 5:15 AM, Xia, Chenbo wrote:
> Hi Adrian,
>
>> -----Original Message-----
>> From: Adrian Moreno <amorenoz@redhat.com>
>> Sent: Thursday, July 16, 2020 1:18 AM
>> To: dev@dpdk.org
>> Cc: maxime.coquelin@redhat.com; Wang, Zhihong <zhihong.wang@intel.com>;
>> amorenoz@redhat.com; Xia, Chenbo <chenbo.xia@intel.com>
>> Subject: [PATCH 3/5] net/virtio: add VIRTIO_SET_STATUS support to Virtio-user
>>
>> From: Maxime Coquelin <maxime.coquelin@redhat.com>
>>
>> This patch adds support for VHOST_USER_SET_STATUS request. It is used to
>> make the backend aware of Virtio devices status update.
>>
>> It is useful for the backend to know when the Virtio driver is done with the Virtio
>> device configuration.
>>
>> Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
>> Signed-off-by: Adrian Moreno <amorenoz@redhat.com>
>> ---
>> drivers/net/virtio/virtio_user/vhost.h | 6 +++++
>> drivers/net/virtio/virtio_user/vhost_user.c | 10 ++++++++
>> .../net/virtio/virtio_user/virtio_user_dev.c | 23 ++++++++++++++++++-
>> .../net/virtio/virtio_user/virtio_user_dev.h | 1 +
>> drivers/net/virtio/virtio_user_ethdev.c | 1 +
>> 5 files changed, 40 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/virtio/virtio_user/vhost.h
>> b/drivers/net/virtio/virtio_user/vhost.h
>> index 260e1c308..8f49ef457 100644
>> --- a/drivers/net/virtio/virtio_user/vhost.h
>> +++ b/drivers/net/virtio/virtio_user/vhost.h
>> @@ -57,6 +57,10 @@ struct vhost_vring_addr { #define
>> VHOST_USER_PROTOCOL_F_REPLY_ACK 3 #endif
>>
>> +#ifndef VHOST_USER_PROTOCOL_F_STATUS
>> +#define VHOST_USER_PROTOCOL_F_STATUS 16 #endif
>> +
>> enum vhost_user_request {
>> VHOST_USER_NONE = 0,
>> VHOST_USER_GET_FEATURES = 1,
>> @@ -77,6 +81,8 @@ enum vhost_user_request {
>> VHOST_USER_SET_PROTOCOL_FEATURES = 16,
>> VHOST_USER_GET_QUEUE_NUM = 17,
>> VHOST_USER_SET_VRING_ENABLE = 18,
>> + VHOST_USER_SET_STATUS = 39,
>> + VHOST_USER_GET_STATUS = 40,
>> VHOST_USER_MAX
>> };
>>
>> diff --git a/drivers/net/virtio/virtio_user/vhost_user.c
>> b/drivers/net/virtio/virtio_user/vhost_user.c
>> index 631d0e353..2332e01d1 100644
>> --- a/drivers/net/virtio/virtio_user/vhost_user.c
>> +++ b/drivers/net/virtio/virtio_user/vhost_user.c
>> @@ -244,6 +244,8 @@ const char * const vhost_msg_strings[] = {
>> [VHOST_USER_SET_VRING_ENABLE] = "VHOST_SET_VRING_ENABLE",
>> [VHOST_USER_GET_PROTOCOL_FEATURES] =
>> "VHOST_USER_GET_PROTOCOL_FEATURES",
>> [VHOST_USER_SET_PROTOCOL_FEATURES] =
>> "VHOST_USER_SET_PROTOCOL_FEATURES",
>> + [VHOST_USER_SET_STATUS] = "VHOST_SET_STATUS",
>> + [VHOST_USER_GET_STATUS] = "VHOST_GET_STATUS",
>> };
>>
>> static int
>> @@ -280,6 +282,14 @@ vhost_user_sock(struct virtio_user_dev *dev,
>> need_reply = 1;
>> break;
>>
>> + case VHOST_USER_SET_STATUS:
>> + if (!(dev->protocol_features &
>> + (1ULL <<
>> VHOST_USER_PROTOCOL_F_STATUS)))
>> + return 0;
>> +
>> + if (has_reply_ack)
>> + msg.flags |= VHOST_USER_NEED_REPLY_MASK;
>> + /* Fallthrough */
>
> There's a coding style issue here:
> WARNING:PREFER_FALLTHROUGH: Prefer 'fallthrough;' over fallthrough comment.
> Could you fix this?
>
"fallthrough" is not defined. I think this macro is defined in the linux kernel
(where checkpatches.pl comes from?). We could define the same macro that would
depend in compiler support for __falthrough__ attribute.
In any case, this is not the only case:
$ find -name *.c | xargs grep -i "/\* fallthrough \*/" | wc -l
62
So maybe this warning is new?
Should I change all of them together in another patch?
>> case VHOST_USER_SET_FEATURES:
>> case VHOST_USER_SET_PROTOCOL_FEATURES:
>> case VHOST_USER_SET_LOG_BASE:
>> diff --git a/drivers/net/virtio/virtio_user/virtio_user_dev.c
>> b/drivers/net/virtio/virtio_user/virtio_user_dev.c
>> index 0a6991bcc..2c400a448 100644
>> --- a/drivers/net/virtio/virtio_user/virtio_user_dev.c
>> +++ b/drivers/net/virtio/virtio_user/virtio_user_dev.c
>> @@ -424,7 +424,8 @@ virtio_user_dev_setup(struct virtio_user_dev *dev)
>>
>> #define VIRTIO_USER_SUPPORTED_PROTOCOL_FEATURES \
>> (1ULL << VHOST_USER_PROTOCOL_F_MQ | \
>> - 1ULL << VHOST_USER_PROTOCOL_F_REPLY_ACK)
>> + 1ULL << VHOST_USER_PROTOCOL_F_REPLY_ACK | \
>> + 1ULL << VHOST_USER_PROTOCOL_F_STATUS)
>>
>> int
>> virtio_user_dev_init(struct virtio_user_dev *dev, char *path, int queues, @@ -
>> 783,3 +784,23 @@ virtio_user_handle_cq(struct virtio_user_dev *dev, uint16_t
>> queue_idx)
>> __atomic_add_fetch(&vring->used->idx, 1,
>> __ATOMIC_RELAXED);
>> }
>> }
>> +
>> +int
>> +virtio_user_send_status_update(struct virtio_user_dev *dev, uint8_t
>> +status) {
>> + int ret;
>> + uint64_t arg = status;
>> +
>> + /* Vhost-user only for now */
>> + if (!is_vhost_user_by_type(dev->path))
>> + return 0;
>> +
>> + if (!(dev->protocol_features & (1ULL <<
>> VHOST_USER_PROTOCOL_F_STATUS)))
>> + return 0;
>> +
>> + ret = dev->ops->send_request(dev, VHOST_USER_SET_STATUS, &arg);
>> + if (ret)
>> + return -1;
>
> Do you think we should add a log here to show if SET_STAUTS failed?
>
Good idea! Will do in the next version. Thanks
> Thanks!
> Chenbo
>
>> +
>> + return 0;
>> +}
>> diff --git a/drivers/net/virtio/virtio_user/virtio_user_dev.h
>> b/drivers/net/virtio/virtio_user/virtio_user_dev.h
>> index 10b274d19..a76d7cfaf 100644
>> --- a/drivers/net/virtio/virtio_user/virtio_user_dev.h
>> +++ b/drivers/net/virtio/virtio_user/virtio_user_dev.h
>> @@ -74,4 +74,5 @@ void virtio_user_handle_cq(struct virtio_user_dev *dev,
>> uint16_t queue_idx); void virtio_user_handle_cq_packed(struct virtio_user_dev
>> *dev,
>> uint16_t queue_idx);
>> uint8_t virtio_user_handle_mq(struct virtio_user_dev *dev, uint16_t q_pairs);
>> +int virtio_user_send_status_update(struct virtio_user_dev *dev, uint8_t
>> +status);
>> #endif
>> diff --git a/drivers/net/virtio/virtio_user_ethdev.c
>> b/drivers/net/virtio/virtio_user_ethdev.c
>> index 5b06d8e89..e52f11341 100644
>> --- a/drivers/net/virtio/virtio_user_ethdev.c
>> +++ b/drivers/net/virtio/virtio_user_ethdev.c
>> @@ -273,6 +273,7 @@ virtio_user_set_status(struct virtio_hw *hw, uint8_t
>> status)
>> else if (status == VIRTIO_CONFIG_STATUS_RESET)
>> virtio_user_reset(hw);
>> dev->status = status;
>> + virtio_user_send_status_update(dev, status);
>> }
>>
>> static uint8_t
>> --
>> 2.26.2
>
--
Adrián Moreno