From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id CF9A87F3C for ; Tue, 7 Jun 2016 13:43:01 +0200 (CEST) Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 187D581F03; Tue, 7 Jun 2016 11:43:01 +0000 (UTC) Received: from sopuli.koti.laiskiainen.org (vpn1-5-73.ams2.redhat.com [10.36.5.73]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u57BgwY2027969; Tue, 7 Jun 2016 07:42:59 -0400 To: Yuanhan Liu , dev@dpdk.org References: <1463117111-27050-1-git-send-email-yuanhan.liu@linux.intel.com> <1465271530-27878-1-git-send-email-yuanhan.liu@linux.intel.com> <1465271530-27878-9-git-send-email-yuanhan.liu@linux.intel.com> Cc: huawei.xie@intel.com, Thomas Monjalon , Traynor Kevin , Rich Lane , Tetsuya Mukawa From: Panu Matilainen Message-ID: Date: Tue, 7 Jun 2016 14:42:58 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.0 MIME-Version: 1.0 In-Reply-To: <1465271530-27878-9-git-send-email-yuanhan.liu@linux.intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.68 on 10.5.11.24 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Tue, 07 Jun 2016 11:43:01 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH v3 08/20] vhost: introduce new API to export numa node X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Jun 2016 11:43:02 -0000 On 06/07/2016 06:51 AM, Yuanhan Liu wrote: > Introduce a new API rte_vhost_get_numa_node() to get the numa node > from which the virtio_net struct is allocated. > > Signed-off-by: Yuanhan Liu > Tested-by: Rich Lane > Acked-by: Rich Lane > --- > drivers/net/vhost/rte_eth_vhost.c | 13 ++++--------- > lib/librte_vhost/rte_vhost_version.map | 7 +++++++ > lib/librte_vhost/rte_virtio_net.h | 12 ++++++++++++ > lib/librte_vhost/virtio-net.c | 26 ++++++++++++++++++++++++++ > 4 files changed, 49 insertions(+), 9 deletions(-) > [...] > diff --git a/lib/librte_vhost/rte_vhost_version.map b/lib/librte_vhost/rte_vhost_version.map > index 3d8709e..bf7b000 100644 > --- a/lib/librte_vhost/rte_vhost_version.map > +++ b/lib/librte_vhost/rte_vhost_version.map > @@ -20,3 +20,10 @@ DPDK_2.1 { > rte_vhost_driver_unregister; > > } DPDK_2.0; > + > +DPDK_16.07 { > + global: > + > + rte_vhost_get_numa_node; > + > +} DPDK_16.04; This fails to compile in shared library configuration: LD librte_vhost.so.3.1 /usr/bin/ld: unable to find version dependency `DPDK_16.04' collect2: error: ld returned 1 exit status Problem obviously being that DPDK_16.04 does not exist, the most recent version symbol for librte_vhost is DPDK_2.1 so you need to inherit from that instead. - Panu -