From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f42.google.com (mail-wm0-f42.google.com [74.125.82.42]) by dpdk.org (Postfix) with ESMTP id 7B5F32BB5 for ; Fri, 1 Jul 2016 09:32:57 +0200 (CEST) Received: by mail-wm0-f42.google.com with SMTP id r201so16591615wme.1 for ; Fri, 01 Jul 2016 00:32:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=xGfE2rwj+3hG9HxnvnETbzooIPnlbLzFeZv0k0/aTro=; b=eqfdhkB96hPV6vbG+ZfFfW8YfVI8XCDo4vKKY0YzyWaQMU3BmHBslnVKEkDqnqD+fj uT4lPWQa4C9qn3IBUjkW7FXcquqR/BRduVrWY7V85PMotamMvqKGgzODNJDTZanXqdbD YmRNytSWyTTi0w7/xDWMKvtLpKXiedKTgFcNZcTFP4rXJDTskjmtXpLyqSoNkzIdM5tc viyYPFg4K9kVGu9vhGM02oEI4HNdPlgZo4LrWqISCEkXq+WR4WPPe80hE7oHf3E2ZSwV RsuqZv1hxZy3BL7t4j+yE1WjQO3vlzQV9wrb/2Tb2cMIPhPiOqhxQWaJvrywtNqvcJSM hSmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=xGfE2rwj+3hG9HxnvnETbzooIPnlbLzFeZv0k0/aTro=; b=HmO4GjG0YOK9ElaNyRDFkvUmCI2OdfrckT+r9oXQ41ond8kS4madbT/VmiO1CEOVwT bSThTyUexwDl/WdixFGpBjfGEsyVgDAqgtPWNXxGyuC3Q4ai5G+68yro2v0RirR98Hv8 D6XiN6JrxRu7LJR5LxEWjqjy7CTvyPI0SoaYJgvQx5+h56BeBKFVeCW3FvriHk6mnQJ5 CWVY2+lSDvc5usFK6o4FSWVYcnIxrR9+4yEvYz9XwCH2QTI+GcS78l/rAEu8YRPVhdB7 6w1w6l3wLKLaXpH8LQeUHYUmRUXHRBx4wCMbzZhZug+iMP1v7d+z+y8m13Tb5kZpYWtE AhfA== X-Gm-Message-State: ALyK8tKQ1zNeTM1XRZho7Q5xlJ1Aykta2nsyOprsUoyzxxXYucS05xcDin2IjRuIM7cWTOSP X-Received: by 10.28.155.196 with SMTP id d187mr31433805wme.30.1467358377252; Fri, 01 Jul 2016 00:32:57 -0700 (PDT) Received: from [192.168.1.15] (LFbn-1-8274-170.w81-254.abo.wanadoo.fr. [81.254.171.170]) by smtp.gmail.com with ESMTPSA id qm9sm6342293wjc.36.2016.07.01.00.32.56 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 01 Jul 2016 00:32:56 -0700 (PDT) To: David Hunt , dev@dpdk.org References: <1467272502-56059-1-git-send-email-david.hunt@intel.com> <1467309909-123881-1-git-send-email-david.hunt@intel.com> <1467309909-123881-3-git-send-email-david.hunt@intel.com> Cc: viktorin@rehivetech.com, jerin.jacob@caviumnetworks.com, shreyansh.jain@nxp.com From: Olivier MATZ Message-ID: Date: Fri, 1 Jul 2016 09:32:47 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Icedove/45.1.0 MIME-Version: 1.0 In-Reply-To: <1467309909-123881-3-git-send-email-david.hunt@intel.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v5 2/2] test: migrate custom handler test to stack handler X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Jul 2016 07:32:57 -0000 Hi David, On 06/30/2016 08:05 PM, David Hunt wrote: > After introducing the stack handler in the previous commit, > we now have very similar code to the custom handler in test_mempool.c, > which creates a custom mempool based on simple mallocs. > The stack handler is a cleaner example of adding a new mempool handler, > so this commit replaces the custom handler test with a stack > handler test, and removes the custom handler code. > > Signed-off-by: David Hunt > > [...] > > -static struct rte_mempool_ops mempool_ops_custom = { > - .name = "custom_handler", > - .alloc = custom_mempool_alloc, > - .free = custom_mempool_free, > - .enqueue = custom_mempool_enqueue, > - .dequeue = custom_mempool_dequeue, > - .get_count = custom_mempool_get_count, > -}; > - > -MEMPOOL_REGISTER_OPS(mempool_ops_custom); > - > -/* > * save the object number in the first 4 bytes of object data. All > * other bytes are set to 0. > */ > @@ -600,6 +507,7 @@ test_mempool(void) > struct rte_mempool *mp_cache = NULL; > struct rte_mempool *mp_nocache = NULL; > struct rte_mempool *mp_ext = NULL; mp_ext remains but is unused (it is just freed below). It should be removed.