DPDK patches and discussions
 help / color / mirror / Atom feed
From: Lukasz Wojciechowski <l.wojciechow@partner.samsung.com>
To: "Shetty, Praveen" <praveen.shetty@intel.com>,
	"dev@dpdk.org" <dev@dpdk.org>,
	"Doherty, Declan" <declan.doherty@intel.com>,
	"akhil.goyal@nxp.com" <akhil.goyal@nxp.com>,
	"anoobj@marvell.com" <anoobj@marvell.com>
Cc: "Iremonger, Bernard" <bernard.iremonger@intel.com>,
	"Ananyev, Konstantin" <konstantin.ananyev@intel.com>
Subject: Re: [dpdk-dev] [PATCH v2] examples/ipsec-secgw: fix negative argument passing
Date: Wed, 6 May 2020 13:45:59 +0200	[thread overview]
Message-ID: <c845ff7e-426d-d510-61fa-23e97a7ba3b9@partner.samsung.com> (raw)
In-Reply-To: <CY4PR1101MB2326CC914D82B97718A3C84A9DA40@CY4PR1101MB2326.namprd11.prod.outlook.com>


W dniu 06.05.2020 o 13:03, Shetty, Praveen pisze:
>
> -----Original Message-----
> From: Lukasz Wojciechowski <l.wojciechow@partner.samsung.com>
> Sent: Wednesday, May 6, 2020 4:20 PM
> To: Shetty, Praveen <praveen.shetty@intel.com>; dev@dpdk.org; Doherty, Declan <declan.doherty@intel.com>; akhil.goyal@nxp.com; anoobj@marvell.com
> Cc: Iremonger, Bernard <bernard.iremonger@intel.com>; Ananyev, Konstantin <konstantin.ananyev@intel.com>
> Subject: Re: [dpdk-dev] [PATCH v2] examples/ipsec-secgw: fix negative argument passing
>
>
> W dniu 06.05.2020 o 12:37, Praveen Shetty pisze:
>> Function create_ipsec_esp_flow returns a negative number in case of
>> any failure and we are passing this to strerror to dsiplay the error message.
> typo dsiplay -> display
>
> [Praveen] Thanks, fixed in v3.
>
>> But strerror()'s argument cannot be negative.
>> In case of failure, displaying exact error message to console is
>> handled in create_ipsec_esp_flow function.So it is not required to
>> print the error message again using strerror.
>> This patch will remove the unnecessary calling of strerror function to
>> fix the negative argument passing to strerror issue.
>>
>> Coverity issue: 357691
>> Fixes: 6738c0a95695 ("examples/ipsec-secgw: support flow director")
>> Cc: praveen.shetty@intel.com
>>
>> Signed-off-by: Praveen Shetty <praveen.shetty@intel.com>
>> Acked-by: Lukasz Wojciechowski <l.wojciechow@partner.samsung.com>
>> ---
>> v2 changes:
>> changed commit headline and rephrased commit message.
>>
>>    examples/ipsec-secgw/sa.c | 3 +--
>>    1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/examples/ipsec-secgw/sa.c b/examples/ipsec-secgw/sa.c
>> index e3a1a5aff..632482176 100644
>> --- a/examples/ipsec-secgw/sa.c
>> +++ b/examples/ipsec-secgw/sa.c
>> @@ -1223,8 +1223,7 @@ sa_add_rules(struct sa_ctx *sa_ctx, const struct ipsec_sa entries[],
>>    			rc = create_ipsec_esp_flow(sa);
>>    			if (rc != 0)
>>    				RTE_LOG(ERR, IPSEC_ESP,
>> -					"create_ipsec_esp_flow() failed %s\n",
>> -					strerror(rc));
>> +					"create_ipsec_esp_flow() failed\n");
>>    		}
>>    		print_one_sa_rule(sa, inbound);
>>    	}
Acked-by: Lukasz Wojciechowski <l.wojciechow@partner.samsung.com>
>
-- 

Lukasz Wojciechowski
Principal Software Engineer

Samsung R&D Institute Poland
Samsung Electronics
Office +48 22 377 88 25
l.wojciechow@partner.samsung.com


  reply	other threads:[~2020-05-06 11:46 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20200506090256eucas1p1c4457861c66c164d46000835709ccd84@eucas1p1.samsung.com>
2020-05-06  9:02 ` [dpdk-dev] [PATCH v1] examples/ipsec-secgw: resolve coverity issue Praveen Shetty
2020-05-06  9:37   ` Lukasz Wojciechowski
2020-05-06  9:43   ` [dpdk-dev] [EXT] " Anoob Joseph
2020-05-06 10:40     ` Shetty, Praveen
2020-05-06 10:37   ` [dpdk-dev] [PATCH v2] examples/ipsec-secgw: fix negative argument passing Praveen Shetty
2020-05-06 10:50     ` Lukasz Wojciechowski
2020-05-06 11:03       ` Shetty, Praveen
2020-05-06 11:45         ` Lukasz Wojciechowski [this message]
2020-05-06 11:02     ` [dpdk-dev] [PATCH v3] " Praveen Shetty
2020-05-07  4:18       ` [dpdk-dev] [EXT] " Anoob Joseph
2020-05-09 22:02         ` Akhil Goyal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c845ff7e-426d-d510-61fa-23e97a7ba3b9@partner.samsung.com \
    --to=l.wojciechow@partner.samsung.com \
    --cc=akhil.goyal@nxp.com \
    --cc=anoobj@marvell.com \
    --cc=bernard.iremonger@intel.com \
    --cc=declan.doherty@intel.com \
    --cc=dev@dpdk.org \
    --cc=konstantin.ananyev@intel.com \
    --cc=praveen.shetty@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).