From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9D149A034F; Wed, 6 May 2020 13:46:04 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 72D7A1D92B; Wed, 6 May 2020 13:46:04 +0200 (CEST) Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by dpdk.org (Postfix) with ESMTP id 7AF5C1D913 for ; Wed, 6 May 2020 13:46:02 +0200 (CEST) Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20200506114601euoutp017b4bc17ea2c2b88f1ad93c582824551a~MbdxoOdHB1156611566euoutp01v for ; Wed, 6 May 2020 11:46:01 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20200506114601euoutp017b4bc17ea2c2b88f1ad93c582824551a~MbdxoOdHB1156611566euoutp01v DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1588765562; bh=mRk169qiiIzSFRmnbxs3yc0GpqDw+8jQyelwNsXYKxE=; h=Subject:To:Cc:From:Date:In-Reply-To:References:From; b=t3V6kJjHXSxbI0SIn29W2jrefj/Eeoy/pf4bQNb9oWp+nJ9FKrMic33QLP1MBs1+b Z50TuSUGb95AwX9yElFZObL37eSaOOUf5KpVj3k8na6hIzuWKEsEb7kRMtfY944C83 MxLCHuqEGeKNrvG4gXPjqz1TvfGr77bakB/pWu7U= Received: from eusmges2new.samsung.com (unknown [203.254.199.244]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20200506114601eucas1p1a156db2e35ff236dd00dda6fa58678a5~MbdxfAisi1265212652eucas1p1x; Wed, 6 May 2020 11:46:01 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges2new.samsung.com (EUCPMTA) with SMTP id 56.A4.60679.973A2BE5; Wed, 6 May 2020 12:46:01 +0100 (BST) Received: from eusmtrp2.samsung.com (unknown [182.198.249.139]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20200506114601eucas1p209fc538b74cf9ba1c3b60cc98bfd6b60~MbdxDT2rk3172031720eucas1p25; Wed, 6 May 2020 11:46:01 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eusmtrp2.samsung.com (KnoxPortal) with ESMTP id 20200506114601eusmtrp216dacf29beb004a4757538b6c612a5e0~MbdxCtQdw2096720967eusmtrp2I; Wed, 6 May 2020 11:46:01 +0000 (GMT) X-AuditID: cbfec7f4-0e5ff7000001ed07-be-5eb2a3791776 Received: from eusmtip2.samsung.com ( [203.254.199.222]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id BC.8B.07950.973A2BE5; Wed, 6 May 2020 12:46:01 +0100 (BST) Received: from [106.210.88.70] (unknown [106.210.88.70]) by eusmtip2.samsung.com (KnoxPortal) with ESMTPA id 20200506114600eusmtip2e63d4a6951c3c5113e72ebf869803ffe~MbdwWZ21P1017610176eusmtip2j; Wed, 6 May 2020 11:46:00 +0000 (GMT) To: "Shetty, Praveen" , "dev@dpdk.org" , "Doherty, Declan" , "akhil.goyal@nxp.com" , "anoobj@marvell.com" Cc: "Iremonger, Bernard" , "Ananyev, Konstantin" From: Lukasz Wojciechowski Message-ID: Date: Wed, 6 May 2020 13:45:59 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: Content-Transfer-Encoding: 8bit Content-Language: en-US X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrKKsWRmVeSWpSXmKPExsWy7djPc7qVizfFGbzu0rdYf2Yeo8WyLVuZ LDY3Clu8edDEYvHu03Ymi/d/FrFYNO24zebA7vFrwVJWj8V7XjJ5TF54kdlj47sdTAEsUVw2 Kak5mWWpRfp2CVwZ/0/cYyvoE65YMHsWUwPjB/4uRk4OCQETiQ1fzzN1MXJxCAmsYJQ41bOD DcL5wijxYPYOVpAqIYHPjBKfNtp1MXKAdXz+FwFRs5xRYtWSI1Ddbxkl5nV8YgNpEBaIkGj4 MoUdJCEicJtRYveUPrBJzAJ5Evv/LGAGsdkEbCWOzPwKFucVcJO4dWkGmM0ioCKx9d5UFpBt ogKxEtOvhUCUCEqcnPmEBcTmFEiU6N24hQ1ipLxE89bZzBC2uMStJ/PBDpIQWMcO9E4rI8Sf LhIL/11lh7CFJV4d3wJly0j83wnTsI1R4urvn4wQzn5Gieu9K6CqrCUO//vNBnIRs4CmxPpd +hBhR4k3p2azQYKFT+LGW0GII/gkJm2bzgwR5pXoaBOCqNaTeNozlRFm7Z+1T1gmMCrNQvLa LCTvzELyziyEvQsYWVYxiqeWFuempxYb5aWW6xUn5haX5qXrJefnbmIEJp7T/45/2cG460/S IUYBDkYlHl4D941xQqyJZcWVuYcYJTiYlUR4eX4AhXhTEiurUovy44tKc1KLDzFKc7AoifMa L3oZKySQnliSmp2aWpBaBJNl4uCUamCMOyO807EqbNdRl41vo8IYC2d9E++5/6Fwu/mbixq+ u4PXn3M/49sZbijEMNPKIDLE6+p3OR4ZnQSt3/MU8jYzRQqvV/zMJag4+ddG7y2ftTzMy+24 j2ubKnY2rok8b1Ex97nVgehOxcIjczpdi1zeWeyUVZBdVhz09fZ5hr7OghqHlQ0F6kosxRmJ hlrMRcWJAHDI8yM4AwAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrKIsWRmVeSWpSXmKPExsVy+t/xe7qVizfFGRw+K2ix/sw8RotlW7Yy WWxuFLZ486CJxeLdp+1MFu//LGKxaNpxm82B3ePXgqWsHov3vGTymLzwIrPHxnc7mAJYovRs ivJLS1IVMvKLS2yVog0tjPQMLS30jEws9QyNzWOtjEyV9O1sUlJzMstSi/TtEvQy/p+4x1bQ J1yxYPYspgbGD/xdjBwcEgImEp//RXQxcnIICSxllFh8LgEiLCPx4ZIASFhCQFjiz7Uuti5G LqCS14wS85/9YgVJCAtESJxYMZsdJCEicJtRonnXInaQZmaBPIlVDXYQDTeZJE5Pfs0O0sAm YCtxZOZXsGZeATeJW5dmgNksAioSW+9NZQHpFRWIlWi5qAlRIihxcuYTFhCbUyBRonfjFjYQ m1nATGLe5ofMELa8RPPW2VC2uMStJ/OZJjAKzULSPgtJyywkLbOQtCxgZFnFKJJaWpybnlts pFecmFtcmpeul5yfu4kRGGXbjv3csoOx613wIUYBDkYlHl4D941xQqyJZcWVuYcYJTiYlUR4 eX4AhXhTEiurUovy44tKc1KLDzGaAv02kVlKNDkfmADySuINTQ3NLSwNzY3Njc0slMR5OwQO xggJpCeWpGanphakFsH0MXFwSjUwHtk460B4s+6j5//aGtpFw66tX1d5fO9xwyzuuWZ6KuI3 v1yJf37QOmG7m1lR7Ravpf8KeObsWKFn7f1D02jnvVuPLQy6lr5fncuvPT/j0bdHgf5N89YG bHuls+6fVn6p/74f64R55p11WFvDc0zOxmWyVciE/s/uBx8dY9XUXXbkjufZ7/XZ55VYijMS DbWYi4oTAaBd51bIAgAA X-CMS-MailID: 20200506114601eucas1p209fc538b74cf9ba1c3b60cc98bfd6b60 X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-RootMTR: 20200506103808eucas1p2656f3090d0d6086c9de8586c33668f80 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200506103808eucas1p2656f3090d0d6086c9de8586c33668f80 References: <20200506090240.19214-1-praveen.shetty@intel.com> <20200506103752.20478-1-praveen.shetty@intel.com> Subject: Re: [dpdk-dev] [PATCH v2] examples/ipsec-secgw: fix negative argument passing X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" W dniu 06.05.2020 o 13:03, Shetty, Praveen pisze: > > -----Original Message----- > From: Lukasz Wojciechowski > Sent: Wednesday, May 6, 2020 4:20 PM > To: Shetty, Praveen ; dev@dpdk.org; Doherty, Declan ; akhil.goyal@nxp.com; anoobj@marvell.com > Cc: Iremonger, Bernard ; Ananyev, Konstantin > Subject: Re: [dpdk-dev] [PATCH v2] examples/ipsec-secgw: fix negative argument passing > > > W dniu 06.05.2020 o 12:37, Praveen Shetty pisze: >> Function create_ipsec_esp_flow returns a negative number in case of >> any failure and we are passing this to strerror to dsiplay the error message. > typo dsiplay -> display > > [Praveen] Thanks, fixed in v3. > >> But strerror()'s argument cannot be negative. >> In case of failure, displaying exact error message to console is >> handled in create_ipsec_esp_flow function.So it is not required to >> print the error message again using strerror. >> This patch will remove the unnecessary calling of strerror function to >> fix the negative argument passing to strerror issue. >> >> Coverity issue: 357691 >> Fixes: 6738c0a95695 ("examples/ipsec-secgw: support flow director") >> Cc: praveen.shetty@intel.com >> >> Signed-off-by: Praveen Shetty >> Acked-by: Lukasz Wojciechowski >> --- >> v2 changes: >> changed commit headline and rephrased commit message. >> >> examples/ipsec-secgw/sa.c | 3 +-- >> 1 file changed, 1 insertion(+), 2 deletions(-) >> >> diff --git a/examples/ipsec-secgw/sa.c b/examples/ipsec-secgw/sa.c >> index e3a1a5aff..632482176 100644 >> --- a/examples/ipsec-secgw/sa.c >> +++ b/examples/ipsec-secgw/sa.c >> @@ -1223,8 +1223,7 @@ sa_add_rules(struct sa_ctx *sa_ctx, const struct ipsec_sa entries[], >> rc = create_ipsec_esp_flow(sa); >> if (rc != 0) >> RTE_LOG(ERR, IPSEC_ESP, >> - "create_ipsec_esp_flow() failed %s\n", >> - strerror(rc)); >> + "create_ipsec_esp_flow() failed\n"); >> } >> print_one_sa_rule(sa, inbound); >> } Acked-by: Lukasz Wojciechowski > -- Lukasz Wojciechowski Principal Software Engineer Samsung R&D Institute Poland Samsung Electronics Office +48 22 377 88 25 l.wojciechow@partner.samsung.com