DPDK patches and discussions
 help / color / mirror / Atom feed
From: Andrew Rybchenko <arybchenko@solarflare.com>
To: Thomas Monjalon <thomas@monjalon.net>, Dekel Peled <dekelp@mellanox.com>
Cc: <dev@dpdk.org>, <jerinjacobk@gmail.com>,
	<stephen@networkplumber.org>, <ajit.khaparde@broadcom.com>,
	<maxime.coquelin@redhat.com>, <olivier.matz@6wind.com>,
	<david.marchand@redhat.com>, <ferruh.yigit@intel.com>,
	<asafp@mellanox.com>
Subject: Re: [dpdk-dev] [PATCH v2] doc: announce change in ETH and VLAN item structs
Date: Thu, 6 Aug 2020 18:14:31 +0300
Message-ID: <c849280a-31ad-cbf8-b316-6a4b5a118619@solarflare.com> (raw)
In-Reply-To: <2923630.3o79E1KD6h@thomas>

On 8/6/20 3:25 PM, Thomas Monjalon wrote:
> 06/08/2020 12:45, Dekel Peled:
>> Structs rte_flow_item_eth and rte_flow_item_vlan will be modified,
>> to include an additional value, indicating existence or absence of VLAN
>> headers following the current header, as proposed in RFC
>> https://mails.dpdk.org/archives/dev/2020-August/177536.html.
>> Because of ABI break this change is proposed for 20.11.
>>
>> Signed-off-by: Dekel Peled <dekelp@mellanox.com>
>> ---
>> +* ethdev: The ``struct rte_flow_item_eth`` and ``struct rte_flow_item_vlan``
>> +  structs will be modified, to include an additional value, indicating existence
>> +  or absence of a VLAN header following the current header, as proposed in RFC
>> +  https://mails.dpdk.org/archives/dev/2020-August/177536.html.
> Specifying match patterns on none or multiple extensions
> is difficult to manage with rte_flow.
> It seems this approach of adding explicit fields in the items
> can work well.
>
> Acked-by: Thomas Monjalon <thomas@monjalon.net>

Similar to IPv6, it looks required to add extra information to ETH (and may
be VLAN) item, but I'm not sure that proposed solution is 100% OK.
Anyway, the scope of the deprecation notice is ongoing changes, so:

Acked-by: Andrew Rybchenko <arybchenko@solarflare.com>


  reply	other threads:[~2020-08-06 15:14 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-04 16:01 [dpdk-dev] [PATCH] doc: announce change in ETH item struct Dekel Peled
2020-08-05  3:39 ` Ajit Khaparde
2020-08-05 10:49 ` Andrew Rybchenko
2020-08-05 13:31   ` Dekel Peled
2020-08-05 13:44     ` Andrew Rybchenko
2020-08-05 14:25       ` Dekel Peled
2020-08-06 10:45 ` [dpdk-dev] [PATCH v2] doc: announce change in ETH and VLAN item structs Dekel Peled
2020-08-06 12:25   ` Thomas Monjalon
2020-08-06 15:14     ` Andrew Rybchenko [this message]
2020-08-06 15:50       ` Ajit Khaparde
2020-08-06 21:57         ` Thomas Monjalon
2020-08-06 17:07   ` Ori Kam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c849280a-31ad-cbf8-b316-6a4b5a118619@solarflare.com \
    --to=arybchenko@solarflare.com \
    --cc=ajit.khaparde@broadcom.com \
    --cc=asafp@mellanox.com \
    --cc=david.marchand@redhat.com \
    --cc=dekelp@mellanox.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=jerinjacobk@gmail.com \
    --cc=maxime.coquelin@redhat.com \
    --cc=olivier.matz@6wind.com \
    --cc=stephen@networkplumber.org \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git