From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id BFD26A04B5; Thu, 29 Oct 2020 12:37:08 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1594ECA32; Thu, 29 Oct 2020 12:37:06 +0100 (CET) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by dpdk.org (Postfix) with ESMTP id CE972CA02 for ; Thu, 29 Oct 2020 12:37:03 +0100 (CET) Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 79D607F4AC; Thu, 29 Oct 2020 14:37:02 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 79D607F4AC DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru; s=default; t=1603971422; bh=KdFHk7x2KjfOatxqxmY9MFb88sW2TN7LUah4Jo8kYcU=; h=Subject:To:Cc:References:From:Date:In-Reply-To; b=uMcHUxmCGCICzPJfnpV/S4/jWhJhqbSS+2AIfpkheJoce5ImTd/JvW0++VheCOx+X +kgu3E3YMCezH9w2YQjFOmFuAYc4rDKTim4n9Q6KgTImgsTyTPsDmi+bpJ8o53M2WF Ol8lTPMssvqMlAqhPSulpBCN0sDWZ47Ulr8gmW2A= To: Thomas Monjalon Cc: dev@dpdk.org, ferruh.yigit@intel.com, david.marchand@redhat.com, bruce.richardson@intel.com, olivier.matz@6wind.com, jerinj@marvell.com, viacheslavo@nvidia.com, Nithin Dabilpuram , Kiran Kumar K , Ray Kinsella , Neil Horman References: <20201029092751.3837177-1-thomas@monjalon.net> <20201029092751.3837177-11-thomas@monjalon.net> <69cd6699-290f-102f-038a-f9fdde5874a1@oktetlabs.ru> <2870492.JuJT3Mpklu@thomas> From: Andrew Rybchenko Organization: OKTET Labs Message-ID: Date: Thu, 29 Oct 2020 14:37:02 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: <2870492.JuJT3Mpklu@thomas> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 10/15] net/octeontx2: switch timestamp to dynamic mbuf field X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/29/20 2:34 PM, Thomas Monjalon wrote: > 29/10/2020 12:02, Andrew Rybchenko: >> On 10/29/20 12:27 PM, Thomas Monjalon wrote: >>> +/* variables are exported because this file is included in other drivers */ >>> +extern uint64_t rte_pmd_octeontx2_timestamp_rx_dynflag; >>> +extern int rte_pmd_octeontx2_timestamp_dynfield_offset; >>> + >>> +static inline rte_mbuf_timestamp_t * >>> +otx2_timestamp_dynfield(struct rte_mbuf *mbuf) >>> +{ >>> + return RTE_MBUF_DYNFIELD(mbuf, >>> + rte_pmd_octeontx2_timestamp_dynfield_offset, >>> + rte_mbuf_timestamp_t *); >>> +} >>> + >> >> May be ethdev should provide the inline function? > > It would mean exporting the offsets. > > And actually I think this field should not be restricted to ethdev. > I see OK.