From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
To: Dariusz Stojaczyk <dariuszx.stojaczyk@intel.com>, dev@dpdk.org
Cc: stable@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] memory: fix alignment in eal_get_virtual_area()
Date: Mon, 16 Jul 2018 13:58:00 +0100 [thread overview]
Message-ID: <c8586b27-e2af-fb25-3bbf-962855c3520b@intel.com> (raw)
In-Reply-To: <1528916894-1991-1-git-send-email-dariuszx.stojaczyk@intel.com>
On 13-Jun-18 8:08 PM, Dariusz Stojaczyk wrote:
> Although the alignment mechanism works as intended, the
> `no_align` bool flag was set incorrectly. We were aligning
> buffers that didn't need extra alignment, and weren't
> aligning ones that really needed it.
>
> Fixes: b7cc54187ea4 ("mem: move virtual area function in common directory")
> Cc: anatoly.burakov@intel.com
> Cc: stable@dpdk.org
>
> Signed-off-by: Dariusz Stojaczyk <dariuszx.stojaczyk@intel.com>
> ---
> lib/librte_eal/common/eal_common_memory.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/librte_eal/common/eal_common_memory.c b/lib/librte_eal/common/eal_common_memory.c
> index 4f0688f..a7c89f0 100644
> --- a/lib/librte_eal/common/eal_common_memory.c
> +++ b/lib/librte_eal/common/eal_common_memory.c
> @@ -70,7 +70,7 @@ eal_get_virtual_area(void *requested_addr, size_t *size,
> * system page size is the same as requested page size.
> */
> no_align = (requested_addr != NULL &&
> - ((uintptr_t)requested_addr & (page_sz - 1)) == 0) ||
> + ((uintptr_t)requested_addr & (page_sz - 1))) ||
> page_sz == system_page_sz;
>
> do {
>
This patch is wrong - no alignment should be performed if address is
already alighed, e.g. if requested_addr & (page_sz - 1) == 0. The
original code was correct.
Thomas, could you please revert this patch?
--
Thanks,
Anatoly
next prev parent reply other threads:[~2018-07-16 12:58 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-13 19:08 Dariusz Stojaczyk
2018-06-14 7:29 ` Burakov, Anatoly
2018-07-12 21:52 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
2018-07-16 12:58 ` Burakov, Anatoly [this message]
2018-07-16 13:29 ` [dpdk-dev] " Stojaczyk, DariuszX
2018-07-16 14:01 ` Burakov, Anatoly
2018-07-16 14:16 ` Burakov, Anatoly
2018-07-17 9:53 ` Stojaczyk, DariuszX
2018-07-17 9:22 ` Xu, Qian Q
2018-07-17 9:25 ` Burakov, Anatoly
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c8586b27-e2af-fb25-3bbf-962855c3520b@intel.com \
--to=anatoly.burakov@intel.com \
--cc=dariuszx.stojaczyk@intel.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).