From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 54F99A0579;
	Tue,  6 Apr 2021 11:32:13 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 4409114102C;
	Tue,  6 Apr 2021 11:32:13 +0200 (CEST)
Received: from szxga04-in.huawei.com (szxga04-in.huawei.com [45.249.212.190])
 by mails.dpdk.org (Postfix) with ESMTP id BD22D14100C
 for <dev@dpdk.org>; Tue,  6 Apr 2021 11:32:11 +0200 (CEST)
Received: from DGGEMS404-HUB.china.huawei.com (unknown [172.30.72.59])
 by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4FF2LJ1xBvz1BGJj;
 Tue,  6 Apr 2021 17:30:00 +0800 (CST)
Received: from [127.0.0.1] (10.40.190.165) by DGGEMS404-HUB.china.huawei.com
 (10.3.19.204) with Microsoft SMTP Server id 14.3.498.0; Tue, 6 Apr 2021
 17:32:02 +0800
From: fengchengwen <fengchengwen@huawei.com>
To: "orika@nvidia.com" <orika@nvidia.com>, Ferruh Yigit
 <ferruh.yigit@intel.com>
CC: "dev@dpdk.org" <dev@dpdk.org>, "humin29@huawei.com" <humin29@huawei.com>
Message-ID: <c86703bd-b8d6-61b3-dda3-0a67c3cd3f2a@huawei.com>
Date: Tue, 6 Apr 2021 17:32:02 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.11.0
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-Originating-IP: [10.40.190.165]
X-CFilter-Loop: Reflected
Subject: [dpdk-dev] How about public rte flow lock API
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi, Ori and Ferruh

    Currently, the rte flow API has the lock of flow_ops_mutx default which
used when driver hasn't provided mutex protection, it's inner API which was
not public, but in hns3 driver there maybe concurrent access driver's rte flow
data when doing reset recovery (which occur in intr thread) and upper-layer
application calling flow API.

    We think it's best to use framework's lock mechanism (i.e. flow_ops_mutex),
but currently it can't address hns3's requirement (as described above).

    There maybe three schemes:
    A) public the rte flow lock API.
    B) driver direct access the framework's flow_ops_mutex.
    C) driver adds one new mutex and delcare RTE_ETH_DEV_FLOW_OPS_THREAD_SAFE.

    we prefer use the scheme A, how about your opinion ?


Best regards