From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C1B82425A5; Fri, 15 Sep 2023 15:42:16 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AFF5E402EC; Fri, 15 Sep 2023 15:42:16 +0200 (CEST) Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2041.outbound.protection.outlook.com [40.107.237.41]) by mails.dpdk.org (Postfix) with ESMTP id 34C7D40041 for ; Fri, 15 Sep 2023 15:42:15 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QvmlyNnyI2NA8+OWCwvP5a1Mnrs+0hp3rRe9yHaXXMdR3yFQfPcACek23Map7DAsXwycdnLTF7xFSXHXVRSf39yhwsxSN8K2X0N+xLgc4zB+yKl22Ltb9najaYWFT4nblVoJyrJ1A975L3LwtXXLeOM3ksh5dbUETHanZ36BQdV2Y/NpiCILJaMIEVRU37Jl1VpEIYMLROroQeB5PdFytKbcj5z5vzXVK//dw0IxN7qDt246nh4HUbJ432LFxnWT4yKPNucw2HzsKoaEgGyD6KCkJ1CLA6xOmWGwHlGE/4AgIOdrDpbHn3pgzrQ170e5hZQtFhqvbG0pZzkEfR9/kQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dePd5okola9J/6Mi29EegAtDa0SAbqD6pUZabSG5UWY=; b=GcfFtcITlPf/8WZAWNefZNybto+Pa3LVx+S9zT7MeGHeQBt8V3LR1NRmM9lPpDm+WufXymCD43ufVKWdckvW3vMnIvMisnlMvtrIL/Jllmz8MehZ4xc1G8XqBQ3kZOuVFp4GZY4GUfLVUHg3wvUI5pRCk9vJ2psgY4MEwfUcf2nHweTR2fG+v9YKzWfoQEBhpDeDgjPmDaBy/veL0Z5DAN54ZsZ5IfD+ICfF1IURe8SjlM3N7ItRtmazIgCkvPVx7CEQn7CnQsNDmWpLhV226KfJJyq0wvZW2Ylj4BQP+wXTmMo/9Qa8MskPKk070fP8dRUEI5o/L7D7L9bCu9VM7Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dePd5okola9J/6Mi29EegAtDa0SAbqD6pUZabSG5UWY=; b=Dwd6O868wa/WXTnvC3jBylSPR+Mv727/afub0zlUY+KUqLDz8RnLsqmTvRMtAZuokUyLPvQiMpfkb8Dmb2iwNWd7O+HlhIN7Ve298ZmXWBna3Gl/t8XXkvvO2ut9LG7eGbassSkN0hDRbXTokPmhDoHWYT39QUibIX9rBeGDlQE= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by MW6PR12MB8664.namprd12.prod.outlook.com (2603:10b6:303:23c::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6768.38; Fri, 15 Sep 2023 13:42:13 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::102f:c69b:d3e5:7fe8]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::102f:c69b:d3e5:7fe8%4]) with mapi id 15.20.6792.021; Fri, 15 Sep 2023 13:42:13 +0000 Message-ID: Date: Fri, 15 Sep 2023 14:42:11 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 03/27] net/nfp: unify the type of integer variable Content-Language: en-US To: Chaoyong He , dev@dpdk.org Cc: oss-drivers@corigine.com, =?UTF-8?Q?Niklas_S=C3=B6derlund?= References: <20230830021457.2064750-1-chaoyong.he@corigine.com> <20230915091551.1459606-1-chaoyong.he@corigine.com> <20230915091551.1459606-4-chaoyong.he@corigine.com> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJjb9DJBQkC+3/YAAoJEFRTPtCK Km/6d94P/irGq3mPa7LamXMIioQ8i6ppMSjpr8g+SxH9RnzbmoUjUY6hVzCpXYxEejiJHubg 7lwD+bOocYpiU8Pe0UncVBhIPNk/dIWQAyH0IWK1nd+hOnjxHv3AQpP80Be2o1mUn3oq/b+B QYiyvvre2gIugYq0hzLcG7z4zREeT+Nl0DMDfnLx+Tj2FAOHrOfudUqjdr/VjF5PoTK0bxnb Brqulp0I0ft7hNsufhzf+TlqaB5l0eQO4gDo5xGTP97TT1cGYsXVMsyDhHqW6P3cuj8kkLkO Ch4oq8OLL8GElgRy5y5svU6CJu3f8hT9aiqIoaRpfNv6N8iEk6g4/HNN+uydb9YCA+1pbwBx skmDhtxQrmXpI+Fmfq0aX2NmqHcy6JR8Ekm/nfwLAW/aDpwoMImVN5pPXtOBSjYi4pj7hiJk UA0ZFi8HCW+fic85p8MXn1GPDmbO82Mm3JVJ1uJNAzGsBbW5SP1ol6+XTeaSxcmzFlrDs8vL XQJMRTpcG6Pti7GbbsOtldvmxRQpq9PmCgQg9IrPXpMoaKE3WwtiSiCALs0kYj4F+hhgAfjI RsOuaAJTnKYW31pC/QdroMNAEqIpLveql03jj+xD9ntJIVAsXiCitsLIXzKP0L5tcHkoVLC3 NAjVYq6XkAEssPF4mMRLoEwpvxOytHe1BCJoRl0YA0aQzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmNv0PAFCQL7f/8ACgkQVFM+0Ioqb/oU9hAAisAJJ09j/kiEeA1HGKUg3DyFnYW22zRL z1IHYmcHQanMx4+FAwsb1bonVldQMIYNJ9z69UNIU16zIqLZt3D5QK7Je5F5q4NZgfP2jtjX rc3jyu0PuDerFZQyxNcYhhmlF9JO9NV976WYbBAM3AAr0TDohUk+YicYTKab+ZHYOABXbqHX qi+bzDCH1vKBDfpJviprthhK1tIABUK5lsp9aFwFU2jfu2J3XX3pwQhPMjtn2C4v37XUnOqM SJPr2HLU27IW5I3BBpJn7dZE/BkmDmnceHF8E4tRlXCQ/cf81+eErL832sfhVJo1MpubKh3B j89ZLmw0cDXZP2hqlC9vdXnoWWHI8PDPkiw9z11yLrT9Wd4cTJTjFV49Z9G96rgnOtWDcZ1J xHBAnXYQ7V2k9abY+ZqY1PtAPr/smqzQfPHXyTAhRVZp2f3yQmj7UqB07FJuLQjJ4CGk97Qx ///qeSg7D8x/sGEA8Yp2jgIj6u7tspuz+RgBYrWpfI0VIHhWED0jNXzqztrVX18CzA6r0ReY SG+CSyycKkco6UI9ZeUrXFwnoUJqIJY9wTJo5gD9EgGIbItv3qWTq29dihLYpzd6dqB708k7 4RBz9051oLaFVGkguFw/tXmA17nx+c2uR5jx8wb4j68umG2X++0dSta5eHAVhmtXvrqPW6Ku 3FQ= In-Reply-To: <20230915091551.1459606-4-chaoyong.he@corigine.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0081.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:190::14) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|MW6PR12MB8664:EE_ X-MS-Office365-Filtering-Correlation-Id: b13ca98e-15ec-408e-84d7-08dbb5f19134 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: qyro7kh1HzlH6EoSPyh5mueYEUjLPCNYSRVJO1N0LoqHLEatVT5MjMZNNWg9evPIXy03ndmhdtKGUrO0+EJ7fFeqd5PgJ+zZFx0XHv6Ez2PMyDe7A2FYjd9pYP22vxtxV7Dwo6dHm3MYybji4TZephmM70u69AOJE3HXkJ7GWKeUwEgd8E+SZfQgPNOg8W3UbfNomUqZLbNcewjA+W/jab1n6ixaPFwH7fC3pVUTY2lBYniBnKKaxlX9D50Gx3nbr26kVYNUXRkDQJ/la5EXvS/cnzQuxkG+ZQXvG84GpM7HOLzXl2BQD2wGOjJGZrB6FWtffz1iZQoJZWDmOzk4HYaq4FpkUk2TxWsjPaQcQrL+8O5g1Spv4n9ug6I0AvCwWPVJYd83UDp7oCrrwT+0ooKBXULlQf0hKGM+/90SlhljFaizzj3MSQvCFXUWSPAEp+DfyqxA/qx6wobCd1eXoRCU4+9N5rklB15+a3WOZ4ETUPeqLQlXS7IYVBEY4g8lcjQpHi4pfLDcN0IHn9P87A/O8xsnmlBd/dQrZwbS5R/eEk6j29UYG3QG0t3oHbxOGYGjcRhLjv8PiS1AVWPkOY0zAwajZ1TtaQPtHi1BBIt5Sa4p5Cm0TaXA+8rLtZGx5wVwm0YMe0lawxo2aJYFvA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(346002)(366004)(376002)(396003)(39860400002)(136003)(186009)(1800799009)(451199024)(5660300002)(26005)(4326008)(8936002)(8676002)(2616005)(66574015)(2906002)(86362001)(38100700002)(36756003)(44832011)(31696002)(83380400001)(6506007)(53546011)(66556008)(6512007)(66476007)(66946007)(478600001)(6486002)(31686004)(41300700001)(316002)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZDNTOFF5TkZNOWF2SUxka1VGNVJrVUphY3BzL3dJZ1ZIMy9McnVOTEczWlAv?= =?utf-8?B?ZkY2NDl3UU5UZTVSN2V4YXliTHBHTTNEUHhNcGZxSHZQSWhINGJCQSsxbFpt?= =?utf-8?B?K2VEdDN4WW1yZTVvS3hhREpUMUdhOFNXbVp6QzNvbFdIdGFhb09XK1diZ3k1?= =?utf-8?B?Q2ErU1NPNW43NmRBaXcwZ01pSndkaWxwZEtUakMwZ3d3UkFCQ1ByM3J2c0FU?= =?utf-8?B?SXFyV2NiRkF3UTNKT24wQUFYdU1va0RsOTZNckRXZnJuaFpwTzdvSjljRUpu?= =?utf-8?B?bW1WQUlzczVnR2gwZktvU0hjYkFsZmZLSWtUdlpoeXF3SnFEVU5qK3dlR1RM?= =?utf-8?B?OHh1ZzZ2aHVJTjhsU25BYjNHeU9NSUdVM0x0ZWp1RUppTWxPeDlWU3lpZ3pi?= =?utf-8?B?NkF4encxVWh6Tkw2MVd0RTdQT2JmbzUzUDNrb1hxZlExTkxhVlMvTGRpQy9Z?= =?utf-8?B?amhhU2ZhVkplZ2RsZWNvTWV5K1VZK3AvbGRVVk5PUTB4eFVhMUxpVk1xUSs5?= =?utf-8?B?bXhTeFB2NHNMV3ZBS0Z0azlRRXcvNEM5SFUxZzkxQjh1YWRTT3ptS3pZS3A1?= =?utf-8?B?Mzlqc3N3VXFDZTBEOEZ2WnAybGZoeFV6bnh3SUMwdzNMMTdnZFFjcnZnZmRK?= =?utf-8?B?YzRIL0dUNFh0NkN3OGd4WFdOK1B5aEdqMlRETnBBL1dDZnRiN0s4ZlBmb2dU?= =?utf-8?B?OVpybDlET2Q1NkFMZHpuOEJxY1R5R2ZhVktWeHVwaWRvTFJqOE9qMWdBcDl6?= =?utf-8?B?ZGJTTTZuSWFBdE51TzUvbzYzWEFjVjdDbWhmTzd1S3E1TlpJWTdVT1hINjQ1?= =?utf-8?B?dmw0U2k4d016TFNXaGR2UFNiam9BOWF2Rm05QUxobWRGc1hmS2dXUFJwSm1n?= =?utf-8?B?ZFJRRzF2eWhYalMvbXFQTnlrRTNlZlFPb0syTjkrV3FxZ3RHMDRZSFV3cE1R?= =?utf-8?B?bHNyV1VXMmdPWG9ua2xPa0ZOdW1LckVodjJtTlA4WnBpMTRGSS9FSDUwdC9I?= =?utf-8?B?V3htNmxybWZPMFBOQjJkY1A4ZmVZVWdGaDhzcDFJREFoNi9tZ0pBMjYwajNJ?= =?utf-8?B?RWdUUURGMzlPaTdvaWVuUnQ2VnZZWEZRWlJDSDRSQ0NLZWpVYmdXd0szR3Vm?= =?utf-8?B?YVJvQkZPeW8rN3E5WXkrSVlDb0tuaXRzNjI0OEFYM2tIOWtWUXBpYlRHZEVs?= =?utf-8?B?MUJaUUFibzhnVTZBb0VWenF1T0ZGK1Y0d0ZMblowa2MvclByYkNYand2Yyt0?= =?utf-8?B?YjR0V3Q1ejJOYUtPUUhNdUdMUWI1ZlNsQ2ZCYmtMN2pTeHU2MERYZnBYc0FW?= =?utf-8?B?T05DTHpBektoTlN4czlpWnRKUmJGbjdzNzUraDA3dW9weEthOC91REFYSVkv?= =?utf-8?B?SXJmV2Q2ODlDYjNJYnZTNW1BcU5QWGpneGhXemNtMnV1SlJRczFoQitiai9C?= =?utf-8?B?SVNqWG5CUnVBWnNVUDFDOTQyY3UrNUY0eFNNdGpGajlYSENBQjJnUnBXUnVl?= =?utf-8?B?Y0NHMVZzQ2lBYzhxcVFhS2NESG5LYUN3ZXpUSGZHdWIrSmdqdWo4UUlYOEd2?= =?utf-8?B?MXY5dXg4STkySDR0ZHBSbE1yL1hraGsrdGV5QnNGT2tRNHVMbzM2V2tDaUF5?= =?utf-8?B?THdRd0Z3SG5ENlVPalU3cUpFMTlnYkhQdHNqNTBWUFlhVktpZEVaZlpNaTFY?= =?utf-8?B?TDdRM2JQZU1LcWVic2NaL2NqSTZYbFdGZy9laWRHcjI2SWRHUWFXM2ZVenJ3?= =?utf-8?B?MDBlYjc2ckhMV1JiVkFUVzB4Rzdtc2lIMmZqNDh5K0J3ZjcwTVUyWHd6TzN5?= =?utf-8?B?Umcwb1JqQVJyWjFMdWVXck8rSWJPQXdjMEI3S0grY0kwTjIvaStHK01ITHha?= =?utf-8?B?SWVJY3FURHVhWUE1MmVPM0psajh2TVdOYzZZbmw1SU14WkgwTHNZamQvQ0t0?= =?utf-8?B?aFFaK24wWkFDV2FtUHJKUjNkK0pyMEc0UTh0Vm5PMTFDeUFISnQ2eGdwR0VD?= =?utf-8?B?cGpNNkNLd1g2MFZUNHp3MjhEdThURXRmN1FGY2pQSXA4aFNkQW5lYWRVQXBF?= =?utf-8?B?TUtyRlNVVTE1TmFMMEtNWmdkTnFBdlpjYy9rSy9XMFdKN2tUdTZLOXZkZy91?= =?utf-8?Q?aNVhUmxFMv2V5vFhrbgxHaBVn?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: b13ca98e-15ec-408e-84d7-08dbb5f19134 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Sep 2023 13:42:13.1983 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: TdMgUi3Nyip6VH9tYH0RCP8nsNGwbvhpow6fPASkvAS+mR+vqvMx0HqGevTMY96k X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW6PR12MB8664 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 9/15/2023 10:15 AM, Chaoyong He wrote: > Unify the type of integer variable to the DPDK prefer style. > Also change the return type of 'nfp_eth_speed2rate()' to the > corresponding enum, which make it more readable. > > Signed-off-by: Chaoyong He > Reviewed-by: Niklas Söderlund <...> > @@ -269,7 +269,7 @@ nfp_cpp_mutex_lock(struct nfp_cpp_mutex *mutex) > if (err < 0 && err != -EBUSY) > return err; > if (time(NULL) >= warn_at) { > - PMD_DRV_LOG(ERR, "Warning: waiting for NFP mutex usage:%u depth:%hd] target:%d addr:%llx key:%08x]", > + PMD_DRV_LOG(ERR, "Warning: waiting for NFP mutex usage:%u depth:%hd] target:%d addr:%lx key:%08x]", > '%lx' is not portable between 32bits and 64bits architectures, when using fixed size variables, like 'uint64_t', better to use 'PRIx64' macro, although I know driver is only compiled for 64bits. <...> > @@ -316,7 +316,7 @@ nfp_nsp_command_buf(struct nfp_nsp *nsp, > > max_size = RTE_MAX(in_size, out_size); > if (FIELD_GET(NSP_DFLT_BUFFER_SIZE_MB, reg) * SZ_1M < max_size) { > - PMD_DRV_LOG(ERR, "NSP: default buffer too small for command 0x%04x (%llu < %u)", > + PMD_DRV_LOG(ERR, "NSP: default buffer too small for command 0x%04x (%llu < %lu)", > '%zu' is for size_t