From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1D0F54265E; Thu, 28 Sep 2023 11:31:08 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A237B40273; Thu, 28 Sep 2023 11:31:07 +0200 (CEST) Received: from NAM02-BN1-obe.outbound.protection.outlook.com (mail-bn1nam02on2049.outbound.protection.outlook.com [40.107.212.49]) by mails.dpdk.org (Postfix) with ESMTP id 9138540150 for ; Thu, 28 Sep 2023 11:31:06 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nGcUyyvZjKkhEqE3iYzwfsMe5pneSbRR71JYFAhcwK0bhYVRN8FgBTaz1j4mcEACiYF3MdHp56bEhN1AlhorzgrH3tduvOFKxBbN70W2doSf2RqOrjY9kv9jpq7KKZMPoBlcATWKJhmYzGCXd+xZD16I9CU1ofQ1ejoKnZn/CFesWkWRmNqGnPMTKfEMCa05PoYxKw5J1Lw+OTywvVYsHEiBTV5zWjcfv+a68d2S43pJbNFLsTrpYqFZJPGkWr+Z0qjW7B2vLExIsOuyDW4uIMQyVQ+CIGn3Xj+qpGBuQEQdhVL/i/Ksqfwm37UamkNUibHUIcCwwi5P6e8MTCwZ4Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7WEqvHj85VYeD3NHRlkpVfDMxboTZcCiJq6tAcPyRZk=; b=CrfMS49bT0dLWVwlodHKU5klS96G0Pw6Pt6sA6zcFvVObsUtLjCBf17VNle+ktE9F9DqC0RK6zg+02rtcYjXE1zkaxtNN0l2WMwZvMmDUEm2lwCS9McBPQymLbmnob3MZwNwH4N5ufUW/FxUgAU+rikf5N7QA2+7g0MZSO9cS5H1zwVhWjhA1anRhkzDzC1T/gS+ntN+8ueQl/MecyKq/73RPen2YdVx0R7rHfkDBDeapnA52lYtZUzL3Hq/gyZEA6XkY5uSxd7UtqVd63EMWexP/QeFwQc/ah3IdonL1V0TeYawKaexgPXCvV044AFB5D22js0SIOZ3NqpV6OwD+w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7WEqvHj85VYeD3NHRlkpVfDMxboTZcCiJq6tAcPyRZk=; b=toa2VfMrp0qIWu6Jv0Lb87bOYWpCCQ+M4UdfQyvAlKjNIgsHm9tHzFMWIm+c+ZAViK2SPVnzF0cLcnfuo4i3PrkENqxANhp4wlIFXObn1lHEi2gcUyRA+BCRahAMUSm5fJsNZMX+rSNy8eEUbKUElvH6vWpa+VwZ91gJUoG9ZnQ= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by CH0PR12MB5106.namprd12.prod.outlook.com (2603:10b6:610:bd::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6838.22; Thu, 28 Sep 2023 09:31:04 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::102f:c69b:d3e5:7fe8]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::102f:c69b:d3e5:7fe8%4]) with mapi id 15.20.6838.024; Thu, 28 Sep 2023 09:31:04 +0000 Message-ID: Date: Thu, 28 Sep 2023 10:30:58 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 02/10] net/nfp: add TLVs capability parsing Content-Language: en-US To: Chaoyong He , "dev@dpdk.org" Cc: oss-drivers , Shihong Wang , Chang Miao References: <20230925060644.1458598-1-chaoyong.he@corigine.com> <20230925060644.1458598-3-chaoyong.he@corigine.com> <69a54bcf-2095-4761-98a0-d55f93d13090@amd.com> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJjb9DJBQkC+3/YAAoJEFRTPtCK Km/6d94P/irGq3mPa7LamXMIioQ8i6ppMSjpr8g+SxH9RnzbmoUjUY6hVzCpXYxEejiJHubg 7lwD+bOocYpiU8Pe0UncVBhIPNk/dIWQAyH0IWK1nd+hOnjxHv3AQpP80Be2o1mUn3oq/b+B QYiyvvre2gIugYq0hzLcG7z4zREeT+Nl0DMDfnLx+Tj2FAOHrOfudUqjdr/VjF5PoTK0bxnb Brqulp0I0ft7hNsufhzf+TlqaB5l0eQO4gDo5xGTP97TT1cGYsXVMsyDhHqW6P3cuj8kkLkO Ch4oq8OLL8GElgRy5y5svU6CJu3f8hT9aiqIoaRpfNv6N8iEk6g4/HNN+uydb9YCA+1pbwBx skmDhtxQrmXpI+Fmfq0aX2NmqHcy6JR8Ekm/nfwLAW/aDpwoMImVN5pPXtOBSjYi4pj7hiJk UA0ZFi8HCW+fic85p8MXn1GPDmbO82Mm3JVJ1uJNAzGsBbW5SP1ol6+XTeaSxcmzFlrDs8vL XQJMRTpcG6Pti7GbbsOtldvmxRQpq9PmCgQg9IrPXpMoaKE3WwtiSiCALs0kYj4F+hhgAfjI RsOuaAJTnKYW31pC/QdroMNAEqIpLveql03jj+xD9ntJIVAsXiCitsLIXzKP0L5tcHkoVLC3 NAjVYq6XkAEssPF4mMRLoEwpvxOytHe1BCJoRl0YA0aQzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmNv0PAFCQL7f/8ACgkQVFM+0Ioqb/oU9hAAisAJJ09j/kiEeA1HGKUg3DyFnYW22zRL z1IHYmcHQanMx4+FAwsb1bonVldQMIYNJ9z69UNIU16zIqLZt3D5QK7Je5F5q4NZgfP2jtjX rc3jyu0PuDerFZQyxNcYhhmlF9JO9NV976WYbBAM3AAr0TDohUk+YicYTKab+ZHYOABXbqHX qi+bzDCH1vKBDfpJviprthhK1tIABUK5lsp9aFwFU2jfu2J3XX3pwQhPMjtn2C4v37XUnOqM SJPr2HLU27IW5I3BBpJn7dZE/BkmDmnceHF8E4tRlXCQ/cf81+eErL832sfhVJo1MpubKh3B j89ZLmw0cDXZP2hqlC9vdXnoWWHI8PDPkiw9z11yLrT9Wd4cTJTjFV49Z9G96rgnOtWDcZ1J xHBAnXYQ7V2k9abY+ZqY1PtAPr/smqzQfPHXyTAhRVZp2f3yQmj7UqB07FJuLQjJ4CGk97Qx ///qeSg7D8x/sGEA8Yp2jgIj6u7tspuz+RgBYrWpfI0VIHhWED0jNXzqztrVX18CzA6r0ReY SG+CSyycKkco6UI9ZeUrXFwnoUJqIJY9wTJo5gD9EgGIbItv3qWTq29dihLYpzd6dqB708k7 4RBz9051oLaFVGkguFw/tXmA17nx+c2uR5jx8wb4j68umG2X++0dSta5eHAVhmtXvrqPW6Ku 3FQ= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0690.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:37b::7) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|CH0PR12MB5106:EE_ X-MS-Office365-Filtering-Correlation-Id: 6ec5e5cf-bc07-4804-c2d5-08dbc005a301 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 1lNj8swyRdO9tywscMjOkW7H+LViTfEF+w/fVm5qX3N5mq5OYHvB2GYHpDQtBZYElEwec/Ct/P+co51cE9XAakXi5FzXLDp7KC2JA/HshYw2Smj1AXR2JMqx7wp7snMI84K4ZE9plWrq083jGsBU5UckcYXeNgbVShMTV+Ln800fBG7Ah5DBq0Lwr6Va1Glzm1IFcj9Fq66eNlHmjLohnishK1GkEoyOrwJLO62IcTjTZtAgpy173HBQpVONMK05eva+0QWISdxQASq38b9Qo/Rc/u85VgiWE2qSY5N2I1hDc8h/m5Mg9RB+rLXYuivnG7GLjXFJyVZFSoLQlyoMpltmF9FOu9ejRZ4q7kRf9vBejFZ8x4BwTQTE1QL9SYfZY4ZdXDLUfepDCXCgfQRrJx95VKGz7SfR9+KlKdI1mlfbVg40QY5eZPlziXOa5S2qPEKVp6GK2jIlssCfSLyUJqNT//7EcYpsVbknNEradgRRzqwm/ltAXZgC78B5MOFdqqDuoRDnnm/+HuyijcGIBBTB7ZH46a1unNMMKdWafjcpKIkmQI2Xu8+opT66ARpjaIIm/T+yGFE5fJfK4w/Ry496K4yAYSd35xeZhTEwSoUaqy7t0x++UcvSI5zYSx0lRtIoV9Hor+ipSYEyOocgTw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(396003)(366004)(39860400002)(136003)(376002)(346002)(230922051799003)(64100799003)(451199024)(186009)(1800799009)(83380400001)(26005)(2616005)(8676002)(8936002)(44832011)(5660300002)(4326008)(6512007)(53546011)(6506007)(6486002)(31686004)(6666004)(38100700002)(478600001)(86362001)(110136005)(66946007)(66476007)(54906003)(316002)(41300700001)(66556008)(36756003)(31696002)(2906002)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bXVvUjAycU81UHpFR0VzbUFZOTZleTFiV1BKOVBoRVg4cFArcnNQWk9rZzJP?= =?utf-8?B?dTRqSWk1bCtOaFJzaGwxZ1F4ajA2cUhYRkJZd2lObFZZb3F3V0pabGtKbU9a?= =?utf-8?B?cDI2R2VuaisrL3VTZ1daQlZjM3FqbmlsTU54M2xuZ0xkdXdaQUdTQ05rWERm?= =?utf-8?B?d1p5MnNjMXJ0NkxpWGhhbk81bXZONll3Z2NsWTdkTWlYRDc5KzBTUDdrWHhI?= =?utf-8?B?Nk5xMkp2elp5aU5TNVdoNlJkZDQvOGFNRHNWaDEwRlFCc2RWTGMzaEI3dWxK?= =?utf-8?B?TFkxbUxSWDBEYnNxK25LNjgrcXpWbGhDWC9LYkFzQVlkQTVCK1VrZ2l4ZnZV?= =?utf-8?B?M3pVODJtVGkrR3dYcTlLblBBbmxaUEozaTdKcUJlbzRYU2NBZ1kyYnNNRmlF?= =?utf-8?B?M3pVM0VqUlVCVnFtRXJiNGJybGhSaElEUHZ6cm1pSHd1UW5nK3FTemhVVXor?= =?utf-8?B?NldqYkZ5QmRmcEpOUkJtbTZYTkg2NDg5akdTZERQT2RNdmQvT0ttK2VwT2o4?= =?utf-8?B?OUdkMExJVUJ6WW1uMWJESi9hMEZKajROV1M2WGtQaGgvSW9KQU5NMDJVVTZU?= =?utf-8?B?QjB4dWtDS1Y5ZzJsNXNqalBzVDNuVXBqajh5RjgwNGFPQldpVGpOa0hSK1N6?= =?utf-8?B?amVPTXhnNllmczYzNTBaTWVPR1dwZVJZU3dXS1R5dW55NlZHRHhycFNNWkdJ?= =?utf-8?B?RHVzcmdTOGVqdjVQaGdzaXlrU3lMTHBtUjEwWG4xRi8yWUk4TDk5aUtaQm9s?= =?utf-8?B?bVFMakJnd3hkaUQ4YmcyalZuQnUwdmtsUTMwaDhEWnRDK3JhSlJ6VDFxT1Ju?= =?utf-8?B?amhiOFFFL3UrZlJRY1ZHeTlxZDJ3ajRlMThqZ1g0b2x1b0NrdHFweXpnL1U0?= =?utf-8?B?RUVSZVNZaW11RjVvMlRlNHp2Y1NtVkhRZFk4UEJ6dGVNK1JwYjg1bExKWW8x?= =?utf-8?B?c2lvQTNoSFZ5eVNaMU5IU2o3L3N4RWFaWnJRUDBndUZFWkFhOTZyd1NKdjlr?= =?utf-8?B?cVU4SmpmdUQ3VnR5Wm1YblJiN3RjdGxrbzFZYll2NmVQRDBrWWU5Nm43VXZJ?= =?utf-8?B?SzZFcjRLMUg0SkF5VHM0QXdoeVJGWmNVbTJ2ZU1wYXhXVDNDZ0p3S09WQVg0?= =?utf-8?B?a1Qyc1NUbHpXcGw2U243YXNUVUFzQm5SU1dmcU1pTSttUGV1QjRnK3g0LzdO?= =?utf-8?B?YUU2VDAxSzVRRC8xOGlMczVOdGpRcHYySEZ1UnJJQmxmS25BREFtS1pNaitJ?= =?utf-8?B?MGZrQ3g3VWRhdm1FUmJ5Q2E5YU1QaDBrbG1FQnpqU2RLd0ZwaUo3bTN6cjBI?= =?utf-8?B?VDVYY2oxQVJ3dkRhaERVYnBPajBaL3lEM1dkZXBCN1JjWHVXemxSMWxyK0lj?= =?utf-8?B?L2xKemxDT1F1MzdHWmV0N001SnIvZzN0TzB5cEhkdk1PU0Qzbkh4OVlsaVNy?= =?utf-8?B?eFRNWDhUTk9LM2x4R2hwczFGZllQZ1VOZVU1allrMmxjWHhiRysrNG5GY3B4?= =?utf-8?B?ZHZEZ2MvbHZkVXBHNG9wUkoybnlRR3R1Y3NwQyt0bmk0VlQ4SnVxalcxM1Jt?= =?utf-8?B?Qll5MHJ4RllFZncwREtVS1BTdVJkNXpzSGh2ZU9EaC9NbDdCVnE2WHZuVlFJ?= =?utf-8?B?SytUelBaaHJnTEp2bTNhT1BkL0VvWWpJK2Z3RFZ1NzVjQUNDYzltSzJQeC9v?= =?utf-8?B?Tm1RVFdDNTNPSmVzRitkYzFWVVdFbkpKY0pua25qcStweTZBQklKRTRvcEho?= =?utf-8?B?RWlhZEZOTEpjazhwU3IvSDVGNEhWZGFqK2ZkcTNuMm5zdXVBMm9NQjRIZXll?= =?utf-8?B?L0FxMURQWDJsZ1orMTJYeUNidlNUVHVQZWU0ZTk0Z0UzTVE3TGloYmJUMWZW?= =?utf-8?B?UWNMTkZNeEZQWU16bWgrK21KMU9ZWnUvMzVGcWxZMmdyVmxYT2ZLdjhISjZt?= =?utf-8?B?U0pEd2VSSGl1K0ZENWxmbDBhbG5OV2t0NWp3ZjBTdlU4MnBHODJtZkRpNG9U?= =?utf-8?B?RDVVTWRpM1kyZ3p6NzEvcHJydk1ZVy8zV0pKMFhXRlRwSmVaMXR4SnVkQktU?= =?utf-8?B?QVRrbEx0S0tXVHAxRW90NjJ2Z1RDcTRpZVRUM1BwL0VMZnZrT29uaVlmWDA5?= =?utf-8?Q?/X61/3BSkH6UvnV64RUmg8BCA?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6ec5e5cf-bc07-4804-c2d5-08dbc005a301 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Sep 2023 09:31:04.6369 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: FRKxpCVV+Dt8rUcgIYkyFlM67WfxSowDpvIZbNjIsBA6ZpZ29+70djw1a/oTApRQ X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR12MB5106 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 9/28/2023 3:02 AM, Chaoyong He wrote: >> On 9/25/2023 7:06 AM, Chaoyong He wrote: >>> From: Shihong Wang >>> >>> Add TLV capabilities to the BAR, TLVs is fit for expressing >>> capabilities of applications running on programmable hardware. >>> >> >> Here application referred is bitstream or FW, right? > Yes, it is. > >> And PCIe BAR is used to exchange the capability information. >> Not for this patch, but I wonder is there a value to add this kind of parsing to the >> PCI code, if it is a generic usage, Chaoyong what do you think? > Basically, it does have value to do that, the kernel driver already have these logics for a long time and using it for some features. > For our PMD, it's the first time we import this and the main reason is we need to support the mailbox channel between driver and CoreNIC firmware. > The mailbox channel is needed for IPsec and other features we will try to merge in the near future. > > I have to admit the ` nfp_net_tlv_caps_parse()` function now seems does have some unrelated logics, I will try to remove them in the next version patch. > > Do you think it's okay? > That is OK, thanks. And we can consider to move some of the functionality to bus layer when there are more users of it, I can ask for your help at that time if it is OK. >>> Declares a TLV capability start at offset 0x58, up to 0x0d90. >>> The used space can be wrapped with RESERVED. >>> >>> Signed-off-by: Shihong Wang >>> Signed-off-by: Chang Miao >>> Reviewed-by: Chaoyong He >>> >> >> <...> >