From: Andrew Rybchenko <arybchenko@solarflare.com>
To: Dekel Peled <dekelp@mellanox.com>, <dev@dpdk.org>
Cc: <jerinjacobk@gmail.com>, <stephen@networkplumber.org>,
<ajit.khaparde@broadcom.com>, <maxime.coquelin@redhat.com>,
<olivier.matz@6wind.com>, <david.marchand@redhat.com>,
<ferruh.yigit@intel.com>, <asafp@mellanox.com>
Subject: Re: [dpdk-dev] [PATCH] doc: announce change in ETH item struct
Date: Wed, 5 Aug 2020 13:49:24 +0300 [thread overview]
Message-ID: <c887b400-43d7-efc7-a7fe-6dd82bac7913@solarflare.com> (raw)
In-Reply-To: <50e5d2139368c54b414379b18a59ed46c12893f5.1596556981.git.dekelp@mellanox.com>
On 8/4/20 7:01 PM, Dekel Peled wrote:
> Struct rte_flow_item_eth will be modified to include additional
> values, indicating existence or absence of VLAN headers following
> the ETH header, as proposed in RFC
> https://mails.dpdk.org/archives/dev/2020-August/177349.html.
> Because of ABI break this change is proposed for 20.11.
>
> Signed-off-by: Dekel Peled <dekelp@mellanox.com>
> ---
> doc/guides/rel_notes/deprecation.rst | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
> index 5201142..6241709 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -115,6 +115,11 @@ Deprecation Notices
> following the IPv6 header, as proposed in RFC
> https://mails.dpdk.org/archives/dev/2020-August/177257.html.
>
> +* ethdev: The ``struct rte_flow_item_eth`` struct will be modified to include
> + additional values, indicating existence or absence of VLAN headers
> + following the ETH header, as proposed in RFC
> + https://mails.dpdk.org/archives/dev/2020-August/177349.html.
It is unclear how it will coexist with VLAN items in a pattern.
Are you going to add consistency checks on ethdev-layer?
Also it is unclear why both bit fields and a number are
required.
Referenced RFC lacks definition of S-VLAN anc C-VLAN in
the context. Exact definition to avoid ambiguity.
So, it looks required to modify the structure, but I'd
not stick to referenced RFC, since the result could
differ a lot. May be reference it as just an example.
next prev parent reply other threads:[~2020-08-05 10:49 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-04 16:01 Dekel Peled
2020-08-05 3:39 ` Ajit Khaparde
2020-08-05 10:49 ` Andrew Rybchenko [this message]
2020-08-05 13:31 ` Dekel Peled
2020-08-05 13:44 ` Andrew Rybchenko
2020-08-05 14:25 ` Dekel Peled
2020-08-06 10:45 ` [dpdk-dev] [PATCH v2] doc: announce change in ETH and VLAN item structs Dekel Peled
2020-08-06 12:25 ` Thomas Monjalon
2020-08-06 15:14 ` Andrew Rybchenko
2020-08-06 15:50 ` Ajit Khaparde
2020-08-06 21:57 ` Thomas Monjalon
2020-08-06 17:07 ` Ori Kam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c887b400-43d7-efc7-a7fe-6dd82bac7913@solarflare.com \
--to=arybchenko@solarflare.com \
--cc=ajit.khaparde@broadcom.com \
--cc=asafp@mellanox.com \
--cc=david.marchand@redhat.com \
--cc=dekelp@mellanox.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=jerinjacobk@gmail.com \
--cc=maxime.coquelin@redhat.com \
--cc=olivier.matz@6wind.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).