From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [67.231.154.164]) by dpdk.org (Postfix) with ESMTP id 7330E4F90 for ; Wed, 21 Mar 2018 13:34:31 +0100 (CET) X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (webmail.solarflare.com [12.187.104.26]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1-us3.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with ESMTPS id DB9D9980058; Wed, 21 Mar 2018 12:34:29 +0000 (UTC) Received: from [192.168.38.17] (84.52.114.114) by ocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server (TLS) id 15.0.1044.25; Wed, 21 Mar 2018 05:34:24 -0700 To: "Ananyev, Konstantin" , Shahaf Shuler , "Yigit, Ferruh" , "Mcnamara, John" , "Kovacevic, Marko" CC: "dev@dpdk.org" , Thomas Monjalon , "Patil@dpdk.org" , Harish , Ivan Malov References: <44e451f86e4582815767cf75b4e0f01f5cc60b5f.1507104596.git.shahafs@mellanox.com> <20180316155138.125423-1-ferruh.yigit@intel.com> <5efda914-7017-9095-2546-ae6e4c627295@solarflare.com> <4a4330be-a8c4-599d-d8a7-3703e5af285c@intel.com> <49e3a7c8-cda2-c129-70a4-6a166fa1b466@solarflare.com> <4b3cdf50-165e-e3c6-6fb0-d354e0d0dc91@solarflare.com> <2601191342CEEE43887BDE71AB977258A0AB2996@irsmsx105.ger.corp.intel.com> From: Andrew Rybchenko Message-ID: Date: Wed, 21 Mar 2018 15:34:23 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <2601191342CEEE43887BDE71AB977258A0AB2996@irsmsx105.ger.corp.intel.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-GB X-Originating-IP: [84.52.114.114] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ocex03.SolarFlarecom.com (10.20.40.36) X-MDID: 1521635670-6+T5JD+CdBWp Subject: Re: [dpdk-dev] [PATCH] doc: update new ethdev offload API description X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Mar 2018 12:34:32 -0000 On 03/21/2018 03:03 PM, Ananyev, Konstantin wrote: > Hi everyone, > >> -----Original Message----- >> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Andrew Rybchenko >> Sent: Wednesday, March 21, 2018 11:37 AM >> To: Shahaf Shuler ; Yigit, Ferruh ; Mcnamara, John ; >> Kovacevic, Marko >> Cc: dev@dpdk.org; Thomas Monjalon ; Patil@dpdk.org; Harish ; Ivan Malov >> >> Subject: Re: [dpdk-dev] [PATCH] doc: update new ethdev offload API description >> >> On 03/21/2018 02:23 PM, Shahaf Shuler wrote: >>> Wednesday, March 21, 2018 1:20 PM, *:*Andrew Rybchenko >>> >>>> Not exactly. We should add statement to allow to enable queue offloads >>>> on port level (to enable on all queues). >>> Why it is needed ? >>> >> May be just a paranoia to avoid misreading/misunderstanding. >> >>> Queue offload is also a port offload, for the simple case it is >>> enabled on each of the queues. >>> >>> PMDs should report rx[tx]_offload_capa = port_offloads | queue_offloads >>> >>> So from the application side it enables a **port** offload which, by >>> definition, will set the offload to each of the queues. >>> >>> it is not “enabling queue offload on the port”. >>> >> I think it would be really useful for understanding to highlight >> that what is enabled on port level is enabled on all queues >> regardless queue conf. > Why not to allow queue offloads to override port offload for given queue? Basically it returns us to the initial point made by Ferruh: If device has no queue offloads, but application still has to repeat port offloads in queue offloads.