From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 38C6758C5 for ; Fri, 30 Sep 2016 12:45:20 +0200 (CEST) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga105.jf.intel.com with ESMTP; 30 Sep 2016 03:45:18 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,272,1473145200"; d="scan'208";a="885408688" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.221.70]) ([10.237.221.70]) by orsmga003.jf.intel.com with ESMTP; 30 Sep 2016 03:45:18 -0700 To: Chas Williams <3chas3@gmail.com>, dev@dpdk.org References: <1475144449-22176-1-git-send-email-3chas3@gmail.com> <1475144449-22176-7-git-send-email-3chas3@gmail.com> Cc: harish.patil@qlogic.com From: Ferruh Yigit Message-ID: Date: Fri, 30 Sep 2016 11:45:17 +0100 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <1475144449-22176-7-git-send-email-3chas3@gmail.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v2 07/10] bnx2x: Serialize access to pf2vf mailbox X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 Sep 2016 10:45:20 -0000 On 9/29/2016 11:20 AM, Chas Williams wrote: > The pf2vf mailbox can only be used by one thread at a time. > > Fixes: 540a211084a7 ("bnx2x: driver core") > > Signed-off-by: Chas Williams <3chas3@gmail.com> > --- > drivers/net/bnx2x/bnx2x.h | 12 +++-- > drivers/net/bnx2x/bnx2x_ethdev.c | 2 + > drivers/net/bnx2x/bnx2x_vfpf.c | 113 +++++++++++++++++++++++++++------------ > 3 files changed, 88 insertions(+), 39 deletions(-) <...> > void > @@ -379,9 +406,9 @@ bnx2x_vf_unload(struct bnx2x_softc *sc) > if (vf_id > 0) { > FOR_EACH_QUEUE(sc, i) { > query_op = &sc->vf2pf_mbox->query[0].q_op; > - bnx2x_init_first_tlv(sc, &query_op->first_tlv, > - BNX2X_VF_TLV_TEARDOWN_Q, > - sizeof(*query_op)); > + bnx2x_vf_prep(sc, &query_op->first_tlv, > + BNX2X_VF_TLV_TEARDOWN_Q, > + sizeof(*query_op)); > > query_op->vf_qid = i; > > @@ -394,13 +421,15 @@ bnx2x_vf_unload(struct bnx2x_softc *sc) > if (reply->status != BNX2X_VF_STATUS_SUCCESS) > PMD_DRV_LOG(ERR, > "Bad reply for vf_q %d teardown", i); > + > + bnx2x_vf_finalize(sc, &query->first_tlv); This cause a compilation error with clang, seem a valid error: .../drivers/net/bnx2x/bnx2x_vfpf.c(412): error #3656: variable "query" may be used before its value is set bnx2x_vf_finalize(sc, &query->first_tlv); ^